Received-SPF: pass (google.com: domain of linux-kernel+bounces-136120-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon,  8 Apr 2024 19:01:37 -0700
In-Reply-To: <20240307005833.827147-1-seanjc@google.com>
Precedence: bulk
Mime-Version: 1.0
References: <20240307005833.827147-1-seanjc@google.com>
Message-ID: <171262710736.1419672.15334456430797702599.b4-ty@google.com>
Subject: Re: [PATCH] KVM: x86/pmu: Disable support for adaptive PEBS
From: Sean Christopherson <seanjc@google.com>
To: Sean Christopherson <seanjc@google.com>, Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, 
	Like Xu <like.xu.linux@gmail.com>, Mingwei Zhang <mizhang@google.com>, 
	Zhenyu Wang <zhenyuw@linux.intel.com>, Zhang Xiong <xiong.y.zhang@intel.com>, 
	Lv Zhiyuan <zhiyuan.lv@intel.com>, Dapeng Mi <dapeng1.mi@intel.com>, 
	Jim Mattson <jmattson@google.com>
Content-Type: text/plain; charset="utf-8"

On Wed, 06 Mar 2024 16:58:33 -0800, Sean Christopherson wrote:
> Drop support for virtualizing adaptive PEBS, as KVM's implementation is
> architecturally broken without an obvious/easy path forward, and because
> exposing adaptive PEBS can leak host LBRs to the guest, i.e. can leak
> host kernel addresses to the guest.
> 
> Bug #1 is that KVM doesn't doesn't account for the upper 32 bits of
> IA32_FIXED_CTR_CTRL when (re)programming fixed counters, e.g
> fixed_ctrl_field() drops the upper bits, reprogram_fixed_counters()
> stores local variables as u8s and truncates the upper bits too, etc.
> 
> [...]

Applied to kvm-x86 fixes, thanks!

[1/1] KVM: x86/pmu: Disable support for adaptive PEBS
      https://github.com/kvm-x86/linux/commit/9e985cbf2942

--
https://github.com/kvm-x86/linux/tree/next