Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp1720675lqe; Mon, 8 Apr 2024 19:36:20 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVMJRsGmwYh0OP2ESjTZe/+mfxIjLedPnrr/kkIIGXY+omINbsMynBqvVZl37kVwvmMV2cO8QBcfZpb2mcJChd81gmGWf5FrrLHlWi/tA== X-Google-Smtp-Source: AGHT+IGTXbN7oU7MhtOV8bGzyvl6DiGNPeT0LGO7wsYES1WlBngUUgFkYFlgEn4r9vvb5I8UWV2P X-Received: by 2002:a17:90a:7402:b0:2a2:97f3:83b3 with SMTP id a2-20020a17090a740200b002a297f383b3mr8366240pjg.48.1712630180297; Mon, 08 Apr 2024 19:36:20 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712630180; cv=pass; d=google.com; s=arc-20160816; b=duh9jEkIgI6Z98zKF8QlpzYgz44Avfp9th+NsVDCr5ZadVsFCzUbfcmMJ2ZspcDKTh VzCGsU/jrIzeck/6XPZ2bM5PyHbeIY7iCYqkQEXo8/LrnyEDdWQAYuTqo7i4plFFTGUD r7nfn7++wMjOOjwAjnIzkJUYW6a/ktWfUq36rdq34rc5aOg5Twcu/QB82tQyp+U7C7Zc nzdmjfaCoUPnd2wi+Rieq7RDU9yiD+tgtpzT4yh0yk7XFcAn6gVPgEo7deTHAL8R21gt uspm7oXQVTfqXpSJ70067I6Pz2/j73lgzjVGRW1Lv6+k589bt2aQ1jO7qJaMPn7Qekjp ct+w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=to:from:subject:references:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:in-reply-to:date :dkim-signature; bh=4JjU99n3cntJzSuWKEHlCabsCaDKhMo8d9uJcAKSqpE=; fh=fHNsfU907I+GQSh4j38mG7V0zJ/VLLWCOwC6Mpawt+8=; b=Hc8CKu7zDHF/JimveUjJGDOCobjn3hXXFZI1rz/fsk6sU5OwKr08LvC7kcuywGtXyz wHzcH8IKUZxlcynSBotJBjsPrrBk8rw7cG+vVUjszT6pdzDvooyBYrMASiBKuLrfi7bb MFWlUae0K/4xjyO2cL+7hNZfhCgCj1/oMUTXlohMWhujCRUfIOJwHyzyG8ZvuOyjDCTv UcfZieUp1/XbPGPaNi8FKQTeHSfV+WppmaMai9wQ/OGRJYXJuB+jGwm0C2gig12csLQe Xb7UzTmt7Mp3JHH8fvmbwsdXlmwqx9DgNAgnUXd8UKCBTbh4j5csctm5cuiVC2o0mLtS QEiQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=1PthwBvX; arc=pass (i=1 spf=pass spfdomain=flex--irogers.bounces.google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-136137-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-136137-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id s13-20020a17090aad8d00b002a291738b3fsi9628749pjq.172.2024.04.08.19.36.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Apr 2024 19:36:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-136137-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=1PthwBvX; arc=pass (i=1 spf=pass spfdomain=flex--irogers.bounces.google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-136137-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-136137-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id C9DCFB24C10 for ; Tue, 9 Apr 2024 02:33:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 317A8657D5; Tue, 9 Apr 2024 02:32:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="1PthwBvX" Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3E325464A for ; Tue, 9 Apr 2024 02:32:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712629949; cv=none; b=SiE9yNW2UwsPZqHYGH+gyS2pyuEdBEGgIHhOoBGJcRxHDcwGRcOjlVhQLbY2kpu4wayih42n+tPBBg2MRhryoMMEnPlGyZxYT5Cu+W/vIN4O8vP4IAreF+tCLkGOwKRStjbFtlYvZEjt1hWD2UDwO7qrh7aUtWoVuT2fQvXiNHo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712629949; c=relaxed/simple; bh=PL/A3WVadEL63FKjbVqnoa/RshNov2kFBvTQ0RAhX60=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Content-Type; b=Ep+q3h+HxNrYRVdAxT04u2tUMlK6b5x+GVkJTCB7n9kvPZKYack30G1qoay89/o49CKomHLgl/BT8VLZGUbH7ipldmMSXQACYEPVUN/fTIlUrg8dVfSsWCFITRqhBiFFkIly4lyEssWFi7hj4t8iBVNoub9NN3U/MnUSsQnNTpE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=1PthwBvX; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-dc6b26845cdso7225386276.3 for ; Mon, 08 Apr 2024 19:32:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712629947; x=1713234747; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=4JjU99n3cntJzSuWKEHlCabsCaDKhMo8d9uJcAKSqpE=; b=1PthwBvXPHwvvmq6plmmvmLYVnOlygUuuRIINo98O3rrNKn0jObdQAfTok4aTPei3j XxRd+tcDDPf4pf7l4J6UQw3IJ+cbnFitt79aa+J9EUZYkMn6Fps9YKuaLfWO7s5LFcNS ktU5ez2sUtVi7XH+dNL64ESAS69nA8IAD31AdnzyWMQehJHlJii+LMo9S8TKTA369Pcn xmyRHXTLVYbNx8XknFWtmo9Ee/ifK79tiPt5uOK0fXK5j5hkwjmh1nOtEMbAGBp37aST oumd1fc5uy/1m//A1fepNCDQbGCy1UYYn23Vza9eb3fNf3dydx+udtWIKUGNdj5r5+BD G6TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712629947; x=1713234747; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4JjU99n3cntJzSuWKEHlCabsCaDKhMo8d9uJcAKSqpE=; b=xGDg1ZnWu4de4EvDq4SoXmmRpcLKW/w6h4joRlO9gljVTcpV2TuCRznooQUzFjxp+F KzvMRaDYP5aasanIkbLDjQpIQ90SS3bcKdAqVc9DxF3CeSOTPDwA1S2DY3WPyWDhjaEZ 4P/w5GuSCeKCyIOljYDIpuJFqO0X6VHFqHErTVzKqJEP9URuGXWtJRxVVdizpdtc3grG xY1++iGckgGqbiEiIb2eeYGopHQ8O6gHpvh6KebG3Z9dYZG9HfsIAcJKbkBl9stqRbPg FSM7mYS+eb1V4dTF3u7aP/nopFpwU+wbEHFDiHRA5MbeuK3eIRAYyj2OhNkVpHbpaj+y xctw== X-Forwarded-Encrypted: i=1; AJvYcCXCjJybhqVK2nWsV5xpWWfVBXHbs1yWOpokTlAJTC4/AfIustkPT/kvOTq9yNpTRpkhUOgVrtrcZ0Mvz8u4yevCoFISk6mSL9MwOJDV X-Gm-Message-State: AOJu0YzdrYbldICsTZ4fDbPhmZlS+6ui2qH2snbYADjFjJ0sYD8Cd0q0 XbqyqFMDnHRbenfMJPU+vZJLuUzZq6S10X3y9G6fDQfJ/AWZ05K7oO6rJTG+V9gHzOVnOwvfXTx PDZ44Iw== X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:5520:7788:6b7d:7115]) (user=irogers job=sendgmr) by 2002:a25:a288:0:b0:dc9:5ef8:2b2d with SMTP id c8-20020a25a288000000b00dc95ef82b2dmr3131277ybi.4.1712629947067; Mon, 08 Apr 2024 19:32:27 -0700 (PDT) Date: Mon, 8 Apr 2024 19:32:15 -0700 In-Reply-To: <20240409023216.2342032-1-irogers@google.com> Message-Id: <20240409023216.2342032-4-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240409023216.2342032-1-irogers@google.com> X-Mailer: git-send-email 2.44.0.478.gd926399ef9-goog Subject: [PATCH v1 3/4] perf util: Add shellcheck to generate-cmdlist.sh From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Ravi Bangoria , Kajol Jain , Athira Rajeev , Oliver Upton , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Add shellcheck to generate-cmdlist.sh to avoid basic shell script mistakes. Signed-off-by: Ian Rogers --- tools/perf/util/Build | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/tools/perf/util/Build b/tools/perf/util/Build index aec5a590e349..292170a99ab6 100644 --- a/tools/perf/util/Build +++ b/tools/perf/util/Build @@ -389,3 +389,17 @@ $(OUTPUT)util/vsprintf.o: ../lib/vsprintf.c FORCE $(OUTPUT)util/list_sort.o: ../lib/list_sort.c FORCE $(call rule_mkdir) $(call if_changed_dep,cc_o_c) + +ifdef SHELLCHECK + SHELL_TESTS := generate-cmdlist.sh + TEST_LOGS := $(SHELL_TESTS:%=%.shellcheck_log) +else + SHELL_TESTS := + TEST_LOGS := +endif + +$(OUTPUT)%.shellcheck_log: % + $(call rule_mkdir) + $(Q)$(call echo-cmd,test)shellcheck -a -S warning "$<" > $@ || (cat $@ && rm $@ && false) + +perf-y += $(TEST_LOGS) -- 2.44.0.478.gd926399ef9-goog