Received-SPF: pass (google.com: domain of linux-kernel+bounces-136168-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: "Manoj N. Kumar" <manoj@linux.ibm.com>,
        "Matthew R. Ochs" <mrochs@linux.ibm.com>,
        Uma Krishnan <ukrishn@linux.ibm.com>, Arnd Bergmann <arnd@kernel.org>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
        Arnd Bergmann <arnd@arndb.de>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Bill Wendling <morbo@google.com>,
        Justin Stitt <justinstitt@google.com>, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] [v2] cxlflash: fix function pointer cast warnings
Date: Mon,  8 Apr 2024 23:08:51 -0400
Message-ID: <171260277849.3109929.1668041090243479256.b4-ty@oracle.com>
In-Reply-To: <20240404161524.3473857-1-arnd@kernel.org>
References: <20240404161524.3473857-1-arnd@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

On Thu, 04 Apr 2024 18:14:58 +0200, Arnd Bergmann wrote:

> Calling a function through an incompatible pointer type causes breaks
> kcfi, so clang warns about the assignments:
> 
> drivers/scsi/cxlflash/main.c:3498:3: error: cast from 'int (*)(struct cxlflash_cfg *, struct ht_cxlflash_lun_provision *)' to 'hioctl' (aka 'int (*)(struct cxlflash_cfg *, void *)') converts to incompatible function type [-Werror,-Wcast-function-type-strict]
>  3498 |                 (hioctl)cxlflash_lun_provision },
>       |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/scsi/cxlflash/main.c:3500:3: error: cast from 'int (*)(struct cxlflash_cfg *, struct ht_cxlflash_afu_debug *)' to 'hioctl' (aka 'int (*)(struct cxlflash_cfg *, void *)') converts to incompatible function type [-Werror,-Wcast-function-type-strict]
>  3500 |                 (hioctl)cxlflash_afu_debug },
>       |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> [...]

Applied to 6.10/scsi-queue, thanks!

[1/1] cxlflash: fix function pointer cast warnings
      https://git.kernel.org/mkp/scsi/c/28fc2bd2c729

-- 
Martin K. Petersen	Oracle Linux Engineering