Received-SPF: pass (google.com: domain of linux-kernel+bounces-136176-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <65e1a55f-eac7-4804-900e-abf1bc0a9041@intel.com>
Date: Mon, 8 Apr 2024 20:13:58 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 02/31] x86/resctrl: Add a helper to avoid reaching into
 the arch code resource list
To: James Morse <james.morse@arm.com>, <x86@kernel.org>,
	<linux-kernel@vger.kernel.org>
CC: Fenghua Yu <fenghua.yu@intel.com>, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, H Peter Anvin
	<hpa@zytor.com>, Babu Moger <Babu.Moger@amd.com>,
	<shameerali.kolothum.thodi@huawei.com>, D Scott Phillips OS
	<scott@os.amperecomputing.com>, <carl@os.amperecomputing.com>,
	<lcherian@marvell.com>, <bobo.shaobowang@huawei.com>,
	<tan.shaopeng@fujitsu.com>, <baolin.wang@linux.alibaba.com>, Jamie Iles
	<quic_jiles@quicinc.com>, Xin Hao <xhao@linux.alibaba.com>,
	<peternewman@google.com>, <dfustini@baylibre.com>, <amitsinght@marvell.com>,
	David Hildenbrand <david@redhat.com>, Rex Nie <rex.nie@jaguarmicro.com>, Dave
 Martin <dave.martin@arm.com>
References: <20240321165106.31602-1-james.morse@arm.com>
 <20240321165106.31602-3-james.morse@arm.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240321165106.31602-3-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dG5MRmQyQ0k3RjM0ZXFEVzErcDBEY2hIL3NIQ0pUZHZiUHdIY2srUk9sK1Ur?=
 =?utf-8?B?NkZvK0U2YnEwTUIxcEtxRys1cCtXem1BNHBjbTAyOE4rUFArOEhIbUJENlpJ?=
 =?utf-8?B?dlFaT001Q0I1VEcrUjlpdDhlbG9BK0hkRFVYUGtMbmEvRWRsZ3YyYk1yalNh?=
 =?utf-8?B?MDVVb1BJT2Nhb1dnM3paTnlUWGtuNkZiQTV0QlZXMTJqZG5La1VHaEsvdDE4?=
 =?utf-8?B?M1NNenZQRU1QNzc5Rk9GeTFvb3hIU0FlNG1zL3FjeWg2Z0NUNER0MU9JV3lH?=
 =?utf-8?B?TXErNHJha3ROWnE2SmFKRCtNOXB3TENKUU1oZWttVmFESGNpZWxiNDlDV0J3?=
 =?utf-8?B?RFo4VHBka3ZFaWRCdmZ4eUJuV0NwMVp2ajg0VjBVSzZDQ3loZlNYVkpCMzEz?=
 =?utf-8?B?SGJ1V2kzWjNUOVYzRkpBaUUzWWIxYmlkNDJRczFpUU9zb1piRXdqR3NDMmMr?=
 =?utf-8?B?L3NVSWIrcWZTV2J4eWlZdWtqd25ObytVOTRHQUZ2Vi91RGZwYk1yOXRCNEZ0?=
 =?utf-8?B?VHlNUU5aYU5xM1RiM2NqZ1JBMWhOTDRESFBCYStBK2F3Y2drSzF6QzZnam1u?=
 =?utf-8?B?bjlCL0diaktOME9HYlhVaDVQZXNIeklpRVFIczhOTWx6ZVg2TlJwOGExd1NU?=
 =?utf-8?B?bXlNcHZMc2NPWTdpQysxN3B3NTd6K1pGME1xT1cyWnBubEgrKzFsT2dqOURG?=
 =?utf-8?B?Wm9QQUVJMU00Y0JJblBuMGVXZVVndU1BTHN1Smk5OU5kemZSUHlwQzdVL29v?=
 =?utf-8?B?ZWZCRk9IbEZLOWRpYXJYNlZFbUwvb2M2OVRjRTBqL1FUeEdxZGkvcGc0SGhU?=
 =?utf-8?B?VHZ4WncwSCtQbXJmeThzSnNwOWdDakZzZTVGdmJidlRhSnM4VkNoeFhnVkNv?=
 =?utf-8?B?ZDJHRnFyUTN0bDl4aEhhczVSUEl6TDB4TmUrRzAvdjgwVmZ3U1VRbVB6enhH?=
 =?utf-8?B?aXc3QytIZU12LzBqcnJKVHVubWxwRWxmdWJUdFZKUEtaNDJycVBnRDNLOElF?=
 =?utf-8?B?TXM0UU5tUUd4QjFvbHI0V0VKTlhwQzIrbFJjR1hRSVkzQSszYW1TeGdFdkND?=
 =?utf-8?B?S1hTS2tqU255ei9zekE3WXVPR1JwV0lEcDdQQWpPZGxnTWFYSlZVcmpLclhY?=
 =?utf-8?B?Q2hRZ1BPNUNwZCtFcmsrM1FMaGw0MmFxZTNFRThFdVVJYVpPeXgyMXdYYXlv?=
 =?utf-8?B?RmdGSVBOM2NmM1dVZGpyc2lXTmxwVE5CcGNFZ0lOU2h3cWljR2p3U0NTNFJi?=
 =?utf-8?B?RjNwTkpGakdJVlhFajZOSWI0aWF2VUV0ZDFFcjJwODRrMjA2bkExUHhNVzE2?=
 =?utf-8?B?b2N4Nnl2WXE2WUZXdVQxOXFMWUFtVkZ5VStZRTk3WS91amF2NGlxRytRa1U1?=
 =?utf-8?B?WDRSbzdVOU5rZm43Vm16ZmVLbUo2cUpBRWgrZ2toTlJGTS9abXREZFJtSURB?=
 =?utf-8?B?Vm9CS2E0OU9BTTdIa3pTdXpjbzNIWGhxMW9ZSzU5UjFlSXVBZU4yOGUxbTg0?=
 =?utf-8?B?UG4wYTJnWEdab1N3YWdxL3NYeEtiQXFSTUJlZGh4MU1KeHhFdDZGc2YremlK?=
 =?utf-8?B?ZlZuQ084TkgrUXF2ZnlPaU93MkhtcVpjeVlyRUkzU0drUFpGckFYdWdtZVJq?=
 =?utf-8?B?TWR2eDJscm16NUQreGE3SVRVSWVhVVhqOEczQ1doazZiMXZjRW9IRWtkME0y?=
 =?utf-8?B?K1FtLzlHbXIvY1k2cXlrTkgwWURxdjhkZzJLYjJhb0NycEpnWnZHdnlqVGdm?=
 =?utf-8?B?NHI1VGRxTEFoYTdsblJMVWtYYk1qZHFDdFpRblZUakp2VE02Njd6K2lpZ2Ja?=
 =?utf-8?B?NGhEeXpKZ1YrRkwrVTdvN0dBOEdvNVdQTzZqYUtLSWx5UnZQQlZnaUZTL08v?=
 =?utf-8?B?KzBaVE5YQ2tQc3JWQTV0YWEzeU1FR0REUkRHeXJ5UUM4QjJIeGdzUVdvWVRH?=
 =?utf-8?B?RUp1NkFVK1dsdnRjYmxwdzNUSFlXeXZ0V0dUR3psRDdoUDN1dEhuaGxqM2ht?=
 =?utf-8?B?Vit0U25SclVOalNiU2F0TldnUkh3Nmc0R21uUjMrNCtoYlZvNGUySEw0ckcz?=
 =?utf-8?B?TW5Hd2Q4TUNBSWtYQ1JJTk9Zc0t3SThURjJBTmRWREozMmxiZGxRZlFuZWR3?=
 =?utf-8?B?ZnNaTElSWjVEZU9xWnVyRy82RGhJVElxRVJJcWlQTml5dXMvdnNmajltZlVn?=
 =?utf-8?B?dVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9cf9f2e9-a3dd-4425-bcd8-08dc58431a8e
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2024 03:14:01.2321
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VxvDYwRe6CEKw8xzANGcOK1Ew4kJXTMqLoWi0vlkl6UH9qvYtrXzQ0E23N3iXXYzdZmbZ+QIdsCUFQW0bw7lc7e8WPGdSlFlXLOiDeWkeio=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4783
X-OriginatorOrg: intel.com

Hi James,

On 3/21/2024 9:50 AM, James Morse wrote:
> Resctrl occasionally wants to know something about a specific resource,
> in these cases it reaches into the arch code's rdt_resources_all[]
> array.
> 
> Once the filesystem parts of resctrl are moved to /fs/, this means it
> will need visibility of the architecture specific struct
> resctrl_hw_resource definition, and the array of all resources.

rdt_hw_resource?

> All architectures would also need a r_resctrl member in this struct.
> 
> Instead, abstract this via a helper to allow architectures to do
> different things here. Move the level enum to the resctrl header and
> add a helper to retrieve the struct rdt_resource by 'rid'.
> 
> resctrl_arch_get_resource() should not return NULL for any value in
> the enum, it may instead return a dummy resource that is
> !alloc_enabled && !mon_enabled.
> 
> Signed-off-by: James Morse <james.morse@arm.com>
> ---

Patch looks good to me.

Reinette