Received-SPF: pass (google.com: domain of linux-kernel+bounces-136179-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <c8d1f4ec-eb38-4846-a6ae-722e39ab75f9@intel.com>
Date: Mon, 8 Apr 2024 20:15:03 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 04/31] x86/resctrl: Add helper for setting CPU default
 properties
To: James Morse <james.morse@arm.com>, <x86@kernel.org>,
	<linux-kernel@vger.kernel.org>
CC: Fenghua Yu <fenghua.yu@intel.com>, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, H Peter Anvin
	<hpa@zytor.com>, Babu Moger <Babu.Moger@amd.com>,
	<shameerali.kolothum.thodi@huawei.com>, D Scott Phillips OS
	<scott@os.amperecomputing.com>, <carl@os.amperecomputing.com>,
	<lcherian@marvell.com>, <bobo.shaobowang@huawei.com>,
	<tan.shaopeng@fujitsu.com>, <baolin.wang@linux.alibaba.com>, Jamie Iles
	<quic_jiles@quicinc.com>, Xin Hao <xhao@linux.alibaba.com>,
	<peternewman@google.com>, <dfustini@baylibre.com>, <amitsinght@marvell.com>,
	David Hildenbrand <david@redhat.com>, Rex Nie <rex.nie@jaguarmicro.com>,
	"Dave Martin" <dave.martin@arm.com>
References: <20240321165106.31602-1-james.morse@arm.com>
 <20240321165106.31602-5-james.morse@arm.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240321165106.31602-5-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cFBJU3RyY1d5ckl5UE11bWV1T1BnNjMrWWJSTHdxZjhqZ0JGOTg1dXAxNktI?=
 =?utf-8?B?dEIzQ0tiYWpDUEg1S1Q5NGFvUStDMFQ2TFgzQVMzK3M5NnluY0pYUDlOQjdz?=
 =?utf-8?B?alVYcy9FcUZreVdYTjNMQi9uTlJMcnZLb25RM1VleW9tS1hrVmpONUR5d2Zj?=
 =?utf-8?B?REFpSmJlOU9meXh4dXBGRkl4NFF2SDJjYVZpbmN0NmNMWmJHdWJjWmY3TFdE?=
 =?utf-8?B?dm84QnBjdWp1bXpzOGVtdmQvODlxSHlURVpLQ2s5OW1wTlcvTXd3bzAvaHRq?=
 =?utf-8?B?Q0kvUWNkeWVmdUxSMXlhbi9ISzM0TkJhSldhVmdWK0ZiaHhFR1dxbWJCTlpZ?=
 =?utf-8?B?cXBtL0lkOFlnNGJLbTE2aEVVOHFuY3N5YVhwb1VqR2lQMWQvUW1qWFpnc05R?=
 =?utf-8?B?TU1GM081QlplQzQramk2b3F2Mnp3TFRONEtmL3pJMDk3ekZ5V2ZodkIxNVhj?=
 =?utf-8?B?d0I3ZE1IeERBbVNIcHFJYUgyMzMvbE9KWHZnbytLRnJWemVTdTVDdDRmaDlx?=
 =?utf-8?B?R2NmSHo1K3VBUlZrMXdQTUd0TTcvNXhvaytlODBFTHJiaGZjYWhzT1I1VDdS?=
 =?utf-8?B?ODZyTEJxbnFwaWJXTlVZSTgxeWlXcWRRV0o4bkRtY2tLUzBSK1BrYmNTaFZM?=
 =?utf-8?B?eERwRko2bUZVdTQrUEhUanNtV0FEcDNiRjZheDVEUTU0bVNHK2RweG1BV1M2?=
 =?utf-8?B?TlV3WTFwa1ZWNnUyRWpaOVc1ckNob2VIT2h5d3RnaGtMdEFRa0h4WmJoTlM0?=
 =?utf-8?B?N2J0UHZYMTBVVWNEeVphSWh0N2J1dGZ4L21NMzgrWGM0TFN5WGdxQ1dzY1B4?=
 =?utf-8?B?ME1ScVdOYnBNcitVNGh3ZjhCOGxxTVVSWVNkb3dEbmg4MXlmaFd5UTdaWEZO?=
 =?utf-8?B?RGxqKytwOUdqTTV0dExSTmhWK1ZIVUNWU0RzTVRpbmhObE9PR1pWZEg5TGkv?=
 =?utf-8?B?M0E2aHBTTFdpdlJSWFRQWUZrN0pYNTkxWU9mSFY1cXRsT2tldFA3MW5mWnI2?=
 =?utf-8?B?RmVEcTJObnJwUEw4NXlyeGFXZG8vcFYwT3VPdjBFUmpiUkh6Y0xaM2gvdERC?=
 =?utf-8?B?MExSdVl4dVBJbGM5a21YK0RZRjJFbW1yMTVKUWtjS0dHMXB6R1Nvd2svWDhF?=
 =?utf-8?B?UXB6c0NqK2UzSmhHVCsvVFJVb0UzMUw4S3gxOVFLZU5ZYWJkMThkdUYzNFVM?=
 =?utf-8?B?Y243aVVuUGF3amNoQlhxSmpGNUF4M1ZhRmRPdkYxY25WQkZDeSt3bWdhRFdz?=
 =?utf-8?B?UUJWMzVuWXp3TkxyaFFyVm9xVjdXTnpjTGlESk9tMzJUUmpIRGQreUp2M1p4?=
 =?utf-8?B?T0M3ZnpHenNHdklaZEIxeW13eXNBeTdWQld5RVBoZ3VOY0NjUkFxd0Jib3Jy?=
 =?utf-8?B?Zy9iVlgvSmZiS2RpNzNNeDk3c1JZTUpnWURQZUtKOG82THVuS25TYmdxc3Nv?=
 =?utf-8?B?dXFwdzRmbWJWaGdlT2UreDJyYm11N21kVHloNWE5amdRSStWbjNQdVNTRVVY?=
 =?utf-8?B?TjcwYnhHREdsT3lOOWp1NFFXbUNUaEw5ZWFjZDFNV0VmSHZmZi9aRmlmSHRr?=
 =?utf-8?B?MDJaa0o5eWszanB1ZWIxVjhoaENyNHNCYnVvU01vSkZUT1BmZS9yVzhTQ05z?=
 =?utf-8?B?aDhNaHowN21uWjIzaERNeGZuaDc2OENnTXJ3Wm1BVUE3bldIK0ZCblgrd3g5?=
 =?utf-8?B?eGNsTGpnVW1scWJtMzRwWnpGMlRVSXg2K2JrVHhBNFlsTk9OTU8vWGdLQVMy?=
 =?utf-8?B?c0VNYmxKWmNZbndCbm5GQkg3alNmMVVCdnZWZnNmRTVRN0RsbkJ5T05DdlBC?=
 =?utf-8?B?dlFET2N5UlhjN3ZleCt6Mnp0cVpPbjRLRkJXVHI5VWViM3NtZjRrUjJ2cTk1?=
 =?utf-8?B?ejhabzBPeXRyVjdXanBYZENkMlJsaTVpS1RaV1JOSEJmWUdlN05jZ1Aza3FC?=
 =?utf-8?B?RkJKUUtXeit2YkRpUU4zeGNhWCtCNGl6R3NrNFJiVy9jWnhScmVUS0FMSlhs?=
 =?utf-8?B?aHhwdytLYnJFVFlTbkt0ZjhmbVBTaXZqN0lRcW1OekdDWVhBTEwzQ296TmNI?=
 =?utf-8?B?QTJxU0V1TXB0VmtoU0NBMVdiOEtsRmdla3VqLytWa2U0VEFia3BFMXJwQ2F4?=
 =?utf-8?B?U1lpZU9INWVZZHBCQ2dUbFpWUDJEd3h0NFdCM0hyYkgvUStmK0VBU2FnR2xh?=
 =?utf-8?B?K0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 75c97a8f-bd21-4a0f-a5b1-08dc5843413a
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2024 03:15:06.1250
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JMvCBClxOOOXhwQ/Oo45x3tFgdDqV2Uc+8BqImkJfMuWsWIgvY8a7edsiNnHRaO9lf1Pm7SAoZPsLLjVZk5fPO4Abr7xtrz4rxLTP0/Gt5M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4783
X-OriginatorOrg: intel.com

Hi James,

On 3/21/2024 9:50 AM, James Morse wrote:

> --- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> +++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> @@ -3623,14 +3623,18 @@ static int rdtgroup_mkdir(struct kernfs_node *parent_kn, const char *name,
>  static int rdtgroup_rmdir_mon(struct rdtgroup *rdtgrp, cpumask_var_t tmpmask)
>  {
>  	struct rdtgroup *prdtgrp = rdtgrp->mon.parent;
> +	u32 closid, rmid;
>  	int cpu;
>  
>  	/* Give any tasks back to the parent group */
>  	rdt_move_group_tasks(rdtgrp, prdtgrp, tmpmask);
>  
>  	/* Update per cpu rmid of the moved CPUs first */
> +	closid = rdtgrp->closid;
> +	rmid = prdtgrp->mon.rmid;
>  	for_each_cpu(cpu, &rdtgrp->cpu_mask)
> -		per_cpu(pqr_state.default_rmid, cpu) = prdtgrp->mon.rmid;
> +		resctrl_arch_set_cpu_default_closid_rmid(cpu, closid, rmid);
> +

While I understand that the CLOSIDs are the same, I do think it looks unexpected
for the CLOSID to be set to the CLOSID of the group being removed. Could this
be set to CLOSID of parent group instead?

Reinette