Received-SPF: pass (google.com: domain of linux-kernel+bounces-136184-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <e74077e1-3c5b-4126-a567-4b4b04f5367d@intel.com>
Date: Mon, 8 Apr 2024 20:16:32 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 06/31] x86/resctrl: Export resctrl fs's init function
To: James Morse <james.morse@arm.com>, <x86@kernel.org>,
	<linux-kernel@vger.kernel.org>
CC: Fenghua Yu <fenghua.yu@intel.com>, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, H Peter Anvin
	<hpa@zytor.com>, Babu Moger <Babu.Moger@amd.com>,
	<shameerali.kolothum.thodi@huawei.com>, D Scott Phillips OS
	<scott@os.amperecomputing.com>, <carl@os.amperecomputing.com>,
	<lcherian@marvell.com>, <bobo.shaobowang@huawei.com>,
	<tan.shaopeng@fujitsu.com>, <baolin.wang@linux.alibaba.com>, Jamie Iles
	<quic_jiles@quicinc.com>, Xin Hao <xhao@linux.alibaba.com>,
	<peternewman@google.com>, <dfustini@baylibre.com>, <amitsinght@marvell.com>,
	David Hildenbrand <david@redhat.com>, Rex Nie <rex.nie@jaguarmicro.com>,
	"Dave Martin" <dave.martin@arm.com>
References: <20240321165106.31602-1-james.morse@arm.com>
 <20240321165106.31602-7-james.morse@arm.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240321165106.31602-7-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Zy9hb1ZlV0Zyd1JaM2thREsxNGlVUHJOVmIxaFEycHh6S0MyZTVnTkhwdWo1?=
 =?utf-8?B?WkxrSCtDN0I3VWR5WFFRQlhEYVZkc0hFVEUzSnpMc2tPTEl4aklwYlpoVUFW?=
 =?utf-8?B?ZjZQR25zR0JuT0syKzlkdlpuUEh1V0xTNlpDa0swcHM2K3J2ZWZLMkcxcmVI?=
 =?utf-8?B?NTFIaC9RRDVLV3ZLVTZyMS9vMnN5bFZ5bm1vNzNOeGExVzk1RG5TTDd4OC9L?=
 =?utf-8?B?WHFjVE80K1VuWlZuWjFibWJ3MUhKWkZPVzRKZFUrRmlZOTVudU9QYVZQTkNH?=
 =?utf-8?B?NUJ1SGVSa0RsdVE3dmxWRzVuZlVaeURSNkhVWDRzZXFUNFJZTXk0RTdiSGNG?=
 =?utf-8?B?eVpzODNZalp1QmYybFB4S09yWHZvNkI1REZDVnpnZ01BR1pJeEtscmFFSDUz?=
 =?utf-8?B?TVlDaHFSUEs3ajhvYTNOVUlWSEg2OU9yS25BelV3SlpNTTM4am9LZk5PcWJN?=
 =?utf-8?B?RlFWVHNnWjA1YmVUVEkzVkNPUXVvOVlubytYRUZhYWtzSENHSkpDSUhlVUdE?=
 =?utf-8?B?NlFvMllteFE5UktPVFp1QWN2QWlrY0ZpWjllQWRDaEZ6TUZTVHdqUytZNzV4?=
 =?utf-8?B?TmpyVnVIUHQwT0FHdi9VUm1sbW1pbmUvSVhybmZYOXNQQmk2dFIvdy9JQ3BE?=
 =?utf-8?B?WDlWcVppZWVsSm9nZ2ZXc3RsRS81WEl1UXBxbjIwVWUzbVJaOHlFV3ErMWtt?=
 =?utf-8?B?SUU1b0RVSUhGT2ZtclpmcFpEajVFWFVvRWpDVVdzM1lublpISkt2YTFOZXRi?=
 =?utf-8?B?TVFyemw5amxQVnVUdzdjMUIwNWZ1YjdEdUpUSHZwckdiWlQrM2o4WmMyUml2?=
 =?utf-8?B?bENRd3BRZ2c3cWlaVDBOUGtsOE1GSXFYTVFYSEFqdjI4VXZSK01WdFg1T1RG?=
 =?utf-8?B?Y01lVERZWGtRZ3h4OTkzbEUxRncySmY0bDB6RkZKK1o1SWVSWWRkMzVCbmlH?=
 =?utf-8?B?bG1TTDhFU1RKWUdYeElSQ09VWWpJak9GV2gvWDlvd3VWdVFsSU9BTzBKNUFQ?=
 =?utf-8?B?U3RVT1Z1OXZjQmVHK1pxMTExY1g0QUxKUGMvcUJoMS9pU0F5M0VEL0V0OVNZ?=
 =?utf-8?B?dUJCSkYwZUV4Q3U3eStQa2Rtd2RzS3RLSGFCMW91R29Vc0tsaEkxaHJmV3FK?=
 =?utf-8?B?WmRReHFtVEVWeE5RbFNrQk93blBRc3NvdkFMcGc3eXBvYWx2bk5pcDlIRHhv?=
 =?utf-8?B?S0loN3FBL0NTVi9KQ1F1ZzFJSVBtS0IzaFVYTkp6ZHNmU2ZYMkxiNm9hMTQ5?=
 =?utf-8?B?bEptQVlPMFYxSFE1clBUL2ViOUdFQmZKR3lsOFlkdnVUQ3N3R0h5MDRmY3BQ?=
 =?utf-8?B?WFo4VnZ4WEdJbXl3UHZTMXZzUWdaU1UzbDVTaEs5MUlsdW9obEpJNW1RazVt?=
 =?utf-8?B?Ri8wSjZKakQvMGp0TzVHZW9PMFE1T1Bja2kwWjYxclZGVUhaRG00UVdZSjhM?=
 =?utf-8?B?WVJWWTA2Mnd2bnhTVmYvdG9jK0MyNElIS2l6OFUvd3ZieDlnQ1YwUGRFNWx2?=
 =?utf-8?B?aitnVEVqT1g2N0Q4WmYxR0U4a0taNkd0eiswMy9qRUF0bkk0c2Vjek9JZGl0?=
 =?utf-8?B?bjVlU241WFFka3N1eTJ3VDlFQ2cwZHlPbnZYcTlMTVRVM3hOQ21lOU9EMHNX?=
 =?utf-8?B?Y0x1MWlOY0IraHY5VXk4bFVxRStiSGV5VHNzNnBtM3R4MENKZ1BKZ3ZPQUx5?=
 =?utf-8?B?L1kwRTJYeDRaMU81SXhBUC9kRk5UTWNiUmVLQmpYcDB6b1N0bkxVSVJZTVRM?=
 =?utf-8?B?MzRRS2ZQVkE1TXdQOXZydWpTeFg2MVVqb2tyd1BkSFMyZmYvd0pvZFRKQnFa?=
 =?utf-8?B?WXBVOGgyME5vZ1pQSnBrMjkxVlNrcEF0TkhRcCt0RUNxY3Bmb0kySWs4U3Nj?=
 =?utf-8?B?bkJIano3TjRSYkxLc3ZHbmt2b3RNK1NqRTVvUnVEejY2S3IyZ2RIZUw1Vlgz?=
 =?utf-8?B?SmZIa3JENnVWZnpIMHlxdk5QSVV1azB3aWlDWitOZ3U4aVBhQTFUdXRTSXlr?=
 =?utf-8?B?VjNCbFhyWHI0eXJ4Y0lrUTNQU05qWjN1MEJTR041dzNEU1I2bkZFL3BGL0RU?=
 =?utf-8?B?V3NGVnNQK291ei9od1RzWEhiZ3FYYm9iTDM4cHJlUnk5eE83cUVpbkpoQS9I?=
 =?utf-8?B?ZURhT0tMNHo5MmdGT0Q5SUp3YWQyMVhJT1lsT3laS0dsNFpHSEVZeUo0Z3pM?=
 =?utf-8?B?Z1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9156d4f8-18ff-43e5-2249-08dc58437630
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2024 03:16:34.9662
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ulEh/bFIZlBEf2qWeryMu86GtCw4Z2hRSws+T9YH5p8semNIbZIksPdbKbCFYMMJtgv/EJKjiC/s/xHJXAp6iHqjGje5Jx+p8C5KVMbcbH0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4783
X-OriginatorOrg: intel.com

Hi James,

On 3/21/2024 9:50 AM, James Morse wrote:
> rdtgroup_init() needs exporting so that arch code can call it once
> it lives in core code. As this is one of the few functions we export,

Please do not impersonate code.

> rename it to have the resctrl in the name. The same goes for the exit

"to have the resctrl" -> "to have resctrl"

> call.
> 
> x86's arch code init functions for RDT are renamed to have an arch
> prefix to make it clear these are part of the architecture code.
> 
> Signed-off-by: James Morse <james.morse@arm.com>
> ---

Reinette