Received-SPF: pass (google.com: domain of linux-kernel+bounces-136186-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <f0243dbb-f333-4c06-a315-ceaca8fa0bc2@intel.com>
Date: Mon, 8 Apr 2024 20:17:12 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 07/31] x86/resctrl: Wrap resctrl_arch_find_domain()
 around rdt_find_domain()
To: James Morse <james.morse@arm.com>, <x86@kernel.org>,
	<linux-kernel@vger.kernel.org>
CC: Fenghua Yu <fenghua.yu@intel.com>, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, H Peter Anvin
	<hpa@zytor.com>, Babu Moger <Babu.Moger@amd.com>,
	<shameerali.kolothum.thodi@huawei.com>, D Scott Phillips OS
	<scott@os.amperecomputing.com>, <carl@os.amperecomputing.com>,
	<lcherian@marvell.com>, <bobo.shaobowang@huawei.com>,
	<tan.shaopeng@fujitsu.com>, <baolin.wang@linux.alibaba.com>, Jamie Iles
	<quic_jiles@quicinc.com>, Xin Hao <xhao@linux.alibaba.com>,
	<peternewman@google.com>, <dfustini@baylibre.com>, <amitsinght@marvell.com>,
	David Hildenbrand <david@redhat.com>, Rex Nie <rex.nie@jaguarmicro.com>, Dave
 Martin <dave.martin@arm.com>
References: <20240321165106.31602-1-james.morse@arm.com>
 <20240321165106.31602-8-james.morse@arm.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240321165106.31602-8-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NWY0Z3gzQytIS3NGWEEwWTJHM1pLNDdMQ0JKdDNGaEZPQk5CMEYzNFZoamZU?=
 =?utf-8?B?bjVZSThicXl1c0lvbUk0dDQ2TGVBeGV2TFlIZXVBNTNDTmZDSTFJWHlaVXVy?=
 =?utf-8?B?QVpacUplR0lSbC9td3hOV0F1VWQzLzlmVllXVEd1Q0NwQUtWd1REYkM1WlV6?=
 =?utf-8?B?QXZrVnhpQmx3L1psUnI0dmNnUmpCUW10RG9hRmErK2trNEUrNDNlOVRlMmlK?=
 =?utf-8?B?Y2tucFFabUtyZ21zc2U5a3ZWUXJXbjZxTlVwd0NsbXRFOE1SNTBTbXNkdm1n?=
 =?utf-8?B?N1ZnVEEzS0twcEo0V3VKL0NLWWZNSDdQN1JUWFhIejJDQ1FaQjQ1dytNR1hM?=
 =?utf-8?B?N0hMa1ZCOXQ2YmVTU2lhMWFzRmNtTnI3a09ZZmZwQUljd05qaC9DZmVQOWtv?=
 =?utf-8?B?Q0cwSDJrWmNZRTVQajVLZG1xL2VoYXpaMFpVYjRBM1hNSENORnQ1bENsZmxS?=
 =?utf-8?B?YmNtTE9OUmNjR3BkYlYvVk1SMHliSVJ5Q01FZXUvQVdCczZmSkhVcm50cDAy?=
 =?utf-8?B?bk9lSzFMbFQyZG1uVVQvbjdOQU84Z0J5T3p3LytzUjRnc3dZcjNZTkpUVVc1?=
 =?utf-8?B?eEd1WHlPYTkrVDhDQmwxM1hhOWJEdjV3eE9HU2RkQjJBcHk4Yk1xdkJ5Q0lm?=
 =?utf-8?B?NU85ZTBjN1g1aHk2NG9DWlhxZm00TGJoa0h2Q0VuQ2I2RUZyUS8xWE1YdHVy?=
 =?utf-8?B?SXI4ZGVKL2ZNaDlaRE5sN2JlcGxhWjNycDVsU0d3UFEyTFZaMzl6blF3YlF1?=
 =?utf-8?B?a3hUaEYzemNUZExvK3pBQUF2d21xQmxrb3dNR3RibHd4cCszMmpTU2RXS2VU?=
 =?utf-8?B?NzA0anpEL1ZHYjFzNjBHWjFGb2pUUitsdGtEdmpTR0ZlaFdDT3hYRnR6czVM?=
 =?utf-8?B?bExraXpEVFhjaGJoR3JmclpsOTBCL05NK2JtZ1pIaEJEM3NmdWdGM2F2eE4z?=
 =?utf-8?B?ZnNmZ2J5a1AxdXNHQjdJNHk3c3dqMWVHa1QxQzQyckQzek5WcmYzcWx0eVVy?=
 =?utf-8?B?dGJEejJOb0lVTUJLVzBWL3ROalIyNjVjT0ZjWHdqaTE0UjFmNUgrNFQyWmFO?=
 =?utf-8?B?Uzg0YjJCOGsvUzYwdlJxajVyRHRlREtqNHBvcVozZUl2MHlQTzZ2dk1zZHp5?=
 =?utf-8?B?eUduT2VURGdUSTVXNjRvM21wV1ltakV0UWVtV2R5Y0Y3cXRRaUpRNFdZaUpo?=
 =?utf-8?B?ci9ha2VqZC9OeFFka1hncGxkc3ZnNE93OUxkNUpNeFhRNU1UWWhLR1pXWHpE?=
 =?utf-8?B?Y1VWRDhBbkg2cTBVREtNaDNjSUJ5bm5wOWV4RXBFS0RMS2RJSldNck5ZYVgw?=
 =?utf-8?B?WnBBc29kbTFuREVLS0tNR1lkU0NPLys4Y1Z3dW1oQ2tKanVYSllkWDgydklV?=
 =?utf-8?B?eGMrb2F2a3NNVk43QXhBVUhYTWpxdjMxVW1OZXVnZnhhNWhpMzFrS0lIM0hM?=
 =?utf-8?B?bjVUd2d2MUxIYlBwMW1od2lucldtTkFvd1pBdk5DWnlIVlBiWFZIYmRRcS85?=
 =?utf-8?B?cUxXamNEM1dVVHFNRW1FTldQWHM4Z1FrVzhSVWliQjdGYi9OR1dZUXRGejBF?=
 =?utf-8?B?VXo3cW1RTjRMYVJTOEtsb2t3QVNDU3J5RXdobkxzcXFsMG1jQ3N3UTFVRlJz?=
 =?utf-8?B?b0paRVlVcDZlTExQU3NnbXUzdERCR1RyZ2ttM21FdFM4QUJqNmNJaFp1ZWRr?=
 =?utf-8?B?c0c5dlpmancrU3BTWDJFSlBpQnNvYk55WHEyWFFHeDFPUmRlUFVzT2JFdFFa?=
 =?utf-8?B?VjRQeFpOamVMTG1rVGllUjBid3lLYzlMSUdyS3Urb0t5WXpLRThZcCtJc0pS?=
 =?utf-8?B?NzU3Tk5qb1hLTHByN1lZNUdubzBKMk9mWlBlZk9jUm0wVjlwVWIzQm5GYS92?=
 =?utf-8?B?WVZBYkdiS3VNK2VYZjF0d0NPOG9rYjdVN3R0aDZoY1hUMFhFYmZUekpIMnZX?=
 =?utf-8?B?b2NmVHowOXNENFkwaEgweTEvUmJvU0YzSXd3bVFGQWJHV2pyYkNzN0dld0Ju?=
 =?utf-8?B?aGR6WTlEaTJMVVhEWmQwRlRSOVFWb2lCM1UvdllmeS8wc3pLNUlwOW9CZlpp?=
 =?utf-8?B?U3hZSmVPbkZETCtLTUZsdUdIMFVNVDljY1VCbXlreS9JVWN6U0dwTFR3dDk4?=
 =?utf-8?B?aWNKMjN2MnFabDZ3SGg4WWx2NzZnN2J0S28rMFNady80a0VkMlg4Q0pkUjZO?=
 =?utf-8?B?MkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 783bac84-a6c9-4171-a357-08dc58438e08
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2024 03:17:14.9910
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BrWwj/+b2G3YWQmjWaytjAHaNrfhiNB6G0xH/itZ5/pgJIjq4+ZCyuwHzPymGYwOXHO9aECuMC3zhhFdJSLg7vzrD3d1dFUQkBlXOLKrPtw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6357
X-OriginatorOrg: intel.com

Hi James,

On 3/21/2024 9:50 AM, James Morse wrote:
> rdt_find_domain() finds a domain given a resource and a cache-id.
> It's not quite right for the resctrl arch API as it also returns the
> position to insert a new domain, which is needed when bringing a
> domain online in the arch code.
> 
> Wrap rdt_find_domain() in a another function resctrl_arch_find_domain()

"in a another" -> "in another"

> so we avoid the unnecessary argument outside the arch code.

Please do not impersonate code.

> 
> Signed-off-by: James Morse <james.morse@arm.com>
> ---

Reinette