Received-SPF: pass (google.com: domain of linux-kernel+bounces-136188-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <0ba51259-cb7a-463e-aabd-f88bd0c4007b@intel.com>
Date: Mon, 8 Apr 2024 20:18:00 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 08/31] x86/resctrl: Move resctrl types to a separate
 header
To: James Morse <james.morse@arm.com>, <x86@kernel.org>,
	<linux-kernel@vger.kernel.org>
CC: Fenghua Yu <fenghua.yu@intel.com>, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, H Peter Anvin
	<hpa@zytor.com>, Babu Moger <Babu.Moger@amd.com>,
	<shameerali.kolothum.thodi@huawei.com>, D Scott Phillips OS
	<scott@os.amperecomputing.com>, <carl@os.amperecomputing.com>,
	<lcherian@marvell.com>, <bobo.shaobowang@huawei.com>,
	<tan.shaopeng@fujitsu.com>, <baolin.wang@linux.alibaba.com>, Jamie Iles
	<quic_jiles@quicinc.com>, Xin Hao <xhao@linux.alibaba.com>,
	<peternewman@google.com>, <dfustini@baylibre.com>, <amitsinght@marvell.com>,
	David Hildenbrand <david@redhat.com>, Rex Nie <rex.nie@jaguarmicro.com>, Dave
 Martin <dave.martin@arm.com>
References: <20240321165106.31602-1-james.morse@arm.com>
 <20240321165106.31602-9-james.morse@arm.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240321165106.31602-9-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q2xZWGl2UUh1d2NNZ2JqaGJVeE1jOEhGc0x1WThESEpncWFnbFYwWmxHbERG?=
 =?utf-8?B?RmRXMVhFMlJrS1hzNExoQXpTdDMvZmx3cHMzMWpRZGVQVHZkUklTd0dPdlRI?=
 =?utf-8?B?NkxpL3FZN2l0ZVg2eDhRdzlydEhwOTJLVkdIazNaM3d4RitGblAxYUZFdGZv?=
 =?utf-8?B?Tmd6bFV3dGVaeVBRMnZkRFJRSTd5Sys4OGYzaFltY2hRLzB6RkZWM1RpWXIv?=
 =?utf-8?B?b0E0SEhDVHVhZkI3YzNDNGZia2pXbzdYV3puWDNvUk1ZTGhvMVBRNmg1dUls?=
 =?utf-8?B?ajlhVTdUV2JjMnJFVHR3SU8rZ1BmR2xBdFZnS1lXRW1VUFEwSmIrSnZpbStq?=
 =?utf-8?B?MVNjSEE2eVoxWjBUWG1yTzFicTFBSDBXWWNDb2ZrWGhoSHBWVG0rRGhESWRk?=
 =?utf-8?B?eUJaUHRORlJRdzhXTGk5ajB5OCtvR3FKQlJDMG4waGlab3d2VDREUTVUMnh5?=
 =?utf-8?B?Ums5QXpWUDdpTGFRZDRxeTMwdzZkWXlGUHE1VzBVRVE0UXRWTUhFN0RUenVl?=
 =?utf-8?B?TWtvcllKUDJiMUNQZEI5VittWVRxOGFzaG1IdGR5STRNMG1yVUNNSlRZNmZP?=
 =?utf-8?B?L0V6aUh2eHFQQlBFaVpySEJsK0xTWWdLQlJjVFc5M1pYRmg3d3NDN0hTL21Y?=
 =?utf-8?B?ZUJvdkFzeGNSZGxneGloeTZVNVNXekxCQnlqaXV3QkgvM0orM2thY0dYbHNa?=
 =?utf-8?B?U0xFYTUyODBka3piTW51T1pPOTN0OUVVckRBS2diaFBoeHVmVS9Jdkh3Zm0w?=
 =?utf-8?B?M2lYR2o0TjFjU2RONGNnK0ZQK1BmbDFtMnh2bFg1cGZpWEIzUVROZEprOHJG?=
 =?utf-8?B?MTVZU3plTENNZG5WbHJVSWRxWUNzY0sraW5UdnhmcDZuS3M5NGFoRnNXQU5x?=
 =?utf-8?B?TjMrblkwOU5QcjQ3SkhmbS9yZnlWUjF1RmdVVmpBOUdEWmowV1p6RmRGZklo?=
 =?utf-8?B?MC8yYU9BTXU0Q3JtK2VCbmhWWmt5MnJPWHVXVTBJYTNZYksxVmM0eFkzZjZB?=
 =?utf-8?B?SjJReFA4ckw0b0c0SHhja0hzOW5lUkRWRjVEZ3RZaVZ1RzNhNGt4QUVFZUdB?=
 =?utf-8?B?OEgrdjRJZVo2SDZ0RWRBeUc3WUdjU3cwczlRWTZ0OTMzS2xTcmRLRlZET09B?=
 =?utf-8?B?ZjFWdFZxaU1zVkNKMXZ5ZGRDMGVKVEM5dVJjQktaVFRrVGk2dTM1U3JJYkwx?=
 =?utf-8?B?cTlROEltN2UwcW9leHNIUVEwajQrUEJpUWI4RkNLYmlPTmF4c1VDOFM4NkJs?=
 =?utf-8?B?cllHdE9jaWF3TU1vSGFyU1M0cmtBY3RGQk1zSmpQWmNlTmdjcFREVmI3cGJ3?=
 =?utf-8?B?ZGlNTlZoVFU1eG1tWVB4N2Y4dVNUMCtyRGNGUTgxVVZGdm1RT3hPYzNsRDc0?=
 =?utf-8?B?ZGxDNWVmVHVVNXNMdWYvbDVOQVZRL2g0NTd1ZmwzUUxJN1pteWdjK090cGI0?=
 =?utf-8?B?dGovc05mY0MzQ0YzdzBKYXJCUU5qd0NaWVg2UlVPQWxYTDdYektqeGRkbWVT?=
 =?utf-8?B?SU5LMTZzWFNzYjA5MzB2RFgyWmlraVpCQkNRWXlLTmx2UEc0Umo1UVV0V3FN?=
 =?utf-8?B?VVoyUG9lSXd0eDVCVzE5ZU8zS1c3VFEwWC9qZkswbzM3Y2FTVnZkb0UrQlpu?=
 =?utf-8?B?OE5KcWFZNnFlWGVzbHN6TXVCZjB5RkUveTUxRU9RR2QvVGxtNXB1WnlBbHph?=
 =?utf-8?B?eUN3SnFDbjUyMDFteVBmcGpTajlubk9JUVFLQ045TFVuY1pxY2ZnaGk2c293?=
 =?utf-8?B?SWtZRDQ1eU9oc3lFa0duN0xZNm5KbGF1SG0rbjN3N1g4YXlNNmNraktnaFdw?=
 =?utf-8?B?VHpSWUdGMTQzWEZKVFNlWGxYd0I5bGxFVVNFbkZqSUNkMXlqaG9ZSzJEZDU2?=
 =?utf-8?B?d2xicnhxL1ZEeU5WM05hcm45Y2xPRFczYVZxWDZDQUF6cU45U3FmdVE4VW9B?=
 =?utf-8?B?TkZyR1pTeXpxcjJlTXhxaDBVOTZWNFFWRThwL0pmWHVqNVptV1FkeWxqeWQ2?=
 =?utf-8?B?Tlljc1laekJEWFJVYW9PalNVZllKcFFJWk9NTW9taVUzSThEanFvM1M4Q0NH?=
 =?utf-8?B?ZnR6THFzVGxjR0JsRDM0NXFMeG9UenZHbXFzdi9FK0pQa1I4ZnhMc05PUmJE?=
 =?utf-8?B?c2Uwb3FXRDQ0N2dUdWVXWHpJTjl0TXBaYWF2d085RFUyV3NDRXhpaEsyM2hH?=
 =?utf-8?B?WGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0505c2f2-46b4-4d88-b1b6-08dc5843aa6a
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2024 03:18:02.6116
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xMMEJu+nkjb7R871rcTEly4sc48ZGSzXxTwwpLOOaaEoawhd0HI7HmNV4hcsruSJUoQyG4PI4vIgDegrZJuosy5CGdAwwaWH/apNaLjVvGc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6357
X-OriginatorOrg: intel.com

Hi James,

On 3/21/2024 9:50 AM, James Morse wrote:
> To avoid sticky problems in the mpam glue code, move the resctrl
> enums into a separate header.

Could you please elaborate so that "sticky problems in the mpam glue code" is
specific about what problems are avoided?

> 
> This lets the arch code declare prototypes that use these enums without
> creating a loop via asm<->linux resctrl.h The same logic applies to the
> monitor-configuration defines, move these too.
> 
> The maintainers entry for these headers was missed when resctrl.h
> was created. Add a wildcard entry to match both resctrl.h and
> resctrl_types.h.
> 
> Signed-off-by: James Morse <james.morse@arm.com>

..

> diff --git a/include/linux/resctrl_types.h b/include/linux/resctrl_types.h
> new file mode 100644
> index 000000000000..4788bd95dac6
> --- /dev/null
> +++ b/include/linux/resctrl_types.h
> @@ -0,0 +1,68 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (C) 2024 Arm Ltd.
> + * Based on arch/x86/kernel/cpu/resctrl/internal.h
> + */

Could this header please explain how this file is intended to be used?
What is it intended to contain?

Reinette