Received-SPF: pass (google.com: domain of linux-kernel+bounces-136189-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <601034c9-e9cf-4ca3-834e-58479a58523e@intel.com>
Date: Mon, 8 Apr 2024 20:18:40 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 10/31] x86/resctrl: Move monitor init work to a resctrl
 init call
To: James Morse <james.morse@arm.com>, <x86@kernel.org>,
	<linux-kernel@vger.kernel.org>
CC: Fenghua Yu <fenghua.yu@intel.com>, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, H Peter Anvin
	<hpa@zytor.com>, Babu Moger <Babu.Moger@amd.com>,
	<shameerali.kolothum.thodi@huawei.com>, D Scott Phillips OS
	<scott@os.amperecomputing.com>, <carl@os.amperecomputing.com>,
	<lcherian@marvell.com>, <bobo.shaobowang@huawei.com>,
	<tan.shaopeng@fujitsu.com>, <baolin.wang@linux.alibaba.com>, Jamie Iles
	<quic_jiles@quicinc.com>, Xin Hao <xhao@linux.alibaba.com>,
	<peternewman@google.com>, <dfustini@baylibre.com>, <amitsinght@marvell.com>,
	David Hildenbrand <david@redhat.com>, Rex Nie <rex.nie@jaguarmicro.com>, Dave
 Martin <dave.martin@arm.com>
References: <20240321165106.31602-1-james.morse@arm.com>
 <20240321165106.31602-11-james.morse@arm.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240321165106.31602-11-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dG1XRHRSdUZ3TUhuZmNLY3RySmRHb1UzczVWb0QyaGlUL3U1YWN3V01wN2lL?=
 =?utf-8?B?L3hocDRka2xmQTZJUXFNWFB3ZnhLYm80WFhEZTcxTDY4MkdUdjhrWE9BNDVT?=
 =?utf-8?B?NFJEMjVQbU5aT2VINDRQQXVYbnRLVUpaL3Z2QWVFUVZWUVBNNkRCN205eERX?=
 =?utf-8?B?b1hzZjVxZFI0NVczbnkzeEZTMjJ6UGFyUDRNd0NqUkFzd1VBeXFLRkRBY0RD?=
 =?utf-8?B?OHp2NHhjZkRWdTUxektRdUJuYWM5clhtZ1htOXdCRGdHM1BBUHo4WW1YSFNY?=
 =?utf-8?B?Uld0TUIzSTNEWW1hTGZEZFIrMkxXNUdYVXh1a052L0JtQVNFR09JZnJIV0lR?=
 =?utf-8?B?Ynp5UytQOW5aVmhPUElnSXJ2enE0eWdyQUxJcXh5UXpMY3RYdmVtNk96WjlF?=
 =?utf-8?B?VlFUbTFBNUJYUjJlYU9CZ21Db1pSUDFLQlhXcGU0N3pLM2VxMFhhdE9lL3o5?=
 =?utf-8?B?aWVSRWdDTmtkMDExKzhtWHhyL0hmWmNEcDN4ZVkxdmtaQmxQK25FTU5YaE9y?=
 =?utf-8?B?ZXJabVRPN2hITHB2TG5CbjU5T1g1N1dNcnlma3RiNmhvNXVpMFkvTW53QmRU?=
 =?utf-8?B?YzZiRDZEMVFrMm9rRU5OU0kwUlh5cDlLTGlwQ3Naa2xGM25WUHc5NGs4N1FH?=
 =?utf-8?B?eUNFTjBjcy85VzhqRXkxTmd1OW8zNkRmR1phNGNlMzRSdllFM1NOWnV3WXlF?=
 =?utf-8?B?UUxIeHd1RUthQ05ZR0VGNlR5cWIvSTlBRXhESmFaSFJOYnhvdHlobitIdEZJ?=
 =?utf-8?B?UXN5Rk5Mci9oS1Q3OVdnbmd0d1NwcHRrdzc0UnhtMEJMUzcxS2hUQ2tMZVhL?=
 =?utf-8?B?RUxxYWd4YmxUZjdOL2E4S0lObnNtdVJxdmNxUy9OQkN1ckNENk1CMlowQ0du?=
 =?utf-8?B?TmxHYXc0QzZUakJTOW1OTkZrajNrMmcvQ3preXV0MHgwQ0xRSzRmdEVUYlhS?=
 =?utf-8?B?d1Q2ODdBMDJXZGowWUljYmtrREVpM1lCb0xPVS9sdDRzNE8xL2hNc3lYTTY3?=
 =?utf-8?B?OG9oTGFia0Npa29pSU14bXRTQ0M1ZDFWQnZDY1JmSnVOT0orS1Z0WWJhYk1i?=
 =?utf-8?B?UnBKZXVUdjRhS043aXRNN2pnOC9RUGxCVjRCYlRTNUU3SHZROGxlVTFQcUxX?=
 =?utf-8?B?UXhGUWRNUnc0ZjR3dUY1UzUrRXFJSUk5bk1QcUZjNkRnUU93MFF5SGxXbG5l?=
 =?utf-8?B?ejc3dUZDaWxWSEoxZjB2MElOY0V4NmNhZG1Ib0JhcUNkWklnY09mN1dSNWdy?=
 =?utf-8?B?MUZoL3pldWMwMVUzMlpJOFFDUGdpY083VTkyRWRmN1NpNHRwbTlRV2g3TmFE?=
 =?utf-8?B?aDljSWZvUk81THhlZEdJN1VCRFZUYmo0dDhKMkZLRDFPa25MMVRvT2wwTjRq?=
 =?utf-8?B?dS9WWWFZdVdhNUd5aTVnL2VTR3pSL21keTlMemg2ZjNTd2w2dzIzUnpaa2dk?=
 =?utf-8?B?cER1Y2w2Nk5YRnZQMGk2Z0ZRQVUzc3VkM1BWU0kxN1lGUVM0bjZtQTY4Q0xX?=
 =?utf-8?B?anJVdlVKbmltYzlMWEdrZ1hGWnlQdEVKa3hGU0x1bC9xendEcU9ySlZwRkJq?=
 =?utf-8?B?c1V3bGRFT3hjNnM1M1hCZzB3cm82eTRCMVR5Ny9TbEUvcEowTWJqbElPeTFs?=
 =?utf-8?B?RUFiNjlDYjNDZmtkMzZONEVSZnRsTUQvVkk2a24xREpmdHA4YWNyVFl3TkZO?=
 =?utf-8?B?VlRMWURjand3NE4wdytMQmx5NE1ENksvMCt5WlRxajJSeEFyOXU4WmJWanNn?=
 =?utf-8?B?STM1V0xBOHZZS0hSVnd5SEQ4UWZrTVlLbmtHTFZzSDc3T2tOdjloSTVaR3Q1?=
 =?utf-8?B?cFlqZlJZdFlNQzdwaVpUYUMxVFJvcWEvZW4waE5jeFZTQlNiSTB0dWFwR0gz?=
 =?utf-8?B?ZVNrOEp4a2JOSGFIV0xpbmQ5QUF3NEJiaEppanlRdzV3WjlWWHZsaXFSL0JI?=
 =?utf-8?B?NGFlZGNpandwTUpBMnE0ZkxsRmo1OHQzTnpyOGI2NWEwbTlqYlZhQkZxaDRB?=
 =?utf-8?B?VW5JWnpkZ1N0TEM0eTIrTFNQMFhWaGlZTWhpVGhtS3Bjd2dRdTdDNEhzZFNp?=
 =?utf-8?B?a2plL3BpcnhGWlFvSHpXaUIyeWFxSlVYZjdrRHp6VzhaWGs0TjVjdm9VWlYw?=
 =?utf-8?B?Y1ZRaTBPanRtRHgwS1dyYU1oYXFIazBCdGo1TnpQNjNZSmtQR2dCUWtUYjFP?=
 =?utf-8?B?R0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 01d4bd94-2a81-47c6-ac9b-08dc5843c248
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2024 03:18:42.6479
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: B88Dmfw8Z0BI0WVGbanPxRRP9oqt8yGdbDZSxmu02i21pZgnFDIeLByVY6akJtXN2rIG+bB0HUeOZWKu9tU/ZDMdpXL4/+3DtADIkbzZ6X0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6357
X-OriginatorOrg: intel.com

Hi James,

On 3/21/2024 9:50 AM, James Morse wrote:

..

> diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> index 13c24cb18d76..7a9696f53f2b 100644
> --- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> +++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> @@ -4138,6 +4138,10 @@ int __init resctrl_init(void)
>  
>  	rdtgroup_setup_default();
>  
> +	ret = resctrl_mon_resource_init();
> +	if (ret)
> +		return ret;
> +
>  	ret = sysfs_create_mount_point(fs_kobj, "resctrl");
>  	if (ret)
>  		return ret;

Should the mon data be cleaned up if sysfs_create_mount_point() fails?

Reinette