Received-SPF: pass (google.com: domain of linux-kernel+bounces-136191-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <fc4ee516-54b7-47cb-b881-00ce10d311a9@intel.com>
Date: Mon, 8 Apr 2024 20:19:15 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 12/31] x86/resctrl: Move max_{name,data}_width into
 resctrl code
To: James Morse <james.morse@arm.com>, <x86@kernel.org>,
	<linux-kernel@vger.kernel.org>
CC: Fenghua Yu <fenghua.yu@intel.com>, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, H Peter Anvin
	<hpa@zytor.com>, Babu Moger <Babu.Moger@amd.com>,
	<shameerali.kolothum.thodi@huawei.com>, D Scott Phillips OS
	<scott@os.amperecomputing.com>, <carl@os.amperecomputing.com>,
	<lcherian@marvell.com>, <bobo.shaobowang@huawei.com>,
	<tan.shaopeng@fujitsu.com>, <baolin.wang@linux.alibaba.com>, Jamie Iles
	<quic_jiles@quicinc.com>, Xin Hao <xhao@linux.alibaba.com>,
	<peternewman@google.com>, <dfustini@baylibre.com>, <amitsinght@marvell.com>,
	David Hildenbrand <david@redhat.com>, Rex Nie <rex.nie@jaguarmicro.com>, Dave
 Martin <dave.martin@arm.com>
References: <20240321165106.31602-1-james.morse@arm.com>
 <20240321165106.31602-13-james.morse@arm.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240321165106.31602-13-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cFdnenN0MXc3a2VRYm5tcnM5VEQ2aTFiZ1h5UjU4a0FrZzZ0YXV6YWFCQmMx?=
 =?utf-8?B?ZlFVdzRhaGloOEZMYVkyUG1ib0JBUGdUVHN1ZWcvVlJlbVJJcDI3SlFXQnIw?=
 =?utf-8?B?anpJMGdZR2RvcC9mQzNNbkxSaEFVZEVlekZUb2Z2RmlKc0NUb2o1RmpZRjVN?=
 =?utf-8?B?V1F6THdRQTF4aEV5T1QydE1zekxjZDRIQWpIR2swc1UxZ2JlRHozVXh5aVh0?=
 =?utf-8?B?VFFRZlkvMHlyVGJaTGRoTy9XN21QQzY2NEJ0cG1EUXJYV3lGeVFmVzBWdjRs?=
 =?utf-8?B?ejkwQ3Jod3h3WWJ5ZVJkSkxZWlVEVDA4Z1BRa1JZWWpxRng2WlduYnlrRkNh?=
 =?utf-8?B?NnNLWVVoQ1ZNMGxnUUR0RTdwNHl6U0dFaE9DYjM4SlVtbHU1VUpXSk05dnhX?=
 =?utf-8?B?N1ZzbjhwZEFSMzAxZHQ0WGlweHZyazhPY3NiWTlTUE9SRlN2eFVZdjFTT3Zv?=
 =?utf-8?B?MFRsQ2VSZWJ3cVpqcFNPSlkra2wwVnQ4S25aR0dheDc1LzVXZERjczM5WHBo?=
 =?utf-8?B?OXJ4SkNSQ25EMEFMckhHOUkyZ1NvVGEzRnR1NUdkZXY1elhQb2p0S0E4Y0RC?=
 =?utf-8?B?V2M4bGRkbEZEYXRjWSt3aFhkQ1dlUEM5b2QvbEtGTVJnUlRpNUx1UlFsSXcw?=
 =?utf-8?B?N0FxcTFpaEkvYkR0dlZzOHREL0FSbGh6dFlXb1lUMUVUOHA5K1ZDTElwR0lz?=
 =?utf-8?B?dkNjMHFxTXNobUNyTW9RQkYwL2tOUGttYTN1Ui9NZUdsR3kvZ3hNVUdPRWQv?=
 =?utf-8?B?Q3JxUWFhUXd1ZzhGOVZ5QTJobDFzcEx6ZGFYYVhHSHFtbFJYUU05K3NQYmFC?=
 =?utf-8?B?ZGNzelk4YXFxa2k3TWhLQWlBZ0dQU0l6QWdROEJwdjRmVUtydGV5ZFBxa2Zr?=
 =?utf-8?B?dkYwUnkzMng0UnVwN0lFQjEyT1V3OXdiNUN3OElJRXNjellkc1FOc3BHalla?=
 =?utf-8?B?Z1ZvSThTWW9IQUdqeWRRSjd0M3BQbENXOFBFSE5zZlBvaFZJMXZBNGJJa3Q4?=
 =?utf-8?B?Z1hCbVNwVjZJVTVSQVpwOHdac2lEdFFFcllRdS9WaWg5ZmQ0RnpaMk5DT0cw?=
 =?utf-8?B?T1Z2SG0wSitQYXB3K04xNGtNcTZ5T1BxTHR0WmxNTDcwalBOajh6c0REZXZv?=
 =?utf-8?B?b0tZSUl0Y21wWFhLZEJGV2gwazZUU3NCOUZ3ZjhnbERGaUNuWjJjbTZiTXJK?=
 =?utf-8?B?czFtNFRjSzR2QjlWRWlSdU5uOXVSZTliTmQ3NEovaTh5SkdDZUxreXBHa0E2?=
 =?utf-8?B?UXc0REl3cUxYSnZjbVlIZ3M0NCs5SUduaVpweUxoRzh6ZCtXRXlOSWoyR25z?=
 =?utf-8?B?cWtpNUhZVEVRekNtZ29jSXJHOGQ2c20vQ1RxTGZ6dHQ5OW84L1ZIb2pHSUpX?=
 =?utf-8?B?NzhGaUJmNmMyQUhxbkRuRisvU0FxemE4R0NJUzFCeWQycjV6N24zSytEOGJ4?=
 =?utf-8?B?aHlHWHB0Y2dISTNoamxRSkFqbm5UNS9yQU13NHdrVk5vNjA5eEZibG91ZHNi?=
 =?utf-8?B?eEo3dVNTVEdFVDk4RVNkOWlPY3M3cUFiY1M3MTFLdSt0MU4zeE1DQ1ZSQ3hS?=
 =?utf-8?B?cEhCQ1AzZU55dVdacmJhTlVvbmRyeGw0bzhYWG85UlhLcGNvMGhSeGVpcXAr?=
 =?utf-8?B?c1Rra1AyUEcvZVJQVnYyLzVZUXhNdVNObTVaa0NFNWFWOUk5MElBWldzSTJB?=
 =?utf-8?B?UkdpV1NXY0oyYTRWSFNRWlpOOWhpNk5uMm14dXpFSzFaejBjTkpjZ1BoYjlJ?=
 =?utf-8?B?OEpHQkNYUDNDQUgvUVVSek8vNU84a25JaWhBOXVmUWdrSWRmb2ltSFZkT2RN?=
 =?utf-8?B?ZTBxSFZ2R0NpdXJITVYvSG5JbkZRU3YwRnRLbWxVeWN1VUV0R090Q2tnNnJ3?=
 =?utf-8?B?U3JMZGdxak5ZRlJoN0FNOXZGNHhENG5XR2IzN3lucGRkdU91Vm5FbkhGY0JX?=
 =?utf-8?B?V2VmK3cyaGYzMjF1T2NyeEE1NDhEdDdMQWRLSERMUGVhNWwvSXU5RWhYS3NG?=
 =?utf-8?B?cWJhUWd6RDN6MENBWERvdXduMGV1UTVUa0I2WFA5SXRveElzS3lIbkUySHk4?=
 =?utf-8?B?NzBwc1g2MEdZYjVQYnNCVTBBcUpWYkxTT0IzOFcvcisyWVF1K3FJT1M1UTM4?=
 =?utf-8?B?UHlWbUZQUFk2YlplVnNabjhISEZiQ3NPd1ZDMldhbzAwS0dwN2NEZmpnTXBD?=
 =?utf-8?B?Zmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8e08659e-adc8-48b9-637a-08dc5843d728
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2024 03:19:17.6554
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: G+AKMnTeo73P1L4tEbCTAV6BL6O9l/Yqjg/9SxULs3R7Fp4leJsTaJy+94YhVlieFd8ZexNLeElprJ57zs4ICJp/p7Fs3VRydTOHV6YCl/A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6357
X-OriginatorOrg: intel.com

Hi James,

On 3/21/2024 9:50 AM, James Morse wrote:
> @@ -2595,6 +2601,12 @@ static int schemata_list_add(struct rdt_resource *r, enum resctrl_conf_type type
>  	if (cl > max_name_width)
>  		max_name_width = cl;
>  
> +	/*
> +	 * Choose a width for the resource data based on the resource that has
> +	 * widest name and cbm.

Please check series to ensure upper case is used for acronyms.

> +	 */
> +	max_data_width = max(max_data_width, r->data_width);
> +
>  	INIT_LIST_HEAD(&s->list);
>  	list_add(&s->list, &resctrl_schema_all);
>  

Reinette