Received-SPF: pass (google.com: domain of linux-kernel+bounces-136194-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <67021f34-65fd-4ea8-b696-b5d797ae9dbc@intel.com>
Date: Mon, 8 Apr 2024 20:20:12 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 14/31] x86/resctrl: Export the is_mbm_*_enabled()
 helpers to asm/resctrl.h
To: James Morse <james.morse@arm.com>, <x86@kernel.org>,
	<linux-kernel@vger.kernel.org>
CC: Fenghua Yu <fenghua.yu@intel.com>, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, H Peter Anvin
	<hpa@zytor.com>, Babu Moger <Babu.Moger@amd.com>,
	<shameerali.kolothum.thodi@huawei.com>, D Scott Phillips OS
	<scott@os.amperecomputing.com>, <carl@os.amperecomputing.com>,
	<lcherian@marvell.com>, <bobo.shaobowang@huawei.com>,
	<tan.shaopeng@fujitsu.com>, <baolin.wang@linux.alibaba.com>, Jamie Iles
	<quic_jiles@quicinc.com>, Xin Hao <xhao@linux.alibaba.com>,
	<peternewman@google.com>, <dfustini@baylibre.com>, <amitsinght@marvell.com>,
	David Hildenbrand <david@redhat.com>, Rex Nie <rex.nie@jaguarmicro.com>, Dave
 Martin <dave.martin@arm.com>
References: <20240321165106.31602-1-james.morse@arm.com>
 <20240321165106.31602-15-james.morse@arm.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240321165106.31602-15-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QXc1VmpKVTkxaTFMN1NVd29qVnVUYnNiNWdDMUlZNnJMWU5icHZ2azlYeW9w?=
 =?utf-8?B?VzhiRll4dlRyamkrcjF6YVFUQWVGQVM0SzgvendZNlFFaVYwL25GdDUremM0?=
 =?utf-8?B?WjF5N3lxdjlzOGk2bDdkN3E4RW8yeG51UXFZR2ZjSXkzNDMway9QWThTbmo3?=
 =?utf-8?B?enR5cVI5SXVqcXczWEorRWVSdklWeHNQYkh3WUY0VlFJS1YrWW8yYWNUbzRX?=
 =?utf-8?B?clpLcmtodVN3aW1nZHBxSnBDRUJEMFJrZ0c0ZjRMMFRJaFVrdkNaSFUzMVp4?=
 =?utf-8?B?NEtpYnc0cU5aK0Y5ZVBocGRjMFBjaUc1WVU1eTF0Q2tmWndCZ1lhRnFPZ2FP?=
 =?utf-8?B?cHc2andDdmcrRmh5WmpkNDZMVTMzMmZnTERKQTRHQjJmVFdkeWYwUzBCNEFK?=
 =?utf-8?B?OFBKV3B4THl4YmxHU2FPZUg0ZkxaNWhsWG1OZk5ldlh0RzQ1dkc1OUNSS1NC?=
 =?utf-8?B?MVNZSU00OGRMM2gxeU1LekFtK2xTVWdsRkFacXpXNjMrZGJtYy9WcE5NOUxN?=
 =?utf-8?B?SVFmL0g1ZXg1S3hBYXBpeldGOUc3OXh0VDVrQlpqREFZRlp2SXk2UklqR0Ix?=
 =?utf-8?B?SWxxbksyZ2hlejRmeUJCb3I2czFTZVlXYVBiajIrWTBEZ2NsV1JYYkYrYXFF?=
 =?utf-8?B?ZGcrTGpKWUlQTExCSXFUODNIK0hOZ0NtL3ZjKzRuRERZVGlJM09SQjdwNTg3?=
 =?utf-8?B?VXdhZkcxcVBTSHFkSTR4WHhyWnlibDlxTDZLcUtVMFM3dlJTeFd1N1JGTi9m?=
 =?utf-8?B?NzZaWGtGMExrdjVPQXNCWnlBRmNoczhJSUtCemdpZWNUQUZFZjU1RGRGaXcr?=
 =?utf-8?B?Y3BuSkZyVUR6UGRyelIzUTBWMDh3T1E3WmlCaXJJczdGYUhvUUt2Wnh1N2Ft?=
 =?utf-8?B?aEduQjMyU0Rxd0NBTGlvTFpWMHI2R0FKSmNjWTdjOUl5Y1FSRmJPWit5QzRH?=
 =?utf-8?B?MFUwcUN1djVqWGhQRHdpbDdVcy9MNlMwMXg5VzZISFh2UmNmdE80RENjYnI1?=
 =?utf-8?B?U1EwUkhva1Nhb2ZJTGFRTnVrZXFIY3l3bVhQMHJlTER2MGtCL3hnamhHT3JT?=
 =?utf-8?B?bUVZVUtVV2NEN0Fxd2s2TFRWWUljY3RJS3Z6elNtY0F0QVFENVZLd0Y1SXlC?=
 =?utf-8?B?Y1o2UkkvTncvNkwwYzduaGY2YThBcjdWUFl3bE5DTGh3NktVS3FrOG1lVnk3?=
 =?utf-8?B?LzhVMmdxam1YZFBkbHpSRWNPeU1uUktmOXBrWXZXZCtxbzFiTUZ2Z2hFNUt0?=
 =?utf-8?B?WFEydzd2QWZ0aU13WG9YSzFXVDJCeTc5cGE2dG1Eejk5RiswUHk5d1RkREYr?=
 =?utf-8?B?NzhPTHh0a3EvYnVxQzI1S3JxWjlQUElUK2lKZ3FWcmVuVjVZbXJacmp6a3cz?=
 =?utf-8?B?V3FTbFpqWi91STBXU2hZRjVoREI0UWtwckV0UlZiZ21HSWo1T3N0Y1lSMUNB?=
 =?utf-8?B?N1ZWcnBEM1dXRFFWdWV6RERyUTZRSlBKY1hxNmdQbnkrM2gyMEpWQTBudyts?=
 =?utf-8?B?b3lnbXlVR2FPSUtGazAvR3F2YU4vYmUxMVNIUi9CYzdyQnlObHBjemdRZ3FX?=
 =?utf-8?B?aE1xQmtsVEpsbWthQk1vMkdrR1dYMThrclV1WSs2NkZibzk2MEc5dGFCMkth?=
 =?utf-8?B?T3c4SytkTlgrYW4xa1dUNEVqakZyMDFvQmJaMEU0N240S2ZLd2FkenlzK0lm?=
 =?utf-8?B?QlBFeG5MYXdMUW1PdHZYUThxYm55RmxKWlZaQ0NjZ011OTlaUWRDZ2lPQjZv?=
 =?utf-8?B?MStoNlFWZVBrT2JoTFdQeW5hODNHNE9WMVJkOERZMVNoZThnUWxkSDlKcy82?=
 =?utf-8?B?ZSt3cmtkTmN1SStBZDRkVFBKajhiREM3eUJxMTRmcjFoSzF0R1dWakhaV05P?=
 =?utf-8?B?K2pFemhVemVqMWtNaHdRWHJkNkV4cmhiQ05yWEw3Zm1Sc1hlMVdJWDhpbFJw?=
 =?utf-8?B?VjJTZ0pObHYvREVlcXFzYjl4b2t5azBYWXRPbi95V2JaMzZqUEFEdy84OVhT?=
 =?utf-8?B?R3h2UVBhV01hVUlTdUNBczZhTHREVEFveXJUSVFHQ1JDSDVoUFFKSTBoa1JM?=
 =?utf-8?B?eXlFeER5Znl0eWkrOXc0dVlYOTBlVXBMQXVUQkszRzNvZmRXbjNpMUNUZ092?=
 =?utf-8?B?S2hvdkRpczh6K3pTckt0TDdvakVOa3ZHTXhXR09pYmFCR2hPTlp6Z0NaNVh2?=
 =?utf-8?B?NFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8dea626e-cb28-4c99-5500-08dc5843fbb0
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2024 03:20:18.9582
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 734OTz6RJmktMV9eitkpqSBY+S1EFlNPxTL+vZZR/CW9HQjadjXHTx2my+grM28JDt3N2cgChu2i0HUXLqTt8VDwPPXDXz6P8Dfhe9Oul7w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6357
X-OriginatorOrg: intel.com

Hi James,

On 3/21/2024 9:50 AM, James Morse wrote:
> The architecture specific parts of resctrl have helpers to hide accesses
> to the rdt_mon_features bitmap.
> 
> Once the filesystem parts of resctrl are moved, these can no longer live
> in internal.h. Once these are exposed to the wider kernel, they should
> have a 'resctrl_arch_' prefix, to fit the rest of the arch<->fs interface.
> 
> Move and rename the helpers that touch rdt_mon_features directly.
> is_mbm_event() and is_mbm_enabled() are only called from rdtgroup.c,
> so can be moved into that file.
> 
> Signed-off-by: James Morse <james.morse@arm.com>
> ---
>  arch/x86/include/asm/resctrl.h         | 17 +++++++++++
>  arch/x86/kernel/cpu/resctrl/core.c     |  4 +--
>  arch/x86/kernel/cpu/resctrl/internal.h | 27 -----------------
>  arch/x86/kernel/cpu/resctrl/monitor.c  | 18 ++++++------
>  arch/x86/kernel/cpu/resctrl/rdtgroup.c | 40 +++++++++++++++++---------
>  5 files changed, 54 insertions(+), 52 deletions(-)
> 
> diff --git a/arch/x86/include/asm/resctrl.h b/arch/x86/include/asm/resctrl.h
> index 5f6a5375bb4a..50407e83d0ca 100644
> --- a/arch/x86/include/asm/resctrl.h
> +++ b/arch/x86/include/asm/resctrl.h
> @@ -7,6 +7,7 @@
>  #include <linux/jump_label.h>
>  #include <linux/percpu.h>
>  #include <linux/sched.h>
> +#include <linux/resctrl_types.h>
>  

Can this be alphabetical?

Reinette