Received-SPF: pass (google.com: domain of linux-kernel+bounces-136200-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <6589ae7b-95bb-4490-83ac-95904da7649f@intel.com>
Date: Mon, 8 Apr 2024 20:24:35 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 22/31] x86/resctrl: Make resctrl_arch_pseudo_lock_fn()
 take a plr
To: James Morse <james.morse@arm.com>, <x86@kernel.org>,
	<linux-kernel@vger.kernel.org>
CC: Fenghua Yu <fenghua.yu@intel.com>, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, H Peter Anvin
	<hpa@zytor.com>, Babu Moger <Babu.Moger@amd.com>,
	<shameerali.kolothum.thodi@huawei.com>, D Scott Phillips OS
	<scott@os.amperecomputing.com>, <carl@os.amperecomputing.com>,
	<lcherian@marvell.com>, <bobo.shaobowang@huawei.com>,
	<tan.shaopeng@fujitsu.com>, <baolin.wang@linux.alibaba.com>, Jamie Iles
	<quic_jiles@quicinc.com>, Xin Hao <xhao@linux.alibaba.com>,
	<peternewman@google.com>, <dfustini@baylibre.com>, <amitsinght@marvell.com>,
	David Hildenbrand <david@redhat.com>, Rex Nie <rex.nie@jaguarmicro.com>,
	"Dave Martin" <dave.martin@arm.com>
References: <20240321165106.31602-1-james.morse@arm.com>
 <20240321165106.31602-23-james.morse@arm.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240321165106.31602-23-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NnZwWEtqa1YrVlZEQm9lamhQYTJvcG8zbmpRZTdKWUhKZ1lOZTR4dkRJWkN2?=
 =?utf-8?B?MEJxUkc5VW45Q0FWR3RHUTY3TmNsL1hnQ1pZM0xyYkpxNjhFVmo1TDFmc3o3?=
 =?utf-8?B?WHE3MjBsNnhpdm5ua2k3VCtxbXhGWWltOHk1UU5hU0NRSWVEeTBjVEVucXgr?=
 =?utf-8?B?bllyWndKTEdtcXhMUnVtK2Z2MmpOd3ZmRmt1dGZBQmpmRFNjR1l2dWp4aGhw?=
 =?utf-8?B?bVc1UzRCL0pmd21HZWs0OTlLdUUxLzFaSlgrZUxWWHBab0JCL2JnUklIU0h5?=
 =?utf-8?B?OTRhUkNqUkVqZk4yZ0o1OE9xSGRaeXhaQ0Q0UlI2ZkkyMHF6WUgrSFIzTFBv?=
 =?utf-8?B?TTBsWUtWc1hxSXVTMlMzNzdKVUpHVFBkS2ZLODF6TE52Vm1rSWlIc3NsY3Rj?=
 =?utf-8?B?dHJtZ3RwSEZkV2d1dVN1SmxvaUppZnNXaWREMFg2YnNCV0hFeXRTSTJLZ3h0?=
 =?utf-8?B?K2xUY2hGRXhwd1MvRTU0a0xTRk81NnN1RVNLNnNmRUtjRkRUWC9tQXRINnN6?=
 =?utf-8?B?cjdGRUZZUHZtYWcyWHUwMUJLNzQ4TXRhMkhMdWNHdGFmQWprdkQ2VkFiWEtI?=
 =?utf-8?B?RnF2UFQwejZiZjI2NE5aZlFkTnFEcG5rdzFtdjdpMTkyZzBPa2lCN2VqSlNV?=
 =?utf-8?B?c2JUaWw0STlzV0c1aHdTOXhycEFpL1dYd0pjdkhmUFJod0Mrei9QcU11VWdz?=
 =?utf-8?B?Sk9DN29ESEZEZ010MFFITWYxY1dudU9zM29kUVJ6cUZIMnhtQXRJbDVRNDVh?=
 =?utf-8?B?UFVWcjJENEFIaHRHWGVFTXhQQzZDS0FkMHpKeGhoQ29mNXVONFZIRVRpVjFX?=
 =?utf-8?B?SUNxMCthd2JnOUE1M2ZndDl1TFl5SDM1RVlZd1pTdFh2RkpkV1JGL0NtNEdS?=
 =?utf-8?B?dTRLM3NlSmprdHBOUWFtNmdVaVc4SGZxSFVuMHdGOHhENXVrZ0tIaTNVTnV4?=
 =?utf-8?B?ZGE5akZSZUlxU05qSlhKUjdzeFFUYlNvdXNUTnVPUEJ4ajAyaXNlRzhKYmJw?=
 =?utf-8?B?Vm5aUHNIYzBIanpGOWNhQmx5b2ZCZVd3OVNUUktyQzV1enQvdE9kQWNQRHhx?=
 =?utf-8?B?ZERwczNaaUoxR05FVmVlbUd3a0plMi9sdmNJbC9jWWE3TFQ1dHNJNmdpTXJ2?=
 =?utf-8?B?MFFaalFlcU5SMytFYVMyRFk0RXJBbWJsWlFxY1g5M0o2cjZhMTd5c2NRcTEr?=
 =?utf-8?B?Sk4rTzE4cUVtbWMvdWo3eStiMGFhT2pFazB0ZU5BbVJmbk1aR2o3ZlZnbkV2?=
 =?utf-8?B?UzRYQnYzZXp6amxaOHA5aThaQzJyQWV2ZGx1bWphZitDaWhMOG9MVkpXSmoy?=
 =?utf-8?B?YjJnRTJWVENBY3FMUVRBYWlVOFYyZUVPUUtrNTZsdW14SHFSWmhtZUpjaEFN?=
 =?utf-8?B?cmZlRmRlSE8rWW9iY3B6TVg0a0tQbEVsejJqZDRTd0trMnNuU0ExZE1WYUx6?=
 =?utf-8?B?YmFyejlmclc3ZVJBTnhPMldhY3N1bGgyejdDdVlOR1MrMytCTmJvaUQwMHNO?=
 =?utf-8?B?TVNIa29Eb3YxcDR0ZFVNbWRpUVVRRWpnQlJ0TGIyWkNrTnVkWW12OWFLVHlT?=
 =?utf-8?B?bm5OVTBJVXp6UUg1anZUMXpWak1pYXdVd0NlSWJoTXpNZFhubE00am9yUTBD?=
 =?utf-8?B?QlBGWG5FRGVmUmkxVFNsMTM0VFovS1AwaG50cjRYSVVXZzh2My93aXNjaWNm?=
 =?utf-8?B?NHc3WWRDb01ldm9BdUhkNVpNbkk4K09tSjhZQzByVGtXZFFCa0UwSmJCcDRR?=
 =?utf-8?B?YURuVTZxb0pMeHR0dG9aVGxBckYwWERLZFgvaDZINCt5eDFhL29ZSmg3NXNV?=
 =?utf-8?B?QVNMZzJxMWNYNVF1aG82NXdDZVdJRjh5UERXMGxrcXdJV0Vnb2VwaHBRelVT?=
 =?utf-8?B?R0IyTU8rcjR5TVU4SzN2OVFpamNtV1ZkQkVPWTl4Nzd1MVNleTBMUkVVeGFr?=
 =?utf-8?B?aWdXYkhsamFZMHJvWW9pMk53RVdQbHltUXRGNHRra281YmJoajBBak5ydHNZ?=
 =?utf-8?B?MlNvWWVDZ2tvenBOZ2hybTc4TXJWaXRqbEZEejJjbERvNDhIbmZPVlczbFA0?=
 =?utf-8?B?akZOcWNXa1gzSHgxQVlQR3psM012bTI2REdLQklCZWFMcGhXTzRyUCtPVFdG?=
 =?utf-8?B?dm02ZE4xNUxvbVZ2VzhYK0FhQWYxY0gya3ZKd2N3emdHWlROOW1XMmJ4YVpF?=
 =?utf-8?B?a1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 747e715a-f5b5-49cc-ffaa-08dc5844a19b
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2024 03:24:57.3148
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6Gfp445oAzOD4fmZbU0hsOGeL0qn7UKSiLdG0seebtJ3Ldv+57iX89huq9PUKSNi5tJZISLYHaP3gG70ZlQgrnAFsc3aBW7pctBbfUDdmSM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7506
X-OriginatorOrg: intel.com

Hi James,

On 3/21/2024 9:50 AM, James Morse wrote:
> resctrl_arch_pseudo_lock_fn() has architecture specific behaviour,
> and takes a struct rdtgroup as an argument.
> 
> After the filesystem code moves to /fs/, the definition of struct
> rdtgroup will not be available to the architecture code.
> 
> The only reason resctrl_arch_pseudo_lock_fn() wants the rdtgroup is
> for the CLOSID. Embed that in the pseudo_lock_region as a hw_closid,

Above creates expectation that the new member will be named hw_closid,
but that is not what the code does.

> and move the definition of struct pseudo_lock_region to resctrl.h.
> 
> Signed-off-by: James Morse <james.morse@arm.com>

..

> diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h
> index 6705d7960dfd..3de5bc63ace0 100644
> --- a/include/linux/resctrl.h
> +++ b/include/linux/resctrl.h
> @@ -25,6 +25,45 @@ int proc_resctrl_show(struct seq_file *m,
>  /* max value for struct rdt_domain's mbps_val */
>  #define MBA_MAX_MBPS   U32_MAX
>  
> +/**
> + * struct pseudo_lock_region - pseudo-lock region information
> + * @s:			Resctrl schema for the resource to which this
> + *			pseudo-locked region belongs
> + * @closid:		The closid that this pseudo-locked region uses
> + * @d:			RDT domain to which this pseudo-locked region
> + *			belongs
> + * @cbm:		bitmask of the pseudo-locked region
> + * @lock_thread_wq:	waitqueue used to wait on the pseudo-locking thread
> + *			completion
> + * @thread_done:	variable used by waitqueue to test if pseudo-locking
> + *			thread completed
> + * @cpu:		core associated with the cache on which the setup code
> + *			will be run
> + * @line_size:		size of the cache lines
> + * @size:		size of pseudo-locked region in bytes
> + * @kmem:		the kernel memory associated with pseudo-locked region
> + * @minor:		minor number of character device associated with this
> + *			region
> + * @debugfs_dir:	pointer to this region's directory in the debugfs
> + *			filesystem
> + * @pm_reqs:		Power management QoS requests related to this region
> + */
> +struct pseudo_lock_region {
> +	struct resctrl_schema	*s;
> +	u32			closid;
> +	struct rdt_domain	*d;
> +	u32			cbm;
> +	wait_queue_head_t	lock_thread_wq;
> +	int			thread_done;
> +	int			cpu;
> +	unsigned int		line_size;
> +	unsigned int		size;
> +	void			*kmem;
> +	unsigned int		minor;
> +	struct dentry		*debugfs_dir;
> +	struct list_head	pm_reqs;
> +};
> +
>  /**
>   * struct resctrl_staged_config - parsed configuration to be applied
>   * @new_ctrl:		new ctrl value to be loaded


Reinette