Received-SPF: pass (google.com: domain of linux-kernel+bounces-136202-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <7acf109f-d25f-4a37-9f97-c515346583a8@intel.com>
Date: Mon, 8 Apr 2024 20:26:04 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 27/31] x86/resctrl: Rename resctrl_sched_in() to begin
 resctrl_arch_
To: James Morse <james.morse@arm.com>, <x86@kernel.org>,
	<linux-kernel@vger.kernel.org>
CC: Fenghua Yu <fenghua.yu@intel.com>, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, H Peter Anvin
	<hpa@zytor.com>, Babu Moger <Babu.Moger@amd.com>,
	<shameerali.kolothum.thodi@huawei.com>, D Scott Phillips OS
	<scott@os.amperecomputing.com>, <carl@os.amperecomputing.com>,
	<lcherian@marvell.com>, <bobo.shaobowang@huawei.com>,
	<tan.shaopeng@fujitsu.com>, <baolin.wang@linux.alibaba.com>, Jamie Iles
	<quic_jiles@quicinc.com>, Xin Hao <xhao@linux.alibaba.com>,
	<peternewman@google.com>, <dfustini@baylibre.com>, <amitsinght@marvell.com>,
	David Hildenbrand <david@redhat.com>, Rex Nie <rex.nie@jaguarmicro.com>, Dave
 Martin <dave.martin@arm.com>
References: <20240321165106.31602-1-james.morse@arm.com>
 <20240321165106.31602-28-james.morse@arm.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240321165106.31602-28-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?czEyVXA3ZzVpbDQ1c05CemtYRktiSWIrUnloVjVSWHE1N2FDMGxtYVUwcGV3?=
 =?utf-8?B?SXRHcWl3bVo4SzcxY3F4b0R5NDdSMTNJMGc0aExjaDAzRUtJMlpYOXF3M2JR?=
 =?utf-8?B?V1QrSzZwaXR4NXhaS1lmdk94bWVpc2VsSmhqN1dRaFZnZzlabEsvUEdwTlpX?=
 =?utf-8?B?Y0xRU1ZvZlRnOUYrWm13RXhOT0tCa0xzTTJ1S3FOSVVCS2Fmc2NjMjVCbzJh?=
 =?utf-8?B?VDdvRVNNVzJWM09TTjZ5K1dCMEJEQmNIMWRXYjU4SmpnSE1yMVM0MUx6MHlP?=
 =?utf-8?B?S1BQdmhjUXpjREFzVUlwejJOWHNTWWREdmMzVlRpRnp6SGpvZjRHWWpIcFBS?=
 =?utf-8?B?MDFkQVRidzZTNFVhSHpESGc3SHlHSkkrUEUrdHFvSUZtbXJtRmRnT002cm1E?=
 =?utf-8?B?YUtCSnNLVlQ1YW9UcGQ1WERJWGk3eTViVjFoeFNWQW5GeVMvVHVPaTZ3aTVS?=
 =?utf-8?B?YXVnYkNVVFBwWGdsRnV6eGpwNnQrd1ZmWWRoV2lsUzdwbzJ5dTVScWlMbzRt?=
 =?utf-8?B?L1crdDg4TzVKamd1aW4yRkNhRWRjaEdmYktiSkpQS1RHL2RSVVFpTjB2cmVF?=
 =?utf-8?B?bmRxZEJVUCt5dmRmYUZnZnFhaVVTd3BsQ1NpVVAyREU3a1VBZVo0TytlblNp?=
 =?utf-8?B?STdZVGVYWUdmTGNkVCthNWxDK2ZadzZmVGJGdk5FNnVacFpLbHN3aXZMWmNm?=
 =?utf-8?B?TWdjSXdiaWIwNHJJdXZMZkF4VjZrekRPeFNTUE1lT2pUL3dxWDhGaXYwYi9a?=
 =?utf-8?B?djlqWmFXbTRtVW5FRWFvK3dsSC90OFYvWXhwTFFnbHF3VzJiRVJWSGJibEg5?=
 =?utf-8?B?dlpGSlRsUlRZdlRBaUdNSmE1L1ZNelFQTExRRmV6TkNnVmJYOUducEprb1FQ?=
 =?utf-8?B?eTlFbTBzd1ppVHBCL2FnS1FqTkI2K3REVXMvQXpFNTQvRi9NanF5Wkl4ekY1?=
 =?utf-8?B?SXZFdWlKb1RKSnk3RDJ3WjFuR2tyN0djSjRsTDRualRlTXB5bFhsS0NMVlhX?=
 =?utf-8?B?ZnhTUzAvaEFEUjFGWDQwRjAreTNWZ1JkZDJWa0JzUHdjQ2RvUlQ2b0pTMnM2?=
 =?utf-8?B?YTBqT2g3cG1lTmdXd3E2ejg2eE5DYS9ScmNZbDd3UUo4c1lFVG9MdDJlc01B?=
 =?utf-8?B?TEZzRU0yZDhYTjUrSXVWWGVHL1hXQkMxQ3RnSnhNbkY4OGxwTFJwa2xDTklD?=
 =?utf-8?B?L3BPYjdJTjlZeXhkbHZWYXFick5DVTU2cWZ4Y1I5bnlueWVBa21OWWx5WHFS?=
 =?utf-8?B?TUF4K3A1R0RpZGZjY08vaURKdTVFK3ZsSGdZNEhYdDNrV0RocFJLRnJOTjlP?=
 =?utf-8?B?Wkd3c2hPTE9EQXR6dnd5aTRJTkdtelVlTGl0cU0vNElnUE92SG9RN2ltSS9k?=
 =?utf-8?B?TVNrenF3cVl6bmt2RDFjVmdOU0N6bWpsZ2dVTU5FdmVpdG5QNHViSTFiMnpY?=
 =?utf-8?B?RTZZdzVZNXp4WmVpNnlIUmtnc0wxVGY0OGN2SDJzZ0EvUHBGcGp0aXZ3QkZY?=
 =?utf-8?B?VGY1VitJcFpoRStIdjE0K0xEN3g1VUhNaTJzVG03dUVMV0N1bWJaVGQ0QktJ?=
 =?utf-8?B?NGxLVEhRbm50NFBnaEw3RUQzQktvT1R1VHlXbHFyTjlzby8ralJ2RVJiTURU?=
 =?utf-8?B?RDdNR1VlY3A3L21GcUVJak1sMXlmWXRiSXZQSHFCVU9ROER5VE0xeWxrOWhT?=
 =?utf-8?B?UXcya3NWbVl5WER3Q0U0R25RYXMwREszaFdRM3EyV0srWEw2NklpcC82Rk0r?=
 =?utf-8?B?Mm0vVDV5QzBWMkdxOU5JZG5SSng0aFJZOFdDcjlZK2xBbmFWbjk3cDkzUDEw?=
 =?utf-8?B?dGd1WU9OWnJHMWQwL0JmUnNuK3pyazNsMGtXbk5EMWhoREVHQVlLZ2YwNGtM?=
 =?utf-8?B?ZDg1OEJGaUc3ZHF4c0pNY3h0N205VklBeDIrWDNqNERoVGtpY0hzelcyVWg0?=
 =?utf-8?B?a2tRR2svRDN5czhBeFRBSmFacXRVeElpMVZPM0UvbVMwbXBPMlZFUW1obG5t?=
 =?utf-8?B?SU5aWFVqRDdscmVqcE41RmlqVWxVMGlHbmo1eVhHWEdIenRKbWcxNDBkUDJL?=
 =?utf-8?B?WHFEcTlVaDlrWGpNdHlVYS9HNU1FdjhVbGJLTjd3RDJVUlpJa0pXWHkyV2Ja?=
 =?utf-8?B?MXRaS3I4dnR6amowT3hoOU5JeWtPZUlTZ1o3eEMySGlSUFdYaG5hYVdGd05s?=
 =?utf-8?B?M1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f6cb2cc-39e6-4201-5aaf-08dc5844d487
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2024 03:26:22.7474
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ao1W3PnVr/TWr95vtdvhB4hIjwhCk/W81PRijNg8ynop66Giry0B21gJcJDXOh7lsiU4olWAW/bXrNburLi1hAoWiUFQc8yPRtsan8hr4kw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7506
X-OriginatorOrg: intel.com

Hi James,

In subject, did you intend to say "to begin with"?

On 3/21/2024 9:51 AM, James Morse wrote:
> resctrl_sched_in() loads the architecture specific CPU MSRs with the
> CLOSID and RMID values. This function was named before resctrl was
> split to have architecture specific code, and generic filesystem code.
> 
> This function is obviously architecture specific, but does not begin
> with 'resctrl_arch_', making it the odd one out in the functions an
> architecture needs to support to enable resctrl.
> 
> Rename it for concistency. This is purely cosmetic.

concistency -> consistency

Reinette