Received-SPF: pass (google.com: domain of linux-kernel+bounces-136195-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <8bc4cc50-ca1d-404b-9cb2-db31c89fbb13@intel.com>
Date: Mon, 8 Apr 2024 20:20:41 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 16/31] x86/resctrl: Change
 mon_event_config_{read,write}() to be arch helpers
To: James Morse <james.morse@arm.com>, <x86@kernel.org>,
	<linux-kernel@vger.kernel.org>
CC: Fenghua Yu <fenghua.yu@intel.com>, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, H Peter Anvin
	<hpa@zytor.com>, Babu Moger <Babu.Moger@amd.com>,
	<shameerali.kolothum.thodi@huawei.com>, D Scott Phillips OS
	<scott@os.amperecomputing.com>, <carl@os.amperecomputing.com>,
	<lcherian@marvell.com>, <bobo.shaobowang@huawei.com>,
	<tan.shaopeng@fujitsu.com>, <baolin.wang@linux.alibaba.com>, Jamie Iles
	<quic_jiles@quicinc.com>, Xin Hao <xhao@linux.alibaba.com>,
	<peternewman@google.com>, <dfustini@baylibre.com>, <amitsinght@marvell.com>,
	David Hildenbrand <david@redhat.com>, Rex Nie <rex.nie@jaguarmicro.com>, Dave
 Martin <dave.martin@arm.com>
References: <20240321165106.31602-1-james.morse@arm.com>
 <20240321165106.31602-17-james.morse@arm.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240321165106.31602-17-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NlJxUXFFNTRlTzhVYmtpZXVHcFlsRzZnelVBNEY2ekhEZEltRVdGdWZwekpX?=
 =?utf-8?B?aVl4MG5scDF6OEVGYy9uVFVhd0R4SXp1aW8yN0dSTC82YkJ0dGRuWFo2eTBJ?=
 =?utf-8?B?NU9PeXFBNUpDTUE2L0lMU05aUkFnM3kxKzJTOG5sQzVnOGx5SHFPbVRHa3Fo?=
 =?utf-8?B?YVN0eEx2THF4ZUxRWmJ5KzJ2KzVsNTJOSW1IanhyYm45cUhQd1VKeWpydEZO?=
 =?utf-8?B?RFRMalpweC9VYS9RWkZ6VzdmVFlGeUVPRDRwUGtyYk1KM2dSNmhPYWYzblVF?=
 =?utf-8?B?NlJ6dTRnT2R5SWttODBCVStmSWtxVzJNaWR2RERsbldpaUl4aittR2srZk80?=
 =?utf-8?B?L1dmU2NpWFNwcm5VbGZab0NrU0RUWlYzVlJaNzZtMlg0MlBNZlYvM1ZaRHF0?=
 =?utf-8?B?eDQ3RUhsQm84RVhzTk42UU1vMWltaXI2QVkrVmgxMFRmbVNqYU5maE5kdDZS?=
 =?utf-8?B?aG9LR010S1EvTkFSK3EzUk1wNGlabmZ5OEtaazZGRStiME1VRllEcGpPVTFW?=
 =?utf-8?B?UnBHMUJ6TXNjcFowSE8xbm5NNEhDYzBycmdJdzJwMG9neld5OE5qZ2tVUUFn?=
 =?utf-8?B?dC96NnU5d0MvWWhtVERLMVN2OVZCdGVWcE1YNWVPYkN1SCtiWm5HdkRJYUJi?=
 =?utf-8?B?ZW5sLzllcDg0OXBsanM0SXpCdkdHd2xhVk8rVkNpcnVOb0tJUGVmc2wrSHZ6?=
 =?utf-8?B?WFFUajZNZEdGaVRGb1M1d2pYS01KcjZNY1pVcFY3ZWdLMDJjZHMwTHhJdHhF?=
 =?utf-8?B?SU90d1F4MW1zVnZsTGFuMVBBMFJsQ051YllibUxTOGtKeUJ6OGY3aldkRGxD?=
 =?utf-8?B?bk1INHd5RWh6c1J3NzdyM1UrclI0T2t4YS80emU2dDRQK2JyaUFseU1nd1VB?=
 =?utf-8?B?RExuNFZvcGpISVBmSzR2NWVvc3RrcVF6MGp3Y0JXK0tPakQ1WmFwSnZUV1ZY?=
 =?utf-8?B?NTB3SGQ3T05xcVYvTldqWGJxbFcySHNrNFZvZ2VtaUhyZlFoSGJ6Tm5PK3g4?=
 =?utf-8?B?Z2pzMVZQZEV0eGEvaGdodmJWUG5uUkordzdScnFTTVhKQ0pXd3Yra2tHbXUw?=
 =?utf-8?B?SXFRMkVITXVQVnpkWVI0eVZpOU51ZnZjcEVJR3Y2U1NBNTlMSmRKMGZjRWtR?=
 =?utf-8?B?SlBxcnVPM1FJNll1YnZ2R0JuRnVKOTRxOGVOQzRKUmZyWXVsRXJWVitGblpi?=
 =?utf-8?B?MC9qQ2tBSFBLcWNHOXF5Zks4bDBQbmU1UXlTbXJJcU1hYTNJNTU3Yk1wWVdR?=
 =?utf-8?B?SnBNUVYzTzQ5VVhmc0tCb05XWlNKSWdqR3A5WEVhQUpOMDhNelZta1htZEpz?=
 =?utf-8?B?WThoUlBBRXA3UWZzaENQUEdLR3hjaklIc0hHOUozUDQ1dWs4bGs2NDk0eTJ5?=
 =?utf-8?B?bkoyNmV2dk5Wa3VzTHJTdWZsR2craVltd1VPem5uZ3BEMEF2Tm1QcHhpRm1Z?=
 =?utf-8?B?d2VadkQvMm84T1pHZUpjWDFzaWQ3OXpkSVBFdkM5TkQzV0dYUDVSS2hXemJa?=
 =?utf-8?B?RjUwVXRhZ3hTb2d4eThPQTdZYklNaERZZHZ6YW45anRRSUpUZUg3V2MrOW5W?=
 =?utf-8?B?dmJRbjlJT3lCcVVVVVIwVFJyajNlVHYzbE9JS1RVU0QzVVhoaWdJOFpYNmJY?=
 =?utf-8?B?NmdiRjk1UlhTVXNydk5TSmxneFU3UTBIQnFWYWl5UkJaaTNDdmJzY1M4ZEhC?=
 =?utf-8?B?SjZZYUR6QTR0WnhiRVVWWmdLMkJqamZ5THh5ZG9FRnNDTjMwQm0zbWJIZmJN?=
 =?utf-8?B?ZVovWitLeTZVVEtPbnUxbWFaNHEwMzc5RkdMQS9Qb2VDbno4OVJsNkZSNW5R?=
 =?utf-8?B?RlNTbFV2cFdWd0xwajZSbHlEQkZXNGdteElVVkw1eHRBM25rNC9tdGVCWm05?=
 =?utf-8?B?KzdZOVZzR1JZb1BkMkZDdlVzQU5GcW9ZdXc2OUhoUUxsZzV1Z0llNzR0Z3ZK?=
 =?utf-8?B?S1lGR2xSUEF3NWx3TkpMMGU1a1hzSW40d05FTjhvbWFVeTRzd2J2d091VlNn?=
 =?utf-8?B?Z1p4Mk9DRVZ5YVR6cWxSaFMrS3E1cks5MVBVVTQzTTQ1bDExbG1zYS94Q3dt?=
 =?utf-8?B?WVBHVGNySFpUUzZkbFNrOFdrYVU3amFIblpsOGZnbTIxaDZKdnp5UFhPandu?=
 =?utf-8?B?WmNueXB6ZHhwenJLWGduMXJzQ21mbEdnQkVRc0ozQW9wb1BOVGdMcnBaK2lF?=
 =?utf-8?B?a1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2555a43a-3119-4d8e-4aa3-08dc58440ca1
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2024 03:20:47.3939
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7dEwE7NSJSa+GenIzn7RN/Rr/GdXUToE0QY0a67b88WG4U/L2JM2wJTXh6eNKP415yuvQq4uxWktaXSqTb5T47XO/Ui+eSHl8BWVae3F2bg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6357
X-OriginatorOrg: intel.com

Hi James,

On 3/21/2024 9:50 AM, James Morse wrote:
> mon_event_config_{read,write}() are called via IPI and access model
> specific registers to do their work.
> 
> To support another architecture, this needs abstracting.
> 
> Rename mon_event_config_{read,write}() to have a resctrl_arch_ prefix,
> and move their struct mon_config_info parameter into the restrl_types

Looks like this change is actually moving the struct into include/linux/resctrl.h,
not resctrl_types.h.

> header. This allows another architecture to supply an implementation
> of these.
> 
> As struct mon_config_info is now exposed globally, give it a 'resctrl_'
> prefix. MPAM systems need access to the domain to do this work, add
> the resource and domain to struct resctrl_mon_config_info.
> 
> Signed-off-by: James Morse <james.morse@arm.com>

..

> diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h
> index bfc63e8219e5..975b80102fbe 100644
> --- a/include/linux/resctrl.h
> +++ b/include/linux/resctrl.h
> @@ -192,6 +192,13 @@ struct resctrl_cpu_sync {
>  	u32 rmid;
>  };
>  
> +struct resctrl_mon_config_info {
> +	struct rdt_resource *r;
> +	struct rdt_domain   *d;
> +	u32                  evtid;
> +	u32                  mon_config;
> +};
> +

Please use tabs consistently in this file.

Reinette