Received-SPF: pass (google.com: domain of linux-kernel+bounces-136196-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <966b7b32-6600-4b1f-9535-0298fedd57a7@intel.com>
Date: Mon, 8 Apr 2024 20:21:24 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 17/31] x86/resctrl: Move mbm_cfg_mask to struct
 rdt_resource
To: James Morse <james.morse@arm.com>, <x86@kernel.org>,
	<linux-kernel@vger.kernel.org>
CC: Fenghua Yu <fenghua.yu@intel.com>, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, H Peter Anvin
	<hpa@zytor.com>, Babu Moger <Babu.Moger@amd.com>,
	<shameerali.kolothum.thodi@huawei.com>, D Scott Phillips OS
	<scott@os.amperecomputing.com>, <carl@os.amperecomputing.com>,
	<lcherian@marvell.com>, <bobo.shaobowang@huawei.com>,
	<tan.shaopeng@fujitsu.com>, <baolin.wang@linux.alibaba.com>, Jamie Iles
	<quic_jiles@quicinc.com>, Xin Hao <xhao@linux.alibaba.com>,
	<peternewman@google.com>, <dfustini@baylibre.com>, <amitsinght@marvell.com>,
	David Hildenbrand <david@redhat.com>, Rex Nie <rex.nie@jaguarmicro.com>, Dave
 Martin <dave.martin@arm.com>
References: <20240321165106.31602-1-james.morse@arm.com>
 <20240321165106.31602-18-james.morse@arm.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240321165106.31602-18-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RklBc3JEcG5XNUtZWG4rQzRheGdkd2JyL0R2S29LdXRQczJicnJVcXAwTkpI?=
 =?utf-8?B?b3ZQL2Y4UHZ6K3BnRmE0amY1NmlYTVo4YTNWVjBHejJOS1JnRXZ3WmQya3Vy?=
 =?utf-8?B?ZFlwNm8xWDQ2MVZ4dnJxYVVpeUJKV3h5VER0RkVkUEFwdDJWNEtwUmt1NjRs?=
 =?utf-8?B?bFppdWU5VmNUbFZ0N0lBVmVDdmx1RTQzYkU3a2Z5TG5XOXFWbFBFZ2U3YUN4?=
 =?utf-8?B?NG9pck1YYTFKd2lWcDlid2g0S25IaHF3Vi9QTjVYYnFyNWJkRnBPMFhFRHdl?=
 =?utf-8?B?a2NITzdwMW92YklPandwZGp5RU91ampWa2RVbTRpb1pHWlJ3UlRxanZsUnlH?=
 =?utf-8?B?V283bG51cjhMc1JSbTIxeHJZRWdFRll0WTdQeFFhQUJWRWJteGd2WDlyNVQ0?=
 =?utf-8?B?M2JCeW85UnhsNUxXbjRTRmhNajJ0UDRlMG1XRUdyNi9uK1FGM1RSbTFNakNL?=
 =?utf-8?B?a2pqUlc0Z1V6cFB0a09nQXQ2MXJTd0dGc3BTeFlUbHVORGx4SENMUnNTamxn?=
 =?utf-8?B?eFJMRTUxNithN1liekJTYzRCWWJLV3U5Yms4b3pBdmFpQllZTG9OYmNzN3c3?=
 =?utf-8?B?ZTQvRGdUMTkrQnMwandIWXp1b2dscjV4VngzZDNreFhaMmx3T1dkc1M2TFdF?=
 =?utf-8?B?TFp1c0l5WG1ISG0xNjBVWE84S3FGcThYdjB4U0Vqdjl5SVBHU2NoSWlTNHRz?=
 =?utf-8?B?YmxMUXpiZ2JjRVJEUVh1YXBySVdTa0ZhZ1A4d1cyTlJMd0lBQ2NvcnBYWFI3?=
 =?utf-8?B?Yk96MGN1SEhUQU1uRk5rVXhOeHkvaDJBbXRWVFJjS0J3SlRvUU8vajRHMTRq?=
 =?utf-8?B?MUl6R1FMUDFOaEtmQXFXWkQ0dmFZTlJrRFJTR2haYk4yajFpMmZRVWFReDJ3?=
 =?utf-8?B?R29pRWpLTkdyL0UwRHZzMkliMVZUR1FUcXJZcERDOTBYQmpLZ2NQOGtBQnJ0?=
 =?utf-8?B?YmE3RjZYRENKQ3h2cDJ1bkYvZ2QzZkdIVGI5Nm93TDcvODlkQjF4b29hVzdJ?=
 =?utf-8?B?eFUybHB2TUJIak9McldoTGtzS2FhamhpKzZpSUFNeVVEVlB4V2owdlBTSFBw?=
 =?utf-8?B?V3kwZzl0VWhOeFRaaUlkS1gvYjZ0YnpTUTJxb1lXczRFdnZrclUzd0NycUNW?=
 =?utf-8?B?QmMxMjAvZ0ZGeGx6VXZ1YUgrRjNnNzFzZ2p6UDJKdXMwNW9iZW9rWkxVdUV4?=
 =?utf-8?B?NWxmUmRFUjdnaGp5aGlacEttTTMzQXcrTDFjcFFOQm0wS0YwZ3orSUMzSnlO?=
 =?utf-8?B?aWpGK3JJOXpBd1FRRkZsR055Z242VU1ONTJCVnpXZG9CWUQ3VnBYZkNvYUhL?=
 =?utf-8?B?WWk0elhXUWorVDFGeXB0aVZCVHlDNlVaMHJhdy9pZ0xCTXArckh2eTJxaDM5?=
 =?utf-8?B?SDViMk9qZ05IMDJxb0w4ekNhTkxjRlB5MkxQOUkwOXcwL2I4MTRoamprTDFk?=
 =?utf-8?B?MFgrNHdJZlJFNmd6UzRyanZGb2Jzb2UrVzd4MzZPSTc1NnZmMXR0UjRIOTI4?=
 =?utf-8?B?WGZ3WXdFVVNCaWF0amFid3pwSUFRSTErYTF0NklmM2RNZFgxQ3djQk9na3Ro?=
 =?utf-8?B?RjVjeEorRWc4dVpjU2FkMHdnRUF1WUllRWhRTThHdndtb1dFcXI3c1poMEhp?=
 =?utf-8?B?cngwTzhyU2R2TUFLVzRCRDdaVThnM2dIbmFmRXhPT2c1NmVCVE5ndlU5bkt2?=
 =?utf-8?B?d3lEZmFDRFk5cmJxYXUzcHRxa2xKbnU4NkhvNUZheEptaE8xTzR1QlJVWUVk?=
 =?utf-8?B?bGpYWU40NDNiRDVWSVJmUWlaMGJWZ1RSOUlObjhYQTh5WjJFQWxOR09FbmJ4?=
 =?utf-8?B?YUFSWU9iNVlqWEZmY2Y4SnVhNWVFMWg1OGlaOThab3FhaHZYRWdhVUdVNmNm?=
 =?utf-8?B?QkRxU0ZhUndVaVEwV1h6c3lNU00zemdScERpTUVHREF1cHdiMVFKYVNSSEU1?=
 =?utf-8?B?ZkJLUXJ6KytaM2VkUWp4VU5tSzR4UTJJaDYydHQ3WUljNDJPL3ZDeE1yVmda?=
 =?utf-8?B?dUxBY1BOOHljNzk2ZWRzOW5PbTJEWGhGNUNNSk1nalJOL1NIdDJhQzNKU0Jl?=
 =?utf-8?B?RTl5aXQvYldYT1hpQXhWZm5KalRqN3JHKzdGZUt2dzN3T0xIZjRXL3VVNlpp?=
 =?utf-8?B?Z3h5NFU0Sy9RMER2TmNOUHJOWUlDYVJPc2ozOXpkYWovbHhvYmJjU3dRblVL?=
 =?utf-8?B?ZXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 99657219-c10c-4aef-2347-08dc584426a4
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2024 03:21:31.0261
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ct6zAhA1eP+zE7D8uAA8AUamHYSOy2DRixrCs/LRNpzv7/Go7QzpRFteEv6m/W9mV/eMdY73vxcMnKf3cvK2TeSecS+c1d35irNP3f3Th3I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6357
X-OriginatorOrg: intel.com

Hi James,

On 3/21/2024 9:50 AM, James Morse wrote:
> The mbm_cfg_mask field lists the bits that user-space can set when
> configuring an event. This value is output via the last_cmd_status
> file.
> 
> Once the filesystem parts of resctrl are moved to live in /fs/, the
> struct rdt_hw_resource is inaccessible to the filesystem code. Because
> this value is output to user-space, it has to be accessible to the
> filesystem code.
> 
> Move it to struct rdt_resource.
> 
> Signed-off-by: James Morse <james.morse@arm.com>

..

> diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h
> index 975b80102fbe..8a7367d1ce45 100644
> --- a/include/linux/resctrl.h
> +++ b/include/linux/resctrl.h
> @@ -140,6 +140,8 @@ struct resctrl_membw {
>   * @format_str:		Per resource format string to show domain value
>   * @evt_list:		List of monitoring events
>   * @fflags:		flags to choose base and info files
> + * @mbm_cfg_mask:	Bandwidth sources that can be tracked when Bandwidth
> + *			Monitoring Event Configuration (BMEC) is supported.

BMEC is an AMD term. If MPAM is planning to use this member then this comment
should be made generic.

>   * @cdp_capable:	Is the CDP feature available on this resource
>   */
>  struct rdt_resource {
> @@ -157,6 +159,7 @@ struct rdt_resource {
>  	const char		*format_str;
>  	struct list_head	evt_list;
>  	unsigned long		fflags;
> +	unsigned int		mbm_cfg_mask;
>  	bool			cdp_capable;
>  };
>  

Reinette