Received-SPF: pass (google.com: domain of linux-kernel+bounces-136206-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <c27c7813-5744-4363-bb7b-f9fbe80fd549@intel.com>
Date: Mon, 8 Apr 2024 20:32:36 -0700
User-Agent: Mozilla Thunderbird
From: Reinette Chatre <reinette.chatre@intel.com>
Subject: Re: [PATCH v1 28/31] x86/resctrl: Drop __init/__exit on assorted
 symbols
To: James Morse <james.morse@arm.com>, <x86@kernel.org>,
	<linux-kernel@vger.kernel.org>
CC: Fenghua Yu <fenghua.yu@intel.com>, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, H Peter Anvin
	<hpa@zytor.com>, Babu Moger <Babu.Moger@amd.com>,
	<shameerali.kolothum.thodi@huawei.com>, D Scott Phillips OS
	<scott@os.amperecomputing.com>, <carl@os.amperecomputing.com>,
	<lcherian@marvell.com>, <bobo.shaobowang@huawei.com>,
	<tan.shaopeng@fujitsu.com>, <baolin.wang@linux.alibaba.com>, Jamie Iles
	<quic_jiles@quicinc.com>, Xin Hao <xhao@linux.alibaba.com>,
	<peternewman@google.com>, <dfustini@baylibre.com>, <amitsinght@marvell.com>,
	David Hildenbrand <david@redhat.com>, Rex Nie <rex.nie@jaguarmicro.com>, Dave
 Martin <dave.martin@arm.com>
References: <20240321165106.31602-1-james.morse@arm.com>
 <20240321165106.31602-29-james.morse@arm.com>
Content-Language: en-US
In-Reply-To: <20240321165106.31602-29-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aVVocHdyb3JkekxnZDVJU090eFBmNS8xZG0xNC9maXhHbEhBRXEwYTh2VEFT?=
 =?utf-8?B?VW1NeUo2d3JJRlFoQzBPbzhpL2k0c1N0YVFPT3Y4VGcvajZSWDRzc3ZxKzVS?=
 =?utf-8?B?WnVPdWRvVDQ0T0ZqTlR6aU96OU8rcjY2VENBVzRaTVhqNlBKUDMvMmhnSjh3?=
 =?utf-8?B?bUZGK2Q1NjhqY1oyd1V0a1ZiaFdDMFRWaU1Tckx3bWEzOWJFbjZYRklMaG9U?=
 =?utf-8?B?T0pET3ZuTUJ0N1hqak5lSEhyZE9kc1RUQ3Y3Q0hXS0VBbjdqN1FIdVBRaU1p?=
 =?utf-8?B?UFBwK0xSaFVCbUpubGhvZEdvVlpqRzhjNCtwQWhoYXZaNHczbmpFOE4vWTBH?=
 =?utf-8?B?QTdpWTJyL0JxWVJBbzVQa1cxSHQwdEVVZ2ZIbDUvY3lZWFdXTlVxbTE5REY0?=
 =?utf-8?B?cXU1YXFaREhONlgzM1N0QWs0YTNHNUFodVV4L2hma2VoaWlSbjlmTjVkMytq?=
 =?utf-8?B?OFdsQVRSUHVhUUJNSUFXSVFkY3BmYkdyajVRN1lyeldBNThNVjZMa1hWaU9S?=
 =?utf-8?B?S1pvL3lUL3hOVHlHdHNlKy85UXVHdFpxRjF3bFFDVG9vTHF6aTZSTjh6QWht?=
 =?utf-8?B?amVFcmQ4cnZqMTRvdkhVb2hNaEYzYWN5OG81cnA3TnpzMTdES1cxUG1GaVlK?=
 =?utf-8?B?Nldibk5PNVZCYmdiRjNQTEFFS3MyVTBDVU13MmdQcklIaE82YWRoeVZxVU5a?=
 =?utf-8?B?NElvRjBhQ0FJMVpRenJ1VVVLYlIzOVpQMVF5R0lCK0Z5MFBKUC84VDRPVTZu?=
 =?utf-8?B?RGlMU2lIazJLT3FyOTExczF0OW13Y0Z3b0hSUG5mZUg5V0ZVZkxQWUp0VXl3?=
 =?utf-8?B?WlVBWWwyRm1TVVVaRkVHVXVHejQ4UXBOZWxYbnVWaTF0d0IzZmduZmFKbUFV?=
 =?utf-8?B?MWd1VTk3eHc2TmYwSjZIeE5JTmwwcXgyb0pGODBTTkFZL3YrU2JQaHBtSFNS?=
 =?utf-8?B?bklKdUx3RE5KbmF5N3BId0xpciszM2ZIWHZxZldKVlhYajRFWUFFRHNidEp4?=
 =?utf-8?B?NUdLcWlTbEJwZ3hYM3FhNWI3eGR6azR0MlNVcEVqQmFWTGMwOHJ1bkJqRkx0?=
 =?utf-8?B?SnNybGc4dTZnYlZFRWYwa1JxUFArZm1vZzk5K0JNUUN3aEdYUVRVbDhQUWxR?=
 =?utf-8?B?enNBbDFIR3JkRUZPOWRKTkNmT3MwY1FJcWIwWHJRTHVGWnlZVkhuaUVYZCtp?=
 =?utf-8?B?ZTh3Z2dHS2M0bExMbmVGUDFiWVJkbjB6eXBMeCtVbzdycmZVdDdwTWtoTWtE?=
 =?utf-8?B?VUVlOUdrZzdHcjhGaE9LVnJxVE1NQU1BZ1BkTVI3N3hCemlheVA1eHoxOFJo?=
 =?utf-8?B?cm5pRmpyb3lFbCtSdUNEcXdnTWp1YW5QU1A1YlFWQmIwYVhVK1dSaTVYVVFj?=
 =?utf-8?B?NkJnTVdxd3pidldzRE56WkdsUXZid0E2YlJvNDY3SlI0M1IwUW4yVWNHV0pP?=
 =?utf-8?B?eFAwYVpZY1FFVGJZbUdZWll0Y2R1OGFJWlpNbGJFL0hlZ3EwbmMzMmlxRVA2?=
 =?utf-8?B?Rm1FVUhLOG1DY3d0UERIb2gwSFd4V1FjamNmMmI0cGluaHdzRXhHN3JpOG54?=
 =?utf-8?B?Q2RGVWIrZSszdXB2WWR1Y3VVTFhjSVFKSUR2WjlweEhDdFdEMnVhQ0E2MHhk?=
 =?utf-8?B?cUdHNzk1d0xhMjYvdmloRHVMWU9UWDBZOEhXMzFXSXNFblJVSlREb3M5YVdN?=
 =?utf-8?B?eWs0cTdOTVV3TjMydGV5SSt5cmFFR1ZWMjBsWHEzUzhqT0Zxb3Vra0lFRWtD?=
 =?utf-8?B?OUZ4TTBkVWE0SlZ4N1V6T0xaZGxGWHM1N09aTjdEdVJVWWVNaFBjeEttZlB2?=
 =?utf-8?B?NDM0cy9YZEJCWjhYMWtxYitnQ3NSbHpUUEEwelhLOTl5SzNkY1F4QitQaXcr?=
 =?utf-8?B?Y0VVZ1VHd2pTQ2d0Q3llOWFLNkJUQU5FdUFTMmdSM1FpZHUvNjhnaDJXbjhs?=
 =?utf-8?B?ZTgycitidk1ETkV2ekxNWWhzdDM2RFZRV2p5RnQrTWVxWkxrZ280ZS9nMHRK?=
 =?utf-8?B?d0NNWURXSDNEWTNPZDBJY3FJMVdNN0FNVE1lc0RSdjlod2VNODBmN0V5UVh4?=
 =?utf-8?B?NXdKbXFPVjFsQ01iMmFJSHJCQzVsWEdwZVhsZWt4TTBVNkg2SklrWW5ub0hQ?=
 =?utf-8?B?aTRudlBmbmxydnRFVkQ5clFlakdZeEZsTXFZZ00xSWdvcXQ3NXBjbUdQYlhB?=
 =?utf-8?B?L1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c24d67cf-57c0-46a9-0f2e-08dc5845b6df
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2024 03:32:42.4889
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wLfe1u1A07h5HAroTCMUURkh0qHVkXUOLb4lvoaNQQ3kic+bQRKAv8mH2MWhROPOeQUvCCouBwR3cXDs0afFhLOxFxfhpyWdX9RfoIaUzKc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7506
X-OriginatorOrg: intel.com

Hi James,

On 3/21/2024 9:51 AM, James Morse wrote:
> Because ARM's MPAM controls are probed using MMIO, resctrl can't be
> initialised until enough CPUs are online to have determined the
> system-wide supported num_closid. Arm64 also supports 'late onlined
> secondaries', where only a subset of CPUs are online during boot.
> 
> These two combine to mean the MPAM driver may not be able to initialise
> resctrl until user-space has brought 'enough' CPUs online.
> 
> To allow MPAM to initialise resctrl after __init text has been free'd,
> remove all the __init markings from resctrl.
> 
> The existing __exit markings cause these functions to be removed by the
> linker as it has never been possible to build resctrl as a module. MPAM
> has an error interrupt which causes the driver to reset and disable
> itself. Remove the __exit markings to allow the MPAM driver to tear down
> resctrl when an error occurs.

Obviously for the reasons you state this code has never been exercised.
Were you able to test this error interrupt flow yet?

Reinette