Received-SPF: pass (google.com: domain of linux-kernel+bounces-136212-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <8f4a05d5-2040-4cf2-8c05-a190c25d64db@intel.com>
Date: Mon, 8 Apr 2024 20:42:00 -0700
User-Agent: Mozilla Thunderbird
From: Reinette Chatre <reinette.chatre@intel.com>
Subject: Re: [PATCH v1 30/31] x86/resctrl: Move the filesystem bits to headers
 visible to fs/resctrl
To: James Morse <james.morse@arm.com>, <x86@kernel.org>,
	<linux-kernel@vger.kernel.org>
CC: Fenghua Yu <fenghua.yu@intel.com>, Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, H Peter Anvin
	<hpa@zytor.com>, Babu Moger <Babu.Moger@amd.com>,
	<shameerali.kolothum.thodi@huawei.com>, D Scott Phillips OS
	<scott@os.amperecomputing.com>, <carl@os.amperecomputing.com>,
	<lcherian@marvell.com>, <bobo.shaobowang@huawei.com>,
	<tan.shaopeng@fujitsu.com>, <baolin.wang@linux.alibaba.com>, Jamie Iles
	<quic_jiles@quicinc.com>, Xin Hao <xhao@linux.alibaba.com>,
	<peternewman@google.com>, <dfustini@baylibre.com>, <amitsinght@marvell.com>,
	David Hildenbrand <david@redhat.com>, Rex Nie <rex.nie@jaguarmicro.com>, Dave
 Martin <dave.martin@arm.com>
References: <20240321165106.31602-1-james.morse@arm.com>
 <20240321165106.31602-31-james.morse@arm.com>
Content-Language: en-US
In-Reply-To: <20240321165106.31602-31-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TUg2dCt5WDRYWEZUSjBUYTgxSkVuS2ZDUzZXbTE0MUxteVVUTTMxdS9ZU2pI?=
 =?utf-8?B?WjJLWXMyeUl6YTdKMFNjNVVmbUNjSmhsUTZubzJpSGxzWmxjYktqQ3BFaHIr?=
 =?utf-8?B?M21CcmcyQ1k2Q29uZVduczNUWTJDTjhRa1lMcHJ1SklkakVwWkZBNWR3QlNB?=
 =?utf-8?B?dWhsenNTSjFzZlFVKzExd0R3NjErQk9wRE8rQ2pkUTRuWStXWS9KbERWcjMr?=
 =?utf-8?B?b0RSUm5nYXJuWkdseXh2azNRamptbm8xUGViSmtRWUtHU04yOXByT2JTTjkr?=
 =?utf-8?B?cVFwU0prTFVzL2JMcDNxaGFpUkRSbFE4Nm9hcy9odGI5QVlrNDZhdU05cFo5?=
 =?utf-8?B?cDZmd01NRk4yeUtOWDRVRDhBZjZOVjF0Rmk3eUdYS3E3bVlUUzhoU3doK0JD?=
 =?utf-8?B?L1BYdjN4Q1p0RG1uMTUxVzBrYzBIN09yVkdFcGQ0VDVWYzlhQ2pyRkdNL3lB?=
 =?utf-8?B?a0lPbS9YZDZOK1hGOER1VXY3cGNuQkdxYklvZWxhbmVVZzRFTnFwQzdyZDNx?=
 =?utf-8?B?Vkl4Rk0rbkk4NHBJVkU4dVJrY3dQMUQvT2JZRzVlRDk5UkxXWm9GU212NEpF?=
 =?utf-8?B?RVRoWEdOTFluVWczU0ZDVERPdm1DeTNvcVVFWkszK2FlR0c1OTBZc1lubnM3?=
 =?utf-8?B?SmNCRGNIV1FxancwdDBsMFQraTVrbGZEVWt2QjlRUnNCeTVGWnpHV0k0UVFs?=
 =?utf-8?B?d2FpWDlOUm9adDZiejlOZ1NWdUtpWmhDV1kvQWJvM3d3SllUczVpSUJHbndB?=
 =?utf-8?B?K0FGcHZKMmtrNkJSOXZEdFY2NS9FbnIzOCtNVDlaTHVIUTJ0eTRhMXMrVThP?=
 =?utf-8?B?RExTYkovWDRxKzg2NjlDdlhkL1ppQ2k5MHMxbUFiRDFyaThUVlgxYVI4cko5?=
 =?utf-8?B?WkJLcVg3K3k5VWJYU2hRKzBXeDAyaW5TY0RTbjMxaDc2bTZWWnJxZXljMnhI?=
 =?utf-8?B?anExdGgrV3gwMkRBUW9hWFlJWWo1QWgxZ1lsSlZsSVp0eFhDQ3EvWHRWVzNT?=
 =?utf-8?B?emtucVRhMWFVVCtTelBHNTZRVnBLa1l4Y2pJaWlzRk5kWE5mVGFKaWtnWUk1?=
 =?utf-8?B?Y2hCMHU4bEl6TExjcEg3RExmM1dJa1h3LzUyKzZOZ0Z2cnQwUFhkeitDOENt?=
 =?utf-8?B?U1lOM0hSVnBTQlEzRzlVV2w1ckl0OWJDWndzaWUyTktVT3FqRWhIRkUxZ2Nx?=
 =?utf-8?B?eE84VUk5MDA0WTFxaDRSZXoyNy85ckw0djZ3c2YzQkZMa1VoWTJaeldLbmVE?=
 =?utf-8?B?U2h2SzdFbFAxWEhLYjhCM2JsaVlhYVQxTkcvR3RlSmhhS0RCZGxEVE9sZk93?=
 =?utf-8?B?YnFXOXpwN1VGRVVYb3lDdjA2eVhXblQ5WWpzdTIzT2Zxa09YckMyUmRVeUJT?=
 =?utf-8?B?L1E1UVpiWHhoMnpMQUVZSWlxc1RXQURZS0RrT2JJQ1hqRzlrb0YvbktvMDlY?=
 =?utf-8?B?TExENEZ3aDVwcGk2OGVTNHpoYXJib3BpelkyY2lkT0orTWNBWHdQM2hTdW53?=
 =?utf-8?B?RXArd0Y4TVJHcU1Ka2lkZXMxUGQvWE1rTDVRY3RFczBNUUUrcHNNLzRxVTNU?=
 =?utf-8?B?RkpIUXNlUzVmYjlYcG82WnF2ZGp3SFJHbW5oNzF2T1didkd1RXdHdVpkTEJE?=
 =?utf-8?B?Q3ljSStTdGxZWXo4eWppTFBrRWxHeXRxL2ZIalhtYXNZRGxaZE5lMWdPSEc5?=
 =?utf-8?B?SWExSitmbERVVGlMczlTN2U4d2hFYTRnbnplMmRXVXZQZW5mTG11RW1HZlN4?=
 =?utf-8?B?elROZ3FBcVhhN2ozU2lwUEgzOHg2VlYvQjcvY0hNaVV6U0NBall4UG1FQTZ1?=
 =?utf-8?B?T0dMajFkblN1ZlQwaTVERTdYb1B4c2lDZlpGdWR0Yms2SXVieUdQWHF3WXZn?=
 =?utf-8?B?STZ6djBKWFZ3Y2RvaHZwclhVR29PSG01aFN0WVU0a0MrUG9TOFVZbVlSYXV6?=
 =?utf-8?B?UHBMSGNCSlhORFZWTHNBWm9jdSt6cjhnd09xTDBBM0xaajUrb1BSYks5UEVH?=
 =?utf-8?B?K3RONTg3TFhHT1Q5SUo5NUVicU9zQmlJMSs5c3ArZ0xsSUd3dnRVU0ZvU2Zq?=
 =?utf-8?B?d2w0WEhRamprWUNmc2tmclRtUUh2MFh6TVBHMXJ6b0lKeXYvdTJlbjRER0tk?=
 =?utf-8?B?QWpUWnU4TWVaN3lDUHhzL1hDS3VLQVBwYXlINHlnWVZwK2h0YStJdnlFdEJN?=
 =?utf-8?B?QWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 638337d3-ed0e-4f29-3703-08dc58470484
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2024 03:42:02.2548
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: F5Mng5O6NnHRI9QVOTnE1yNcf4Qlt0Jt1MSIuRJOMO45m1KKj62/Ht3XeO4y6hzr/mYUVZebGBmiuXZRYzIyX+hlmDFkPdONzwkYpdtLX94=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4666
X-OriginatorOrg: intel.com

Hi James,

On 3/21/2024 9:51 AM, James Morse wrote:
..
> diff --git a/include/linux/resctrl_types.h b/include/linux/resctrl_types.h
> index 4788bd95dac6..fe0b10b589c0 100644
> --- a/include/linux/resctrl_types.h
> +++ b/include/linux/resctrl_types.h
> @@ -7,6 +7,36 @@
>  #ifndef __LINUX_RESCTRL_TYPES_H
>  #define __LINUX_RESCTRL_TYPES_H
>  
> +#define CQM_LIMBOCHECK_INTERVAL	1000
> +
> +#define MBM_CNTR_WIDTH_BASE		24
> +#define MBM_OVERFLOW_INTERVAL		1000
> +#define MAX_MBA_BW			100u
> +#define MBA_IS_LINEAR			0x4
> +
> +/* rdtgroup.flags */
> +#define	RDT_DELETED		1
> +
> +/* rftype.flags */
> +#define RFTYPE_FLAGS_CPUS_LIST	1
> +
> +/*
> + * Define the file type flags for base and info directories.
> + */
> +#define RFTYPE_INFO			BIT(0)
> +#define RFTYPE_BASE			BIT(1)
> +#define RFTYPE_CTRL			BIT(4)
> +#define RFTYPE_MON			BIT(5)
> +#define RFTYPE_TOP			BIT(6)
> +#define RFTYPE_RES_CACHE		BIT(8)
> +#define RFTYPE_RES_MB			BIT(9)
> +#define RFTYPE_DEBUG			BIT(10)
> +#define RFTYPE_CTRL_INFO		(RFTYPE_INFO | RFTYPE_CTRL)
> +#define RFTYPE_MON_INFO			(RFTYPE_INFO | RFTYPE_MON)
> +#define RFTYPE_TOP_INFO			(RFTYPE_INFO | RFTYPE_TOP)
> +#define RFTYPE_CTRL_BASE		(RFTYPE_BASE | RFTYPE_CTRL)
> +#define RFTYPE_MON_BASE			(RFTYPE_BASE | RFTYPE_MON)
> +
>  /* Reads to Local DRAM Memory */
>  #define READS_TO_LOCAL_MEM		BIT(0)
>  

Not all these new seem to belong in this file. Could you please confirm?

For example:
Earlier in series it was mentioned that struct rdtgroup is private to the
fs so having RDT_DELETED is unexpected as it implies access to struct rdtgroup.

CQM_LIMBOCHECK_INTERVAL seems private to the fs code, so too
RFTYPE_FLAGS_CPUS_LIST.

Reinette