Received-SPF: pass (google.com: domain of linux-kernel+bounces-136224-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <94bce3e14a32d017c0f8acb6726a3484fda01cfd.camel@kernel.org>
Subject: Re: [PATCH 1/1] cxl/acpi.c: Add buggy BIOS hint for CXL ACPI lookup
 failure
From: PJ Waskiewicz <ppwaskie@kernel.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>, Lukas Wunner
	 <lukas@wunner.de>, linux-cxl@vger.kernel.org, linux-pci@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Date: Mon, 08 Apr 2024 21:22:55 -0700
In-Reply-To: <ZhRii1BAg86gccWM@snoopy>
References: <20240407210526.8500-1-ppwaskie@kernel.org>
	 <ZhMP-NBMb387KD4Y@wunner.de> <ZhNQa8wAflycciNA@snoopy>
	 <20240408093422.000062d9@Huawei.com> <ZhRFsUiDieY+HhfV@snoopy>
	 <6614575a1c15c_2583ad29476@dwillia2-xfh.jf.intel.com.notmuch>
	 <ZhRii1BAg86gccWM@snoopy>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.0-1 
Precedence: bulk
MIME-Version: 1.0

On Mon, 2024-04-08 at 14:32 -0700, PJ Waskiewicz wrote:
> >=20
> > Turns out that straightforward message is aleady a driver message,
> > but
> > it gets skipped in this case. So, I am thinking of cleanup /
> > clarification along the following lines:
> >=20
> > 1/ Lean on the existing cxl_get_chbs() validation paths to report
> > on
> > errors
> >=20
> > 2/ Include the device-name rather than the UID since if UID is
> > unreliable it does not help you communicate with your BIOS vendor.
> > I.e.
> > give a breadcrumb for the BIOS engineer to match the AML device
> > name
> > with the CEDT content.
> >=20
> > 3/ Do not fail driver load on a single host-bridge parsing failure
> >=20
> > 4/ These are all cxl_acpi driver init events, so consistently use
> > the
> > ACPI0017 device, and the cxl_acpi driver, as the originator of the
> > error
> > message.
> >=20
> > Would this clarification have saved you time with the debug?

I guess I should have asked: would you like me to pull this patch in
and give it a test on a known broken host?  I'm happy to do it.

-PJ