Received-SPF: pass (google.com: domain of linux-kernel+bounces-136228-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Bharat Bhushan <bbhushan2@marvell.com>
To: Chen Ni <nichen@iscas.ac.cn>,
        "bbrezillon@kernel.org"
	<bbrezillon@kernel.org>,
        "arno@natisbad.org" <arno@natisbad.org>,
        Srujana
 Challa <schalla@marvell.com>,
        "herbert@gondor.apana.org.au"
	<herbert@gondor.apana.org.au>,
        "davem@davemloft.net" <davem@davemloft.net>
CC: "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXTERNAL] [PATCH] crypto: octeontx2 - add missing check for
 dma_map_single
Thread-Topic: [EXTERNAL] [PATCH] crypto: octeontx2 - add missing check for
 dma_map_single
Thread-Index: AQHaiVh2tQ/R/jxRl0KfSN0JAGF1VbFfV/OQ
Date: Tue, 9 Apr 2024 04:23:17 +0000
Message-ID: 
 <SN7PR18MB531447D46F3AE83AA06BE1B8E3072@SN7PR18MB5314.namprd18.prod.outlook.com>
References: <20240408015914.101442-1-nichen@iscas.ac.cn>
In-Reply-To: <20240408015914.101442-1-nichen@iscas.ac.cn>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?ZQ5lPOPzhuY2hfNSXZEevaSeFuBol61ENKhB9eOcppL0UKiikhctBl95hbbD?=
 =?us-ascii?Q?hHtrgRT+DL7bzvzRCT9T6iktqd/DKBALUPTIQJzrwOcjdK/ej/u8WOQTtmRw?=
 =?us-ascii?Q?CaoX911Q+/Gd+BfU+Egdc4d8omClAQ0nIaO1MyX0LWiLdUy/JUopjCUpA7Ol?=
 =?us-ascii?Q?d/R/+Kkt1fX0Skpsa/gzjDVeUE4s1WGY3gFQABeGnaAXXKNsIY7Ud30TX700?=
 =?us-ascii?Q?nFc13zoFGKzLul7LxTDk8nTQVC6J2Gj1tA+STdFxy1HABnKAG7jmsbYHR1sD?=
 =?us-ascii?Q?XswoIR1w/BNzfITh0fYQ+J+jNege8MC8A7bdewmrtr9bRAaXdu5BIbwxBKxU?=
 =?us-ascii?Q?NF8KD9fRCtAOG02Pk6n5sa9Ym2QbZ48HHfhi+6+aSGrQSZoQc541lILQ3D5y?=
 =?us-ascii?Q?8BhAzywR24wYGfj9Tb/cJ7tdfgo8bL8/okku3vF202VRLPy5/fHSlGaLmRgH?=
 =?us-ascii?Q?iGc4wY1jiW7cap+ODxmoHpf4laVUQcZrbVzSNS3gUtkMivLmDNgVdPhM2OWX?=
 =?us-ascii?Q?+GZ6DPk5cHzDceeUwivP5L5suzqqlxWzsctvso9+X9YpoolrYACeoqDPkyvL?=
 =?us-ascii?Q?Bc4OWqKx8d0Wv4fLx5+4FE9/EoD6ceoOIQQwSX4iP7NnC9lTQX9Jil5FsUuj?=
 =?us-ascii?Q?IWR8npXAdsDT1L6sQBrPJHVlwzMJRvqsZE+20OglJYHCQx6T76PvzE+k/MAZ?=
 =?us-ascii?Q?ADL20diAPY9ZITmx3ZBs3Oz1Qe1qqJMnXw1PHUTbipcLoVasEmHHRi+ReCfv?=
 =?us-ascii?Q?OPpI35LVFAXzg/fiMzYAAefNllqAiu8fKfuwPoil+EKIkIHaJIrygzPXuS0U?=
 =?us-ascii?Q?Pm5N8G78eUnZjC/vcVxXHnbaw6oWw4cjrhzZzy2K3YZTwVtBzIsBo6Tk7844?=
 =?us-ascii?Q?UoLt1QQr4zG9aJ9TvpVxxMq0OoB5DGaUEqmzzEkIXOsJDJHkpEDx/B0xqOwG?=
 =?us-ascii?Q?robGwnjmtgszMbrNv+NYt/iZu+4kPwgk566dW5y646G1J8vXYhNtq9aCX3Qq?=
 =?us-ascii?Q?5TPLNHw+nYkpczc3zmZ26/8ILC7ciDKA4KnZ/fqvuOFZzuT5DVMUBA9A5/08?=
 =?us-ascii?Q?/rS6Ij6GcjcUBz0J+scgME/Ky1C4no8outif3H1CLAgv10AEJLEVpuXGV10H?=
 =?us-ascii?Q?j1WfXlJkF5esTXoNpL4O0RWgeBnUtmOUKHjAj6GFs71EC3LHueHhmtrQEi+9?=
 =?us-ascii?Q?U5ILwHwYJWO0dqxNYsogxVJ6pKWkVXOpKj5kBd8cDj8olBZweM1SEuVtWjNe?=
 =?us-ascii?Q?kIcp9Za7QIZdV1RC9pQRu6YpkIGTS03H51CaaOoupDFKi3My6FXTlGoZzq58?=
 =?us-ascii?Q?lhfeAEuzbqKrJdh86metpJQHSjI2wBmOD6vdKNC+X24QKix/fMd+Bj98DDgV?=
 =?us-ascii?Q?Ze4oZqkx4Vul8cWblZzlBTkjnt5j8ZmCdfUlYFB7G2gu8wsjIox7Rxeejujs?=
 =?us-ascii?Q?zXyg7NXSRnDn9JTuN8TcpJeCR8lYGro1cTGSKQOMDcI8//8YL1SEHb3/gPda?=
 =?us-ascii?Q?VRWsyHT6OsazrGMj5yWXUfnBFeM9nr63q1LtQn5aa4vpHw1C50QUIUSRCj9w?=
 =?us-ascii?Q?KcdbYGdEsNsCLxmJ7xs/ooqU2pzy9tfEouPpHAxR?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN7PR18MB5314.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ef35d12a-d839-4c4f-4c6b-08dc584cc82d
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2024 04:23:17.8595
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: kd76CAVJ9ihFaa9vZWvwKMRs1TGgcdWxNIc00FHRtD/7DFh23nEToXne7d5jPNKJgs+sM3OLU/aBBRMD5D8qIw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB4637
X-Proofpoint-ORIG-GUID: tmxbZN6ultQzJws8J0P-N0xqNkpwCwo5
X-Proofpoint-GUID: tmxbZN6ultQzJws8J0P-N0xqNkpwCwo5
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-04-09_01,2024-04-05_02,2023-05-22_02


> -----Original Message-----
> From: Chen Ni <nichen@iscas.ac.cn>
> Sent: Monday, April 8, 2024 7:29 AM
> To: bbrezillon@kernel.org; arno@natisbad.org; Srujana Challa
> <schalla@marvell.com>; herbert@gondor.apana.org.au;
> davem@davemloft.net
> Cc: linux-crypto@vger.kernel.org; linux-kernel@vger.kernel.org; Chen Ni
> <nichen@iscas.ac.cn>
> Subject: [EXTERNAL] [PATCH] crypto: octeontx2 - add missing check for
> dma_map_single
>=20
> ----------------------------------------------------------------------
> Add check for dma_map_single() and return error if it fails in order to a=
void
> invalid dma address.
>=20
> Fixes: e92971117c2c ("crypto: octeontx2 - add ctx_val workaround")
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>  drivers/crypto/marvell/octeontx2/cn10k_cpt.c | 4 ++++
>  1 file changed, 4 insertions(+)
>=20
> diff --git a/drivers/crypto/marvell/octeontx2/cn10k_cpt.c
> b/drivers/crypto/marvell/octeontx2/cn10k_cpt.c
> index 79b4e74804f6..6bfc59e67747 100644
> --- a/drivers/crypto/marvell/octeontx2/cn10k_cpt.c
> +++ b/drivers/crypto/marvell/octeontx2/cn10k_cpt.c
> @@ -138,6 +138,10 @@ int cn10k_cpt_hw_ctx_init(struct pci_dev *pdev,
>  		return -ENOMEM;
>  	cptr_dma =3D dma_map_single(&pdev->dev, hctx,
> CN10K_CPT_HW_CTX_SIZE,
>  				  DMA_BIDIRECTIONAL);
> +	if (dma_mapping_error(&pdev->dev, cptr_dma)) {
> +		kfree(hctx);
> +		return -ENOMEM;
> +	}

Thanks for fixing,
Reviewed-by: Bharat Bhushan <bbhushan2@marvell.com>

>=20
>  	cn10k_cpt_hw_ctx_set(hctx, 1);
>  	er_ctx->hw_ctx =3D hctx;
> --
> 2.25.1
>=20