Received-SPF: pass (google.com: domain of linux-kernel+bounces-136230-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 9 Apr 2024 06:31:50 +0200
From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Arun.Ramadoss@microchip.com
Cc: andrew@lunn.ch, olteanv@gmail.com, davem@davemloft.net,
	Woojung.Huh@microchip.com, pabeni@redhat.com, edumazet@google.com,
	f.fainelli@gmail.com, kuba@kernel.org, kernel@pengutronix.de,
	dsahern@kernel.org, san@skov.dk, willemb@google.com,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	horms@kernel.org, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net-next v4 5/9] net: dsa: microchip: add support for
 different DCB app configurations
Message-ID: <ZhTEtmcvubthMXmB@pengutronix.de>
References: <20240408074758.1825674-1-o.rempel@pengutronix.de>
 <20240408074758.1825674-6-o.rempel@pengutronix.de>
 <40d90a28d95bff48f352a3aaf81df2b1a6133cc7.camel@microchip.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <40d90a28d95bff48f352a3aaf81df2b1a6133cc7.camel@microchip.com>

Hi Arun,

On Mon, Apr 08, 2024 at 04:10:15PM +0000, Arun.Ramadoss@microchip.com wrote:
> > +int ksz_port_get_default_prio(struct dsa_switch *ds, int port)
> > +{
> > +       struct ksz_device *dev = ds->priv;
> > +       int ret, reg, shift;
> > +       u8 data, mask;
> > +
> > +       ksz_get_defult_port_prio_reg(dev, &reg, &mask, &shift);
> > +
> > +       ret = ksz_pread8(dev, port, reg, &data);
> > +       if (ret)
> > +               return ret;
> > +
> > +       return (data & mask) >> shift;
> 
> I assume we can use retrun FIELD_GET(mask, data), since mask is GENMASK
> format. 
> 
> > 
> > +int ksz_port_set_default_prio(struct dsa_switch *ds, int port, u8
> > prio)
> > prio)
> > +{
> > +       struct ksz_device *dev = ds->priv;
> > +       int reg, shift;
> > +       u8 mask;
> > +
> > +       if (prio >= dev->info->num_tx_queues)
> > +               return -EINVAL;
> > +
> > +       ksz_get_defult_port_prio_reg(dev, &reg, &mask, &shift);
> > +
> > +       return ksz_prmw8(dev, port, reg, mask, (prio << shift) &
> > mask);
> 
> FIELD_PREP(mask, prio)

Sadly, FIELD_GET() and FIELD_PREP() do not work with dynamic masks.

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |