Received-SPF: pass (google.com: domain of linux-kernel+bounces-136251-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <694fdd96-cc6e-4a4e-aff5-3284cd3ada4e@linux.microsoft.com>
Date: Mon, 8 Apr 2024 22:28:34 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 1/1] ACPI: CPPC: Fix access width used for PCC
 registers
To: Jarred White <jarredwhite@linux.microsoft.com>,
 Vanshidhar Konda <vanshikonda@os.amperecomputing.com>
Cc: "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
 linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240329220054.1205596-1-vanshikonda@os.amperecomputing.com>
 <eecf5b00-0b61-46a8-82d9-a3c113f2d956@linux.microsoft.com>
 <m2m7qytrlhdvht7ro6hee2msi2bd5j733yagdakyjfxi2su46i@nj77lj3ulqp7>
 <365b430b-d91c-4391-bfc4-ea6a3444cb43@linux.microsoft.com>
Content-Language: en-CA
From: Easwar Hariharan <eahariha@linux.microsoft.com>
In-Reply-To: <365b430b-d91c-4391-bfc4-ea6a3444cb43@linux.microsoft.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 4/8/2024 1:19 PM, Jarred White wrote:
> On 4/1/2024 10:45 AM, Vanshidhar Konda wrote:
>> On Mon, Apr 01, 2024 at 09:48:28AM -0700, Easwar Hariharan wrote:
>>> Hi Vanshi,
>>>
>>> Thanks for testing and catching this. One comment below, but Jarred is OOF for a couple days so
>>> we'll get back again after testing on our platform.
>>>
>>> On 3/29/2024 3:00 PM, Vanshidhar Konda wrote:
>>>> Commit 2f4a4d63a193 ("ACPI: CPPC: Use access_width over bit_width for
>>>> system memory accesses") modified cpc_read/cpc_write to use access_width to
>>>> read CPC registers. For PCC registers the access width field in the ACPI
>>>> register macro specifies the PCC subspace id. For non-zero PCC subspace id
>>>> the access width is incorrectly treated as access width. This causes errors
>>>> when reading from PCC registers in the CPPC driver.
>>>>
>>>> For PCC registers base the size of read/write on the bit width field.
>>>> The debug message in cpc_read/cpc_write is updated to print relevant
>>>> information for the address space type used to read the register.
>>>>
>>>> Fixes: 2f4a4d63a193 ("ACPI: CPPC: Use access_width over bit_width for system memory accesses")
>>>> Signed-off-by: Vanshidhar Konda <vanshikonda@os.amperecomputing.com>
>>>> ---

Hi Vanshi,

When you send v2 for the SystemMemory space fixes, could you add CC: stable@vger.kernel.org # 5.15+
to your commit message, since your patch fixes 2f4a4d63a193 that was marked for stable?

Thanks,
Easwar