Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp1796218lqe; Mon, 8 Apr 2024 23:45:08 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW93YqceiJdYIHyUKSYSjMDYIQIwflOO4WLzj7sbGzgMW0SvBp064qwLbvny/LCCSHx0LWooKCNbgA7SILDimfXcaZ7xao5LaJP3lokCQ== X-Google-Smtp-Source: AGHT+IFao0PlSmgwN2ti7B5KDB03++XSkQxvAlbqECUr3kx2jZv1122f2mVvrNU8DJKFe0UdMBNF X-Received: by 2002:a05:6a20:1048:b0:1a7:e00:505a with SMTP id gt8-20020a056a20104800b001a70e00505amr8161815pzc.27.1712645108125; Mon, 08 Apr 2024 23:45:08 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712645108; cv=pass; d=google.com; s=arc-20160816; b=WH05OSm5jrpxjj5Pk6MWdvROJ5kd2rY+JZr5ET7e66H2vB2WfOYNkmfVsQi33H2751 Z8Dcv7ezh8XYE+vp/3ro7SXH2t0m3k5zkcRFCmtzy5fwguK3vB26nDXNVHhmceO36TVo 1uw3gvbExfa8ZlfSRtpcarWYV/xAEAk1iVpEUsGSCzYH6qhwPVmHXfeHcybJ+fRwRJa/ kxOVaXfG/qKDTuR8Tx8hbydEq/GPTVCYNkwvFdEh317NUR2q78dZwifsgM2W8wAHwQQ7 4UAYK6QlRnJb1fbJ925QnAbMAWswCVydhvJ6ToJL+z7QJPJp5//VQ21sTOhO1ZDn8qq1 A1xA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=Krd0BAesKO2iMVNygzUAooa8aMl2YxIa+szFLm86h3M=; fh=bwMXkGu8OCnK8MT+6EWNJb2/1rlvkm29gppklX7STgI=; b=YcoBJu8cR8UiCPzVwIkYqQQml1pr9TqKM6Ib+QJKqxxHFN/zgThlaLlv7vwObBu4gB 5U5baXrjFRLnuvguFR9fWgjWF2MyHlB/4bwvTpwD/AzWzlc6uwg9DexTY3+o/N0kXfnP ugD2J0pUbtAj2O50Fa+0LYDZ9/UBcNYiWayMDbNrrwGLF3OxzjPQiSwY7z0OM1clgNls J52wgHvBaod2mCSjw/EJtfdgl57WK4m0p/MlQJIBROB7QGiR1pEkCulU5FAwH6KLRpx5 CtiNCh6zxKKmZ69pSLK5jcdIcgp2g/ENS+s4TYDuguLW/GUUiFzelXbg/hZR36V/ht+A ZRhg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=Lxe0W+ue; arc=pass (i=1 spf=pass spfdomain=bootlin.com dkim=pass dkdomain=bootlin.com dmarc=pass fromdomain=bootlin.com); spf=pass (google.com: domain of linux-kernel+bounces-136315-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-136315-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id iz1-20020a170902ef8100b001e20290828fsi7434865plb.637.2024.04.08.23.45.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Apr 2024 23:45:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-136315-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=Lxe0W+ue; arc=pass (i=1 spf=pass spfdomain=bootlin.com dkim=pass dkdomain=bootlin.com dmarc=pass fromdomain=bootlin.com); spf=pass (google.com: domain of linux-kernel+bounces-136315-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-136315-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id B94E3B23BF7 for ; Tue, 9 Apr 2024 06:42:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9EA2F7BAEC; Tue, 9 Apr 2024 06:41:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="Lxe0W+ue" Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40A5C74435; Tue, 9 Apr 2024 06:41:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.200 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712644898; cv=none; b=MJ2AJ6nXjNhNhLybmzq9OdYz+GPVlACpwG6X2PG+8LoTdx6ZQkT8dZAhD2bCdw1sWUc93FEG78QqongPT0NC5E12T1QeKZ3FAj7z8QZNMcKhI5dAXDPy3ZFv6NMFf9wridk9cVIGyucctZ3kzFh1Ajbajwo37p3oUQRT1bZ0n80= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712644898; c=relaxed/simple; bh=Ypa096u1rxKyRP+T+Cgia169tt3nEpsKn06F40LBBzM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=oZutkxGTq0Ta0rELRRQvoftejTMMBBW2MJTV7To69VR+/T/lZ/DI9oPPOa2Xn5YmSygQY/cyQjUvV/VPyDqqUlIOdr8105YdixDCLIkOGraP/5V/S592uo5Y9Q2obqS6BJOUXsRKnxnJaY8Ln7ki6ACctcHzW59h9Q4Fgtv1WJk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=Lxe0W+ue; arc=none smtp.client-ip=217.70.183.200 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id D81EE20008; Tue, 9 Apr 2024 06:41:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1712644894; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Krd0BAesKO2iMVNygzUAooa8aMl2YxIa+szFLm86h3M=; b=Lxe0W+ueNHMvhA4jruFrl5RfQzBTaAwiNuT2BRmIhCvleayAKis6628tUeRLpLuLs3r7Rx ZlMwOSDISL8uK9+eochy5Ix8u78E+Q6SYOzhaGpT6SQ3Wmpmdifyf/9r4Vkmi+SVECGX0M lhTVStGd4M9m2T+v+6zziB6kRayBkJa419CfYNXVKcdtSTasmAzVR/qwcw1tXRje+xmDVO OskZtnTc+AEaLPCTUej8AbTQOR6BJHiKhAvEo0NjcoIMsqeRdUEieqCp6GqFj551UTORz3 QGLEJJcoc5nXrlkFDb3FznjhmWttxwaVsx3HGg5YEA9RstzZJm/HDgCpAXePlw== From: Miquel Raynal To: Christian Marangi , Manivannan Sadhasivam , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Md Sadre Alam , Sricharan Ramabadhran , linux-mtd@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org Subject: Re: [PATCH v4] mtd: rawnand: qcom: Fix broken OP_RESET_DEVICE command in qcom_misc_cmd_type_exec() Date: Tue, 9 Apr 2024 08:41:33 +0200 Message-Id: <20240409064133.91927-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240404083157.940-1-ansuelsmth@gmail.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-linux-mtd-patch-notification: thanks X-linux-mtd-patch-commit: b'b61bb5bc2c1cd00bb53db42f705735db6e8700f0' Content-Transfer-Encoding: 8bit X-GND-Sasl: miquel.raynal@bootlin.com On Thu, 2024-04-04 at 08:31:55 UTC, Christian Marangi wrote: > While migrating to exec_ops in commit a82990c8a409 ("mtd: rawnand: qcom: > Add read/read_start ops in exec_op path"), OP_RESET_DEVICE command handling > got broken unintentionally. Right now for the OP_RESET_DEVICE command, > qcom_misc_cmd_type_exec() will simply return 0 without handling it. Even, > if that gets fixed, an unnecessary FLASH_STATUS read descriptor command is > being added in the middle and that seems to be causing the command to fail > on IPQ806x devices. > > So let's fix the above two issues to make OP_RESET_DEVICE command working > again. > > Fixes: a82990c8a409 ("mtd: rawnand: qcom: Add read/read_start ops in exec_op path") > Cc: stable@vger.kernel.org > Reviewed-by: Manivannan Sadhasivam > Signed-off-by: Christian Marangi Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes, thanks. Miquel