Received-SPF: pass (google.com: domain of linux-kernel+bounces-136323-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 9 Apr 2024 14:45:06 +0800
From: Chao Gao <chao.gao@intel.com>
To: Alejandro Jimenez <alejandro.j.jimenez@oracle.com>
CC: <kvm@vger.kernel.org>, <seanjc@google.com>, <pbonzini@redhat.com>,
	<linux-kernel@vger.kernel.org>, <joao.m.martins@oracle.com>,
	<boris.ostrovsky@oracle.com>, <mark.kanda@oracle.com>,
	<suravee.suthikulpanit@amd.com>, <mlevitsk@redhat.com>
Subject: Re: [RFC 3/3] x86: KVM: stats: Add a stat counter for GALog events
Message-ID: <ZhTj8kdChoqSLpi8@chao-email>
References: <20240215160136.1256084-1-alejandro.j.jimenez@oracle.com>
 <20240215160136.1256084-4-alejandro.j.jimenez@oracle.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240215160136.1256084-4-alejandro.j.jimenez@oracle.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LE4OkiHSL9doDYhf1vPim3Rby8hJuYBSp+lMZjyvysjNAhaPXdovnTsVWrnU?=
 =?us-ascii?Q?yMxO6v8zOmbup1DvzX6JEqpKhSCgAkcsW3Mat8Hx19NmOu4uzxuOG5FX8bEy?=
 =?us-ascii?Q?WspWWzb/UKOCuV8Dhp3P+iHV/fg0s6sPUPJcXEsFDbaexfgJkHqiaCfz+wMS?=
 =?us-ascii?Q?RMIYr1qNmiw57FTrStKmQnolPcSnmTQXFcc+NoHDHexMlL32nx+NRVLVZul0?=
 =?us-ascii?Q?JjoiD5c0o4wHkHnyRUJrFG3Xl0/NovPYqHSKkARI7Pemmm+WitfcX4dstJVx?=
 =?us-ascii?Q?xoXn/Oo2e0qxXlDuxyh6HOJtc+BOCB/2Vy15Kcat7b74fzsIp2+ir/Cjsd73?=
 =?us-ascii?Q?zSDrVS2x+bwA8F4UGZtCSI/LBddJ+exP+6xI8Jhdq+g4JTnr80gUB+GgyA9z?=
 =?us-ascii?Q?iz1M2ydUURgMUW/9rhcPYPq7cSdYGI1o4hOkdtJ0KGRJjnH1276AqLzRmVkm?=
 =?us-ascii?Q?p9H5drsfqg0Ds/ufBUnoKpYqyCLxSYHn+0HVPEzjzcZAe0ASS5BEvMypNap5?=
 =?us-ascii?Q?mF4TaZKMk6y8lVzwVDy3PXZdiHFQVSQMGisIUU11w3s0VZ8426hDe536n3Ro?=
 =?us-ascii?Q?ldWZISBR2A/lBdwMQnebmphAWTXuzWvUaVxfzM4j9/C6u0HFXODTpC+Tm98o?=
 =?us-ascii?Q?0KpeRE4I7mLtgVJ6K0OuSPi/LNAOGRyBIj16diNoThQsxGakYawMt6TnzVRu?=
 =?us-ascii?Q?X+zc3oIq8H8slaTQ+6gjxsRQ4rrxFLZtp0e+kJ319dv7fQtCxbOhKPF3a67q?=
 =?us-ascii?Q?o2Sk3EZzPw7kRtypHy82EqOFOXmLF+VyTUqw0HYytc8aj6tHodhv5x7Ki+5C?=
 =?us-ascii?Q?SnomsyixR4eTZWTo6/Q1dZzJnIPNO7/rrPnAYsALXy//XxYxXvqU9z1A8CRv?=
 =?us-ascii?Q?WUsqAJRAiCFe97nGDJ1HXaCZkazMHX1aQlBDU2tvpf45tnmfn7KMXuO1wBGX?=
 =?us-ascii?Q?2gYKZ57/imGZASUWKnyi+Wm6zSU2xvBjG4dLhTLXn2G3iz6ZERUMlnItlD6A?=
 =?us-ascii?Q?/9oMFKUvIk2ATvCQf97d8ZTMRCm0DO6uciUo+gzSBk/EGTGZUTNeplLV89bK?=
 =?us-ascii?Q?CMFm812mL5oLte9YzJI6wexK6JuSbEv7ryv3B5kcPP1RiFUjc5n+5B6UQnY4?=
 =?us-ascii?Q?e2uiHH0Lyiy1kZsKpqd5dRAScPXokPD1jJQ/qsWkDzRaC4o0tKJNrzs8CAUG?=
 =?us-ascii?Q?lUWLfC2q/R/7Yg8nSmRdkaaoQiymO6y/1T4FVpRN0pyKY/RuqfoVU3R5ZOMx?=
 =?us-ascii?Q?OyZAysYcDL63DQVdZFH1FHfFdrfred9O/XgYDQtfaXH30huX4PA/mgiPg8+h?=
 =?us-ascii?Q?b7eA1+oY3srJfSC+UuVM0vcJAAyiRwK0XdESAkfkG7AYQvklI6m37M6ZgRco?=
 =?us-ascii?Q?dhVPFikthLvAf68TjLJiDImihCtRkqiYtHk+1K8jVoIWPMXkPfBNAsQ90DLN?=
 =?us-ascii?Q?6ncuI1VL07nZlWLVs3Fv7yCb6gR0Lxun1sCgsoZurdORWmSPYtywpsl6cjTq?=
 =?us-ascii?Q?gWq4hFU9O+aWyGpLCcBB5W+jCdWmxFd/VRlej/HSv0rPFjCsNxfKwsy3RgtJ?=
 =?us-ascii?Q?ZeXyZLukCOoEkciyArjjt9xr884sig30JGx7SCae?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c6e76afa-8fc6-4511-83be-08dc58609d07
X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB8660.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2024 06:45:15.5574
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: N3yze2RBaZpQTg0oN8m5pAS4/jgLDChSm4e1+wYQPBp8BDXOzhN05gZJyOFkxTF1yussIXkqeVlebMaqrP4njg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6390
X-OriginatorOrg: intel.com

>diff --git a/arch/x86/kvm/svm/avic.c b/arch/x86/kvm/svm/avic.c
>index 4b74ea91f4e6..853cafe4a9af 100644
>--- a/arch/x86/kvm/svm/avic.c
>+++ b/arch/x86/kvm/svm/avic.c
>@@ -165,8 +165,10 @@ int avic_ga_log_notifier(u32 ga_tag)
> 	 * bit in the vAPIC backing page. So, we just need to schedule
> 	 * in the vcpu.
> 	 */
>-	if (vcpu)
>+	if (vcpu) {
> 		kvm_vcpu_wake_up(vcpu);
>+		++vcpu->stat.ga_log_event;
>+	}
> 

I am not sure why this is added for SVM only. it looks to me GALog events are
similar to Intel IOMMU's wakeup events. Can we have a general name? maybe
iommu_wakeup_event

and increase the counter after the kvm_vcpu_wake_up() call in pi_wakeup_handler().