Received-SPF: pass (google.com: domain of linux-kernel+bounces-136326-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: "Huang, Ying" <ying.huang@intel.com>
To: Yuanchu Xie <yuanchu@google.com>
Cc: David Hildenbrand <david@redhat.com>,  "Aneesh Kumar K.V"
 <aneesh.kumar@linux.ibm.com>,  Khalid Aziz <khalid.aziz@oracle.com>,
  Henry Huang <henry.hj@antgroup.com>,  Yu Zhao <yuzhao@google.com>,  Dan
 Williams <dan.j.williams@intel.com>,  Gregory Price
 <gregory.price@memverge.com>,  Wei Xu <weixugc@google.com>,  David
 Rientjes <rientjes@google.com>,  Greg Kroah-Hartman
 <gregkh@linuxfoundation.org>,  "Rafael J. Wysocki" <rafael@kernel.org>,
  Andrew Morton <akpm@linux-foundation.org>,  Johannes Weiner
 <hannes@cmpxchg.org>,  Michal Hocko <mhocko@kernel.org>,  Roman Gushchin
 <roman.gushchin@linux.dev>,  Muchun Song <muchun.song@linux.dev>,  Shuah
 Khan <shuah@kernel.org>,  Yosry Ahmed <yosryahmed@google.com>,  Matthew
 Wilcox <willy@infradead.org>,  Sudarshan Rajagopalan
 <quic_sudaraja@quicinc.com>,  Kairui Song <kasong@tencent.com>,  "Michael
 S. Tsirkin" <mst@redhat.com>,  Vasily Averin <vasily.averin@linux.dev>,
  Nhat Pham <nphamcs@gmail.com>,  Miaohe Lin <linmiaohe@huawei.com>,  Qi
 Zheng <zhengqi.arch@bytedance.com>,  Abel Wu <wuyun.abel@bytedance.com>,
  "Vishal Moola (Oracle)" <vishal.moola@gmail.com>,  Kefeng Wang
 <wangkefeng.wang@huawei.com>,  linux-kernel@vger.kernel.org,
  linux-mm@kvack.org,  cgroups@vger.kernel.org,
  linux-kselftest@vger.kernel.org
Subject: Re: [RFC PATCH v3 1/8] mm: multi-gen LRU: ignore non-leaf pmd_young
 for force_scan=true
In-Reply-To: <20240327213108.2384666-2-yuanchu@google.com> (Yuanchu Xie's
	message of "Wed, 27 Mar 2024 14:31:00 -0700")
References: <20240327213108.2384666-1-yuanchu@google.com>
	<20240327213108.2384666-2-yuanchu@google.com>
Date: Tue, 09 Apr 2024 14:50:42 +0800
Message-ID: <875xwr81x9.fsf@yhuang6-desk2.ccr.corp.intel.com>
User-Agent: Gnus/5.13 (Gnus v5.13)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=ascii

Yuanchu Xie <yuanchu@google.com> writes:

> When non-leaf pmd accessed bits are available, MGLRU page table walks
> can clear the accessed bit and promptly ignore the accessed bit on the
> pte because it's on a different node, so the walk does not update the
> generation of said page. When the next scan comes around on the right
> node, the non-leaf pmd accessed bit might remain cleared and the pte
> accessed bits won't be checked. While this is sufficient for
> reclaim-driven aging, where the goal is to select a reasonably cold
> page, the access can be missed when aging proactively for measuring the
> working set size of a node/memcg.
>
> Since force_scan disables various other optimizations, we check
> force_scan to ignore the non-leaf pmd accessed bit.
>
> Signed-off-by: Yuanchu Xie <yuanchu@google.com>
> ---
>  mm/vmscan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 4f9c854ce6cc..1a7c7d537db6 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -3522,7 +3522,7 @@ static void walk_pmd_range(pud_t *pud, unsigned long start, unsigned long end,
>  
>  		walk->mm_stats[MM_NONLEAF_TOTAL]++;
>  
> -		if (should_clear_pmd_young()) {
> +		if (!walk->force_scan && should_clear_pmd_young()) {
>  			if (!pmd_young(val))
>  				continue;

Sorry, I don't understand why we need this.  If !pmd_young(val), we
don't need to update the generation.  If pmd_young(val), the bloom
filter will be ignored if force_scan == true.  Or do I miss something?

--
Best Regards,
Huang, Ying