Received-SPF: pass (google.com: domain of linux-kernel+bounces-136264-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-379-gabd37849b7-fm-20240408.001-gabd37849
Precedence: bulk
MIME-Version: 1.0
Message-Id: <96b55a64-2bcf-44da-a728-ae54e2a73343@app.fastmail.com>
In-Reply-To: 
 <CAFhGd8ohK=tQ+_qBQF5iW10qoySWi6MsGNoL3diBGHsgsP+n_A@mail.gmail.com>
References: <20240408075052.3304511-1-arnd@kernel.org>
 <20240408143623.t4uj4dbewl4hyoar@quack3>
 <CAFhGd8ohK=tQ+_qBQF5iW10qoySWi6MsGNoL3diBGHsgsP+n_A@mail.gmail.com>
Date: Tue, 09 Apr 2024 07:54:47 +0200
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Justin Stitt" <justinstitt@google.com>, "Jan Kara" <jack@suse.cz>
Cc: "Arnd Bergmann" <arnd@kernel.org>, linux-fsdevel@vger.kernel.org,
 "Mike Marshall" <hubcap@omnibond.com>,
 "Alexander Viro" <viro@zeniv.linux.org.uk>,
 "Christian Brauner" <brauner@kernel.org>,
 "Martin Brandenburg" <martin@omnibond.com>, devel@lists.orangefs.org,
 "Vlastimil Babka" <vbabka@suse.cz>, "Kees Cook" <keescook@chromium.org>,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [RESEND] orangefs: fix out-of-bounds fsid access
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 8, 2024, at 23:21, Justin Stitt wrote:
> On Mon, Apr 8, 2024 at 7:36=E2=80=AFAM Jan Kara <jack@suse.cz> wrote:
>> Frankly, this initializer is hard to understand for me. Why not simpl=
e:
>>
>>         buf->f_fsid[0] =3D ORANGEFS_SB(sb)->fs_id;
>>         buf->f_fsid[1] =3D ORANGEFS_SB(sb)->id;
>>
>
> +1 for this idea, seems easier to read for me.

Yes, good idea, I'll send this as v2 after my next round
of build testing.

      Arnd