Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp1817362lqe; Tue, 9 Apr 2024 00:43:47 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXsIEQ9O6BPjk7OnUvHykEFOOjZB6KyXvxhTBmU3caxrH62W4YIQqF8ckS1F4/JiEL1kfK47qNKGWVT7w/OdJDVu3MWiVl5QWOyN/Sdig== X-Google-Smtp-Source: AGHT+IE2o9sVyHtNIPWstvGj6eH3mFJa0aqCSJYLyd5JpTuU48yFh2WgHvAEXzRlNZTWj0f5etP6 X-Received: by 2002:a17:902:e945:b0:1e4:363b:1d42 with SMTP id b5-20020a170902e94500b001e4363b1d42mr5087233pll.3.1712648627517; Tue, 09 Apr 2024 00:43:47 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712648627; cv=pass; d=google.com; s=arc-20160816; b=b5lM6BF70QXD76BxqkzvA76qomzvMHrwDjqEYjMeVwG7q90bxCJHEuaQATYjPZT36z FxF8LSEiJRCHhTNpfgj+EWR9MNj0AV+gafZejmnDm2ynYkNYaC2Vu15UMZon4A2oUNoX H3IAAhnG64HtFd0hfeluFkXOYIn4ViD7V4FBadorzbgEynZBfDZkFdqrxjw003PRjxQ/ o3vhOnnJxl0zjAdo2C1tSLq9Vx39bFPa/B5QF1U3UWZpe+0m3Y0DgZDhuuEns2ATdWyN XEj/2wxNYZDGmZtVjBLgf2yGmGkPkoPaSw0wFeIYf2EbYy7NPkk4zTPULvA6Ud9jjxXH ZxAQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=arqq0gGTSQSzvYcmcny09G7FBRrACeMLaQtHwD/pOao=; fh=yN6lJAoPNKuQRMGE0OqfTl/02IQYa99vMx483TE6KS8=; b=xKgpPTaHTkKmhXaHENgOoaxFXKJOu3tH/1cZPsrJmX7HBU+PvkE+331PQ9QjqSlC/c 757bPmkBUN7fXPqXMcXuhowws/bMX/K41YaUbtFjrZubB5gvGeu7nwpK9m2H8NWxrQPR sUWRTLgmBWss1yk4b8lfjslpuHfcrzg9SAQkqx6JP3FeMgwdyXb4qpQqf9+PEHDxJoEk ETcPPU0kHNt4rl4XVjy6y1i6NUIkHQxa6AOlX4FvJUWldsDYJiIyQKM8UzzwzLugNiOA kIMwVsPzbtr0YIosLnbXJ3geD4L9nPTu2RyyzahuHIx7MrwbvW3A1zvSXx3MoEhxXl9O bt9w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="VkdEZ/t9"; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-136373-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-136373-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id u16-20020a17090341d000b001e0cdc908b1si8197882ple.312.2024.04.09.00.43.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 00:43:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-136373-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="VkdEZ/t9"; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-136373-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-136373-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id A863FB236B6 for ; Tue, 9 Apr 2024 07:36:52 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 845687CF29; Tue, 9 Apr 2024 07:36:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VkdEZ/t9" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10B707CF0F for ; Tue, 9 Apr 2024 07:36:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712648192; cv=none; b=I+T0rmSimYqc0tXDIQLgLt0s8PYj9ycBUMIRyJzncDPabqwL7JR2HmXvO/lgu5aSbrQrFMgX75qCB2Z8/ZYIjmbgEXIRGj/3y8brodD4yQ831mF7D2syzvcSEO6BzP7sL1TA3Vfp/izSvkENH1D583BoGvxRwJqLozxywKndpuY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712648192; c=relaxed/simple; bh=FztzRiNs2LeBHnyVnQtBC0HGinFklYs8Ho0bq3gR9uQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JzgXs6mdnWH7mgGZtliBFCL52jW8WIvxNrGYsHpykNvzHdPxEthdbDkTMJ65AllDOrETcbdt4hgVWN+w7+1oN/O89meB/mO5SfI7mVT290ZYb6R1pRvyo37HZ6tvlYKfSfLCagrSAW6dDI8GZxOIzZpX3ILWkhW+9/gaAocWw5s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=VkdEZ/t9; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712648189; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=arqq0gGTSQSzvYcmcny09G7FBRrACeMLaQtHwD/pOao=; b=VkdEZ/t9iOpYDqHxB0CzkEnSg4BbEx2UcpaTzjILGmLRdz4IJWuV5quGLq4NSVvfL04O+m Egu/nLH+JydrWSOpryFPVNOWgTuH4r9hcRWwoE8RfOHfSCQ/Pj+UXwBIvMyh1KzHLyBEDl oSX4WGZih24z7kMJKC2zxlkyU6hBmPk= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-225-I5RsCZ6LMj66mZuciEvReA-1; Tue, 09 Apr 2024 03:36:28 -0400 X-MC-Unique: I5RsCZ6LMj66mZuciEvReA-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-516d92389e0so1933816e87.3 for ; Tue, 09 Apr 2024 00:36:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712648187; x=1713252987; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=arqq0gGTSQSzvYcmcny09G7FBRrACeMLaQtHwD/pOao=; b=CmyxaLd1OzG3DGvZ8WXFcFtJp3MiWWsj2N3UmUUL2IYfew6++9QfV1x7YCbiJJUPIO 1tdCYKHHQCSOcQ4+yNtwaHbZ8VoNGvpxNVDiIbOdyy/lgLMfcYzzjZKfiuI/5K65CF9M 1k1AoaMzJ9nJlCtrs9qWtNGcaG+Bt4T9YZwDg9hMc5ojoPh6T6h4XLCaPOongRo5l+B7 Hijtb6o3eHGx5LQ/r7Rk66jA7qpqGPB1dOm2xjpobywrTPBaPJtbR3MbY4Nwc1sZ/F3X rNJLkusKqrl/hu9KdWYJES5PiwSsRYGl+gBoQG7/tcEyPIkeupbYiMKSwnnBMxt4MsGa prkw== X-Forwarded-Encrypted: i=1; AJvYcCU4yp56PltViOpHcrKbTrx4v95+eHKmnT5gZasvhgO0dKiZX2DYvo1cgSmURzb5aghPB6qEHPYitc4SXGKITGjA9VtrunTIjuwQKLA1 X-Gm-Message-State: AOJu0YwqVFXfTmeSYIn7BXPs/T8e5TWBTEd30aD49/LOMgAgPybZjALJ LlsCzcDyI6IRVsKHwnPdzWCKy88edrzLroyaVn3t1kCk2JHA5gNpj9zPXAyZ2/3QEsha+lO745F l+jdZh2dJIoQ4p1y9BVmPzyi7xZ1lz2gTNmM6M+SujnSQQMK//dR/DUoKOOhG/A== X-Received: by 2002:a19:8c5c:0:b0:516:cf0a:9799 with SMTP id i28-20020a198c5c000000b00516cf0a9799mr7943795lfj.64.1712648186817; Tue, 09 Apr 2024 00:36:26 -0700 (PDT) X-Received: by 2002:a19:8c5c:0:b0:516:cf0a:9799 with SMTP id i28-20020a198c5c000000b00516cf0a9799mr7943775lfj.64.1712648186436; Tue, 09 Apr 2024 00:36:26 -0700 (PDT) Received: from ?IPV6:2003:cb:c70a:be00:a285:bc76:307d:4eaa? (p200300cbc70abe00a285bc76307d4eaa.dip0.t-ipconnect.de. [2003:cb:c70a:be00:a285:bc76:307d:4eaa]) by smtp.gmail.com with ESMTPSA id s7-20020adff807000000b00343d6c7240fsm10696224wrp.35.2024.04.09.00.36.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Apr 2024 00:36:25 -0700 (PDT) Message-ID: Date: Tue, 9 Apr 2024 09:36:24 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 4/7] mm: swap: Update get_swap_pages() to take folio order To: Ryan Roberts , Andrew Morton , Matthew Wilcox , Huang Ying , Gao Xiang , Yu Zhao , Yang Shi , Michal Hocko , Kefeng Wang , Barry Song <21cnbao@gmail.com>, Chris Li , Lance Yang Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240408183946.2991168-1-ryan.roberts@arm.com> <20240408183946.2991168-5-ryan.roberts@arm.com> Content-Language: en-US From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240408183946.2991168-5-ryan.roberts@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 08.04.24 20:39, Ryan Roberts wrote: > We are about to allow swap storage of any mTHP size. To prepare for > that, let's change get_swap_pages() to take a folio order parameter > instead of nr_pages. This makes the interface self-documenting; a > power-of-2 number of pages must be provided. We will also need the order > internally so this simplifies accessing it. > > Reviewed-by: "Huang, Ying" > Signed-off-by: Ryan Roberts > --- Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb