Received-SPF: pass (google.com: domain of linux-kernel+bounces-136393-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240405144304.1223160-1-arnd@kernel.org>
In-Reply-To: <20240405144304.1223160-1-arnd@kernel.org>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Tue, 9 Apr 2024 09:52:01 +0200
Message-ID: <CAMuHMdUPX+Tx9y3AGFXgVM8G0YkSLgmmNUPCQCX8L9Q_kg5muA@mail.gmail.com>
Subject: Re: [PATCH] [v3] parport: mfc3: avoid empty-body warning
To: Arnd Bergmann <arnd@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Arnd Bergmann <arnd@arndb.de>, 
	Sudip Mukherjee <sudipm.mukherjee@gmail.com>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Arnd,

Thanks for your patch!

On Fri, Apr 5, 2024 at 4:43=E2=80=AFPM Arnd Bergmann <arnd@kernel.org> wrot=
e:
> From: Arnd Bergmann <arnd@arndb.de>
>
> on m68k builds, the mfc3 driver causes a warning about an empty if() bloc=
k:
>
> drivers/parport/parport_mfc3.c: In function 'control_pc_to_mfc3':
> drivers/parport/parport_mfc3.c:106:37: warning: suggest braces around emp=
ty body in an 'if' statement [-Wempty-body]
>
> Remove it in favor of a simpler comment.
>
> Acked-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> Link: https://lore.kernel.org/lkml/20230727122448.2479942-1-arnd@kernel.o=
rg/

Why the Link-tag, pointing to v2?

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

For the actual patch:
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>

Gr{oetje,eeting}s,

                        Geert

--=20
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
                                -- Linus Torvalds