Received-SPF: pass (google.com: domain of linux-kernel+bounces-136407-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Tue, 9 Apr 2024 10:02:20 +0200
From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Arun.Ramadoss@microchip.com
Cc: andrew@lunn.ch, olteanv@gmail.com, davem@davemloft.net,
	Woojung.Huh@microchip.com, pabeni@redhat.com, edumazet@google.com,
	f.fainelli@gmail.com, kuba@kernel.org, kernel@pengutronix.de,
	dsahern@kernel.org, san@skov.dk, willemb@google.com,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	horms@kernel.org, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net-next v4 6/9] net: dsa: microchip: dcb: add special
 handling for KSZ88X3 family
Message-ID: <ZhT2DEowBo4c46_I@pengutronix.de>
References: <20240408074758.1825674-1-o.rempel@pengutronix.de>
 <20240408074758.1825674-7-o.rempel@pengutronix.de>
 <7f0684fb1729dafc92f8b81ce81f10c91385c0c2.camel@microchip.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <7f0684fb1729dafc92f8b81ce81f10c91385c0c2.camel@microchip.com>

Hi Arun,

On Mon, Apr 08, 2024 at 04:26:34PM +0000, Arun.Ramadoss@microchip.com wrote:
> Hi Oleksij,
> > + * Return: 0 on success, or a negative error code on failure
> > + */
> > +static int ksz88x3_port0_apptrust_quirk(struct ksz_device *dev, int
> > port,
> > +                                       int reg, u8 data)
> > +{
> > +       u8 port1_data;
> 
> why can't we have some common reference, because it is somewhat
> confusing. function name is port0, but apptrust config is for port1 and
> u8 port1_data. atleast instead of port1_data, port0_data, we can have
> variable name as data, since they are handled in two different
> functions. 

Ack, I renamed variables and functions to be more in sync with the
documentation and add defines for ports

Is it possible to add this erratum to the chip errata documentation?

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |