Received-SPF: pass (google.com: domain of linux-kernel+bounces-136445-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <a5595ba92a3d65a222398824b09d7d37.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20240306180435.1033052-1-catalin.popescu@leica-geosystems.com>
References: <20240306180435.1033052-1-catalin.popescu@leica-geosystems.com>
Subject: Re: [PATCH next] clk: rs9: fix wrong default value for clock amplitude
From: Stephen Boyd <sboyd@kernel.org>
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, bsp-development.geo@leica-geosystems.com, m.felsch@pengutronix.de, Catalin Popescu <catalin.popescu@leica-geosystems.com>
To: Catalin Popescu <catalin.popescu@leica-geosystems.com>, mturquette@baylibre.com, Biju Das <biju.das.jz@bp.renesas.com>, Marek Vasut <marek.vasut+renesas@mailbox.org>
Date: Tue, 09 Apr 2024 01:19:44 -0700
User-Agent: alot/0.10

Quoting Catalin Popescu (2024-03-06 10:04:35)
> According to 9FGV0241 & 9FGV0441 datasheets, the default value
> for the clock amplitude is 0.8V, while the driver was assuming
> 0.7V.
>=20
> Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com>
> ---

Adding folks who seem to know about this than me.

-Stephen

>  drivers/clk/clk-renesas-pcie.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/clk/clk-renesas-pcie.c b/drivers/clk/clk-renesas-pci=
e.c
> index 53e21ac302e6..4c3a5e4eb77a 100644
> --- a/drivers/clk/clk-renesas-pcie.c
> +++ b/drivers/clk/clk-renesas-pcie.c
> @@ -25,10 +25,12 @@
>  #define RS9_REG_SS_AMP_0V7                     0x1
>  #define RS9_REG_SS_AMP_0V8                     0x2
>  #define RS9_REG_SS_AMP_0V9                     0x3
> +#define RS9_REG_SS_AMP_DEFAULT                 RS9_REG_SS_AMP_0V8
>  #define RS9_REG_SS_AMP_MASK                    0x3
>  #define RS9_REG_SS_SSC_100                     0
>  #define RS9_REG_SS_SSC_M025                    (1 << 3)
>  #define RS9_REG_SS_SSC_M050                    (3 << 3)
> +#define RS9_REG_SS_SSC_DEFAULT                 RS9_REG_SS_SSC_100
>  #define RS9_REG_SS_SSC_MASK                    (3 << 3)
>  #define RS9_REG_SS_SSC_LOCK                    BIT(5)
>  #define RS9_REG_SR                             0x2
> @@ -205,8 +207,8 @@ static int rs9_get_common_config(struct rs9_driver_da=
ta *rs9)
>         int ret;
> =20
>         /* Set defaults */
> -       rs9->pll_amplitude =3D RS9_REG_SS_AMP_0V7;
> -       rs9->pll_ssc =3D RS9_REG_SS_SSC_100;
> +       rs9->pll_amplitude =3D RS9_REG_SS_AMP_DEFAULT;
> +       rs9->pll_ssc =3D RS9_REG_SS_SSC_DEFAULT;
> =20
>         /* Output clock amplitude */
>         ret =3D of_property_read_u32(np, "renesas,out-amplitude-microvolt=
",
> @@ -247,13 +249,13 @@ static void rs9_update_config(struct rs9_driver_dat=
a *rs9)
>         int i;
> =20
>         /* If amplitude is non-default, update it. */
> -       if (rs9->pll_amplitude !=3D RS9_REG_SS_AMP_0V7) {
> +       if (rs9->pll_amplitude !=3D RS9_REG_SS_AMP_DEFAULT) {
>                 regmap_update_bits(rs9->regmap, RS9_REG_SS, RS9_REG_SS_AM=
P_MASK,
>                                    rs9->pll_amplitude);
>         }
> =20
>         /* If SSC is non-default, update it. */
> -       if (rs9->pll_ssc !=3D RS9_REG_SS_SSC_100) {
> +       if (rs9->pll_ssc !=3D RS9_REG_SS_SSC_DEFAULT) {
>                 regmap_update_bits(rs9->regmap, RS9_REG_SS, RS9_REG_SS_SS=
C_MASK,
>                                    rs9->pll_ssc);
>         }
>=20
> base-commit: 61996c073c9b070922ad3a36c981ca6ddbea19a5
> prerequisite-patch-id: 0000000000000000000000000000000000000000
> --=20
> 2.34.1
>