Received-SPF: pass (google.com: domain of linux-kernel+bounces-136446-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <ZhFJZoful6nEFskW@archie.me> <4d231dc4-0183-47e1-8bfa-3dd225bf8ea3@leemhuis.info>
 <904ffa11-592a-4336-aed2-d6370bb01896@collabora.com> <b99e51de-3622-4360-b69d-0fd911ea2a7d@leemhuis.info>
 <9012f8d5-302a-4840-815a-22b1e85fda5c@collabora.com> <c0193bca-ea80-49eb-ab26-8256d07078df@leemhuis.info>
In-Reply-To: <c0193bca-ea80-49eb-ab26-8256d07078df@leemhuis.info>
From: Daniel Martin <dmanlfc@gmail.com>
Date: Tue, 9 Apr 2024 18:22:18 +1000
Message-ID: <CAOyTmd2w+si-3OEyc4TGCn7ntiPyLGwBB6pswwcfDenj6BZSvg@mail.gmail.com>
Subject: Re: Fwd: Steam Deck OLED 6.8.2 nau8821-max fails
To: Linux regressions mailing list <regressions@lists.linux.dev>
Cc: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>, Bagas Sanjaya <bagasdotme@gmail.com>, 
	Venkata Prasad Potturu <venkataprasad.potturu@amd.com>, Liam Girdwood <lgirdwood@gmail.com>, 
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, 
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>, 
	Arun Gopal Kondaveeti <arungopal.kondaveeti@amd.com>, 
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, 
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, 
	Linux Sound System <linux-sound@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"

Why this was changed in the first place could do with some explaining,
as Valve had this implemented first in the SteamDeck (probably
collabora dev).
There were no other implementations out in the wild AFAIK & now with
the 6.8.x kernel, this issue has manifested because of an enum change.
I cannot for the life of me find an alternative topology file. Where
are the other implementations? Therefore it makes sense aligning to
what was done before on the Steam Deck OLED.
Alternatively, if Valve could provide an updated topology file for
6.8+ kernels, that would be great too.
Just my two cents from a humble OS dev, trying to make stuff work.


On Tue, 9 Apr 2024 at 18:04, Linux regression tracking (Thorsten
Leemhuis) <regressions@leemhuis.info> wrote:
>
> On 09.04.24 09:42, Cristian Ciocaltea wrote:
> > On 4/9/24 7:44 AM, Linux regression tracking (Thorsten Leemhuis) wrote:
> >> On 09.04.24 01:44, Cristian Ciocaltea wrote:
> >>> On 4/7/24 10:47 AM, Linux regression tracking (Thorsten Leemhuis) wrote:
> >>>> On 06.04.24 15:08, Bagas Sanjaya wrote:
> >>>>> On Bugzilla, Daniel <dmanlfc@gmail.com> reported topology regression
> >>>>> on Steam Deck OLED [1]. He wrote:
> >>>
> >>>>>> I'm adding this here, I hope it's the correct place.
> >>>>>> Currently the Steam Deck OLED fails with Kernel 6.8.2 when trying to initialise the topology for the device.
> >>>>>> I'm using the `sof-vangogh-nau8821-max.tplg` file from the Steam Deck OLED and associated firmware.
> >>>>> [1]: https://bugzilla.kernel.org/show_bug.cgi?id=218677
> >>>> A quick search made me find these posts/threads that foreshadow the problem:
> >>>>
> >>>> https://lore.kernel.org/lkml/20231219030728.2431640-1-cristian.ciocaltea@collabora.com/
> >>>> https://lore.kernel.org/all/a3357e1f-f354-4d4b-9751-6b2182dceea6@amd.com/
> >>>>
> >>>> From a quick look at the second discussion it seems a bit like we are
> >>>> screwed, as iiutc topology files are out in the wild for one or the
> >>>> other approach. So we might have to bite a bullet there and accept the
> >>>> regression -- but I might easily be totally mistaken here. Would be good
> >>>> in one of the experts (Venkata Prasad Potturu maybe?) could quickly
> >>>> explain what's up here.
> >>>
> >>> The problem here is that Steam Deck OLED provides a topology file which
> >>> uses an incorrect DAI link ID for BT codec.
> >>>
> >>> Patch [1] moves BT_BE_ID to position 2 in the enum, as expected by the
> >>> topology, but this is not a change that can be accepted upstream as it
> >>> would break other devices which rely on BT_BE_ID set to 3.
> >>>
> >>> The proper solution would be to update the topology file on Steam Deck,
> >>> but this is probably not straightforward to be accomplished as it would
> >>> break the compatibility with the currently released (downstream)
> >>> kernels.
> >>>
> >>> Hopefully, this sheds some more light on the matter.
> >>>
> >>> [1]: https://lore.kernel.org/all/20231209205351.880797-11-cristian.ciocaltea@collabora.com/
> >>
> >> Many thx, yes, this sheds some light on the matter. But there is one
> >> remaining question: can we make both camps happy somehow? E.g. something
> >> along the lines of "first detect if the topology file has BT_BE_ID in
> >> position 2 or 3 and then act accordingly?
> >
> > Right, I have this on my TODOs list but haven't managed to dig into it
> > yet. However, that would be most likely just another hack to be carried
> > on until the transition to a fixed topology is completed.
>
> Well, sure it's a hack, but the thing is, our number one rule is "no
> regressions" and the reporter apparently faces one (see start of the
> thread). So to fulfill this rule it would be ideal to have a fix
> available soonish or revert the culprit and reply it later together with
> the fix.
>
> Do we know which change that went into 6.8 caused this? Or is a revert
> out-of-the question as it will likely break things for other users that
> already upgraded to 6.8 and have a matching topology file? (/me fears
> the answer to the latter question is "yes", but I have to ask :-/)
>
> Ciao, Thorsten


-- 

Kind Regards,

Daniel
+61 (0)409611884