Received-SPF: pass (google.com: domain of linux-kernel+bounces-136449-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <bf713024-a96b-457a-9281-0406e6eb0828@collabora.com>
Date: Tue, 9 Apr 2024 11:25:31 +0300
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Fwd: Steam Deck OLED 6.8.2 nau8821-max fails
To: Daniel Martin <dmanlfc@gmail.com>
Cc: Linux regressions mailing list <regressions@lists.linux.dev>,
 Bagas Sanjaya <bagasdotme@gmail.com>,
 Venkata Prasad Potturu <venkataprasad.potturu@amd.com>,
 Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
 Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
 Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
 Arun Gopal Kondaveeti <arungopal.kondaveeti@amd.com>,
 Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
 Linux Sound System <linux-sound@vger.kernel.org>
References: <ZhFJZoful6nEFskW@archie.me>
 <4d231dc4-0183-47e1-8bfa-3dd225bf8ea3@leemhuis.info>
 <904ffa11-592a-4336-aed2-d6370bb01896@collabora.com>
 <b99e51de-3622-4360-b69d-0fd911ea2a7d@leemhuis.info>
 <9012f8d5-302a-4840-815a-22b1e85fda5c@collabora.com>
 <CAOyTmd3bpmb7t1fCMKPBXqhVtpdpKRvVq5EA7VXrnb-5Fs9ngQ@mail.gmail.com>
From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Content-Language: en-US
In-Reply-To: <CAOyTmd3bpmb7t1fCMKPBXqhVtpdpKRvVq5EA7VXrnb-5Fs9ngQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit


On 4/9/24 10:54 AM, Daniel Martin wrote:
> Why this was changed in the first place could do with some explaining,
> as Valve had this implemented first in the SteamDeck (probably collabora
> dev).
> There were no other implementations out in the wild AFAIK & now with the
> 6.8.x kernel, this issue has manifested because of an enum change.

The OLED model was launched with a 6.1-based kernel which relied on a
downstream implementation of the Vangogh SOF drivers.  Those were
mainlined by AMD way later, in v6.6, but during the upstreaming process
we ended up with this unfortunate ID assignments incompatibility.

> I cannot for the life of me find an alternative topology file. Where are
> the other implementations? Therefore it makes sense aligning to what was
> done before on the Steam Deck OLED.

I'm not aware of an alternative topology file available so far.
> Alternatively, if Valve could provide an updated topology file for 6.8+
> kernels, that would be great too.
> Just my two cents from a humble OS dev, trying to make stuff work.

I think that would be the long-term goal, so until that is figured out,
the easiest workaround to get this working with mainline is to apply the
enum change patch.

Regards,
Cristian