Received-SPF: pass (google.com: domain of linux-kernel+bounces-136491-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <04b9c7cb-e2ac-4dcf-8594-da101a98bc49@intel.com>
Date: Tue, 9 Apr 2024 16:36:45 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/2] iommu/vt-d: Remove caching mode check before devtlb
 flush
Content-Language: en-US
To: Lu Baolu <baolu.lu@linux.intel.com>, <iommu@lists.linux.dev>
CC: Kevin Tian <kevin.tian@intel.com>, Joerg Roedel <joro@8bytes.org>, "Will
 Deacon" <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>,
	<linux-kernel@vger.kernel.org>
References: <20240407144232.190355-1-baolu.lu@linux.intel.com>
 <20240407144232.190355-2-baolu.lu@linux.intel.com>
From: Yi Liu <yi.l.liu@intel.com>
In-Reply-To: <20240407144232.190355-2-baolu.lu@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WHVLdzVjalY3Ly9UWnExS2JVRUV5RXdleGlwMXd2eXZrUEtOaSs4Q2hLSGVP?=
 =?utf-8?B?eUtGdE9tMmszaU5ldmtUNEQ1QnR6aXpmTXYyRzdsaGp6MERTMEJRa05FcnJT?=
 =?utf-8?B?bUxLNHlHODZsRjl4N0pNWFpadDFmYmJyaTF4MFBPYnh4a25vQWFpNWFNUWta?=
 =?utf-8?B?S2gwNXhoRVF5RGx1bnhrbjgzTFUzS1o0TVQ3cHMydW8xQzJWM2FybUVDSHVY?=
 =?utf-8?B?ejkvb1ROUG1IWGlHZE5XcXJsd0RvWDV2dzJMVkE0ZkpHbitCWmx5cDNMUmZn?=
 =?utf-8?B?Ym5oOEtmL2FzM2s5Tmt3VSt3bTluM1hCbEJBMWk4U1hJWFNvdkp4QWpYckpV?=
 =?utf-8?B?bW9ObHBkNndoTGo1WUJkdXRPRWRYUmFaK2NLNEF5ODYvTGJpd2NqOVNabUdz?=
 =?utf-8?B?ZkJkblJhaUVEbm9yTTdrWGFlWmFyYVdsbnJzQ0Z0elFRdHhPMmZNMWh2Y0N6?=
 =?utf-8?B?cVh4bVhpR1ZWczVZQll5QktsQjg0a0xsV1hGRTlLeHJlR0FhdHBMcm4wN0o2?=
 =?utf-8?B?U0xwcHBGL3JPeVY2UUZzL2RXTDFvdGZlbE4xMUR5V1Q0RW9ESHdDWi9YdEh0?=
 =?utf-8?B?Ykc5QzY1VWQ5Y1JLNlZxZjVkVmttOFJVdlpBRTRyYXl1bXJ0Y1VTOUxneVZI?=
 =?utf-8?B?c0Q4dU9TeG5uT3pKcHgvTHQ4NnhtcXJucEJhcS9NVmdmaGdvbi9seFZHc2pq?=
 =?utf-8?B?djJVVUVBSTBmMVpJOUdkQUZrWG91YnlvVlZDVTlmUC8rbzJ4QzBrTHBQenVs?=
 =?utf-8?B?YXFyOHZoNXFjc0dSYmxsMjJycythWGtWc1BxUkpjeGFyczEyOVZMY3QxRDd1?=
 =?utf-8?B?cy9ZWFhzRnozSVZmL29iQ0ZHYmdKSUFMcno3SU9zUndtSnZ2Uno3S3NWSi80?=
 =?utf-8?B?dzMzUTR4OXZXcEpzaERCRmc1RzBnQS9TSTJMQlU3T0RLVGc0TndNTmVjT0hN?=
 =?utf-8?B?RDRuV3VYN2NDS2R6M1BOVnZ4Y3ppWnljUTB2elRWdVpIK2MzM0JCRjJLMnhK?=
 =?utf-8?B?T09sdm96UDFjOUpKMnpzYUJvRzNUT0taMkU5SXNybEZRK0s0dDlZMDMvNDFO?=
 =?utf-8?B?Rk9pdHZiQ29YTGlteWdJUUlVT24wTVZuVE1QT0swcnBlZlhING5IYXorMVpK?=
 =?utf-8?B?WUV4V3dIWWtaaTVxbDY0Y0hyVDhrd1hlSUp1Y2JzblRNOVJyb0RPOUFwWTh0?=
 =?utf-8?B?NEFpYUttQjB4UHk2SjNwYkV6Y0tPTlBQb2tWbkRBVmFhbDV2WmxyQVdpK0Zp?=
 =?utf-8?B?a0pMcisyVnp3bE9xMlZnODcxTGJIQk9EUHpnSXo3QUQ4c2xiL0dpQzFGd29o?=
 =?utf-8?B?eTFvZDlEZlRFUFRPeHhTRXN3M3BLU3ppNk52UVhUNVovS1pQUHFCQSthTWNX?=
 =?utf-8?B?SGpXemJmbnIvb2JFQ053enRiV2tIc205K21OQ2Y4SXdOZTNCaGhCVWd0WU5B?=
 =?utf-8?B?cEZTdys5UHFxUitSaGtsM2tMQjFtTktraXQrUU9COUJ2TFdTUk05cnBOTGV1?=
 =?utf-8?B?RldMN2RSMXp0K3dtQWYvT1NUUy9sSG5JODdjRG8yWXRCKzZONS9qQ0FmaEZV?=
 =?utf-8?B?YjliZ2NaWlYwaDIzakcrbDUvVlNSaDBXajM1UVEyRVlQem1EU08zeXR5Wkdp?=
 =?utf-8?B?YXVJU0doOHFaVnBydUh3VWRRa1FOOFh6eDRqOU94SHhPTDBNRzRPVktlQ3Nx?=
 =?utf-8?B?TDNDYWE4Ui85c3NWSEx2UklxRzR1OXFQMEN3ak1wVllzVllJYW5kVWJER0dE?=
 =?utf-8?B?czB5Mi9NTWxmNjY2bU1UckkvRHVSbndyL0UvdVJJcVBLc1Q0VloxeGo2Nksz?=
 =?utf-8?B?VHVvOTlvV21mRFBiRGhJMTBZcE15aFZGSjN3VC8vMFFMbjdHbkY4b2ZWZWtr?=
 =?utf-8?B?YWg2Tmtwa1lJTzQzTmVFVkcwbVROYXFhK0ZzekhsRmtaQjFrRy9rMlpzYlNa?=
 =?utf-8?B?VC9hVnNqalRlZ2RIMjRXWVlJM2RFby9UbDhtUUo5aTlFbHhkbkdybG5SNGVs?=
 =?utf-8?B?eTEwUEsxSEg0bFhMdVd0MUhQd2pOT2MzNUg4bjRjQ3RpNmdWUlcvUHZ3WnFh?=
 =?utf-8?B?cXM1Tm9vbHR0Z3BXUWxjQU16NStiNDlqemMwKzh1YXFwUmVQd204dmRWMUlJ?=
 =?utf-8?Q?qG5fcAsHFsY/sJEg+sMFvETl1?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 37657521-09ee-4ef2-ed2c-08dc586fb166
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7529.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2024 08:33:12.1994
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: l6NoMsAAHCIuiYSKlsaZEtUWVpuIP3RlPoyRG7XxWehT1Mi7rkZkF2fqsmTVoCmkT3iZExtjcDfAzKsSMImogg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR11MB5881
X-OriginatorOrg: intel.com

On 2024/4/7 22:42, Lu Baolu wrote:
> The Caching Mode (CM) of the Intel IOMMU indicates if the hardware
> implementation caches not-present or erroneous translation-structure
> entries except the first-stage translation. The caching mode is
> unrelated to the device TLB , therefore there is no need to check
> it before a device TLB invalidation operation.
> 
> Before the scalable mode is introduced, caching mode is treated as
> an indication that the driver is running in a VM guest. This is just
> a software contract as shadow page table is the only way to implement
> a virtual IOMMU. But the VT-d spec doesn't state this anywhere. After
> the scalable mode is introduced, this doesn't stand for anymore, as
> caching mode is not relevant for the first-stage translation. A virtual
> IOMMU implementation is free to support first-stage translation only
> with caching mode cleared.
> 
> Remove the caching mode check before device TLB invalidation to ensure
> compatibility with the scalable mode use cases.
> 
> Fixes: 792fb43ce2c9 ("iommu/vt-d: Enable Intel IOMMU scalable mode by default")
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> ---
>   drivers/iommu/intel/iommu.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
> index 493b6a600394..681789b1258d 100644
> --- a/drivers/iommu/intel/iommu.c
> +++ b/drivers/iommu/intel/iommu.c
> @@ -1501,7 +1501,7 @@ static void iommu_flush_iotlb_psi(struct intel_iommu *iommu,
>   	else
>   		__iommu_flush_iotlb_psi(iommu, did, pfn, pages, ih);
>   
> -	if (!cap_caching_mode(iommu->cap) && !map)
> +	if (!map)
>   		iommu_flush_dev_iotlb(domain, addr, mask);
>   }
>   

IMHO. this change can be merged with patch 01. And the reason is to make
the logic simple and clear.

> @@ -1575,8 +1575,7 @@ static void intel_flush_iotlb_all(struct iommu_domain *domain)
>   			iommu->flush.flush_iotlb(iommu, did, 0, 0,
>   						 DMA_TLB_DSI_FLUSH);
>   
> -		if (!cap_caching_mode(iommu->cap))
> -			iommu_flush_dev_iotlb(dmar_domain, 0, MAX_AGAW_PFN_WIDTH);
> +		iommu_flush_dev_iotlb(dmar_domain, 0, MAX_AGAW_PFN_WIDTH);
>   	}
>   
>   	if (dmar_domain->nested_parent)

you can also move the iommu_flush_dev_iotlb() call out of the iommu_array 
loop since it does not require checking iommu cap.

-- 
Regards,
Yi Liu