Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp1872893lqe; Tue, 9 Apr 2024 03:03:11 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXIrB6hwd1DEVD1akT6jj3CpzJdXWVImR++kkzrAFkzXl2TTIo0Luk1/8NnY/fVXckhfP9Y5x6XxFbfqb1wYj3EVtFqCWuf9Fqt26ceTg== X-Google-Smtp-Source: AGHT+IG7I1FQ5j81we1/eK/JXlBQOTZWQV/Hu8fUVC9pjOBguspPTykbCXM+we5STEcp05HpK/XI X-Received: by 2002:a17:902:6b08:b0:1e4:40a8:b654 with SMTP id o8-20020a1709026b0800b001e440a8b654mr3865626plk.27.1712656991351; Tue, 09 Apr 2024 03:03:11 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712656991; cv=pass; d=google.com; s=arc-20160816; b=qfrsWIpYfUdvkV+ZG1HGYt7MGx3UwfCf+XdknNu8+rHIXMZLvkQExXz6oQ3Nw4LkR+ 7t2yc0EIM7IOjshw/aS7yWxd6W4j3eb/f22x0IViyZ66mxVDBDHhm3Vg4MZBm+KuDHKc 09mayuo6OYOJtqEPyMs/WrtLogwJYXZ/AdvHyEXlv6fQxP7Uma54dXmFp+FALoXD7ED0 v34srly17ffvC5GWmplR4HycyTisKlh9bUBkEZStURaJSJ1XpA2a2bNPB8P52UEQhKEy kbCVilcipZyvngaVm7Y9+6/3IbVCMpBMQRSsH9MEfZXTEY5zP1sjLHj4PSv7ryp3gDaj e8LA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:cc:content-language :references:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id; bh=7at8/Z8glamSlvdlM7rvgtYPD6GYwb0gCKhYBf3VV1A=; fh=eWvgAbPix3tlssPN7mahit39FpPzM8PQEUalzPYWlAk=; b=hes1+TZuZEj5OD2Q3f5C9ePxdB09cNrJ9Hlb1APLvsINhmgMQMrHVoEZvy8o18otHl 6tdC+HKMrHBpbVDy+KQyjUcAKRKdgeXwwy3yM/U8fPSW4+hxg+N8hvhLzhYnwkxF2Nmf NZzfBdXYVn4HoR0rsoxILbbZpi4kCqX++d5+jOirknr3GxhbaurHbDboDc/jyvfInAf/ XenW3ogURGcDuanpwJOVMebnwgFwcHvEXzBJr9drhctz+LFGjZtYn9YzC5J8gfFNu3ee nHCq4UXvp/a7puRGtBQL1Wsm5tsU5yahmvUS6zeS/H63Ozgv4oAH8N0ENFXZZnS0ePaG SUXA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-136613-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-136613-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id i9-20020a170902cf0900b001e49bce9984si1071767plg.647.2024.04.09.03.03.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 03:03:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-136613-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-136613-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-136613-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id A3E2C283DC6 for ; Tue, 9 Apr 2024 10:03:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 391CE80BF0; Tue, 9 Apr 2024 10:03:05 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5C1B15339A; Tue, 9 Apr 2024 10:03:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712656984; cv=none; b=DVE1vfQN3vmXNM/p1h7f7H5UOHWd3fom12stDxdEA1i7hWzaOEXH2H3dHMNfK1yZK4jXog1gEMzRcDOQcNI8Jmi2l0om2aOT++akPkSvjf819/obehYLeLtCTX+1SUCVvAltqGX9gqeIzIxN06HwnvxqggScoYEKzsHsaBKQsqw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712656984; c=relaxed/simple; bh=dS7hsHyjh0MX9By0wsckkuyBat67T/GfrBNQX6U/xRA=; h=Message-ID:Date:MIME-Version:Subject:To:References:Cc:From: In-Reply-To:Content-Type; b=MCuCoycrJnWjcUCP3iD1hs+00Zwy2wS6nnUpD4uOga/6w5LmyWatgCNrMY24i1US9MDCOPOivEu6vLUa5zlgYdmeGpSkIB/eqIlwovkVAUw2t5JPVcsDlqthpcbkx4E4sH98CO/N4hARE/Y1Lz5XX3aHGEfpCYQZWSsTPT2lRSA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2FEC5DA7; Tue, 9 Apr 2024 03:03:33 -0700 (PDT) Received: from [10.57.52.202] (unknown [10.57.52.202]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4AF203F6C4; Tue, 9 Apr 2024 03:03:00 -0700 (PDT) Message-ID: <4949d61b-6b25-4433-bd2b-a50b4f22ff42@arm.com> Date: Tue, 9 Apr 2024 11:02:58 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 0/4] Add shellcheck beyond perf/tests To: Ian Rogers References: <20240409023216.2342032-1-irogers@google.com> Content-Language: en-US Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Kan Liang , Ravi Bangoria , Kajol Jain , Athira Rajeev , Oliver Upton , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org From: James Clark In-Reply-To: <20240409023216.2342032-1-irogers@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 09/04/2024 03:32, Ian Rogers wrote: > Add shellcheck to other locations of shell scripts, not just > tools/perf/tests. Fix issues detected by shellcheck. > > Ian Rogers (4): > perf build: Add shellcheck to tools/perf scripts > perf arch x86: Add shellcheck to build > perf util: Add shellcheck to generate-cmdlist.sh > perf trace beauty: Add shellcheck to scripts > > tools/perf/Build | 14 +++++++++++ > tools/perf/arch/x86/Build | 14 +++++++++++ > tools/perf/arch/x86/tests/Build | 14 +++++++++++ > tools/perf/arch/x86/tests/gen-insn-x86-dat.sh | 2 +- > tools/perf/perf-archive.sh | 2 +- > tools/perf/perf-completion.sh | 23 +++++++++++++------ > tools/perf/trace/beauty/Build | 14 +++++++++++ > tools/perf/trace/beauty/arch_errno_names.sh | 8 ++++--- > tools/perf/util/Build | 14 +++++++++++ > 9 files changed, 93 insertions(+), 12 deletions(-) > Reviewed-by: James Clark