Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp1892184lqe; Tue, 9 Apr 2024 03:50:18 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUvulNjutOByT5fmYRGLOneA6RRyxzVp1PXPDbTeN0enKCZLUna3sHevM/4Nls73adag11yoChrSFdQQ5bBj9NLCiDj2E2kzUYq7pt+tA== X-Google-Smtp-Source: AGHT+IF2LoWv0hLIdLq6fpkFwoKZPL8FFbHAXap/QEES+AHkooToTofvLcbtJED2L0WCYDg1tevA X-Received: by 2002:a17:906:d54a:b0:a51:d2de:c8f9 with SMTP id cr10-20020a170906d54a00b00a51d2dec8f9mr4118907ejc.8.1712659818534; Tue, 09 Apr 2024 03:50:18 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712659818; cv=pass; d=google.com; s=arc-20160816; b=IgNM5/fI0AhHHvXYxBsgZffYjX7dBaCNfoa+JnQNZIPwW4FIeEE3lFDmb7qOdHSe7z xRxyL6wlkle3o8WT6tuR0qmgE8UAArKYkhTvRJMVN6ZHx4Juft2crrn/nK6+VV/gbGZ2 /jC52/NtMp2Veb7+PNkths5yURSz4hY4qiaZvsNprxzjI/wJcX4nQRnpLNn/kAzUJW61 Fm8e92lcboPUtuDlkNRK166ht2T18rYziL9a8JvMtfE+WyZhcfXWvAM+KQM9NodE8eeF TTcdAk4OI1eibDKfQ76fuHMDjPRtlQwgaXlF+bJxOzA28JiHz1CND8A5p6QJcv+YWi6Y hAtQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :date:message-id:dkim-signature; bh=rNwfakQBVQWhFQ0CXLmxM/3VqRjCpvwxu8DU5cjjR9c=; fh=SIkql1VM+jAA06l+j7TrOzX68a4z0OkU8Ft7tnM0t3U=; b=WdT8L2sJRoZtqJi8dscv4CPH1p721oqGkPw8F4DNQRlbPSsYpKqURxtz+NfcAkanaO tDdL/1WipoH0rTWxVPkZcq8/TNtSyk4caDCyR9QMI8L5LDFf32yu8RJz28o5ql92PjZ+ k0zrWRvkXCD1/G/GtABkTM21kvpjnIDsGYxeRxgA97k8jp6u4vS7m508s63J3T4681yM 5hHZYDwQyUPnWNlLfu8wtqSTOOIOknOq8mn1PLzlD7XqKXNQPF9XA5cbz+RIzjKOOXUl 1sERPx4pvwF8pP6RrI3UOCRB2pz5KmJnPjLdmserNweN54TMFFdWqP4vMvci2ilP65QI 2+LQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="X/Vk6wZQ"; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-136703-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-136703-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id dm6-20020a170907948600b00a51d8604007si1817994ejc.640.2024.04.09.03.50.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 03:50:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-136703-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="X/Vk6wZQ"; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-136703-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-136703-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 1C5641F240FC for ; Tue, 9 Apr 2024 10:50:18 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CA852839F1; Tue, 9 Apr 2024 10:50:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="X/Vk6wZQ" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CF145FEED for ; Tue, 9 Apr 2024 10:50:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712659810; cv=none; b=N37OClLQlzjTmr1ZT/nozXAqYcH7ky60FtWurVTrLAQcfX8vgxrPWJnGrVS/WQQW+FMtVOkXhPzk8DM5IFgv/OCiGrtLbwP8E7ed09O3EHQ5rAKGzuIziSEAO31a0AYPnKETrwc/oEtcvsSu9SeTRdaLIvywwDOW18FISePO/mI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712659810; c=relaxed/simple; bh=j1H0ivfDynVYFDE47WFnHJ3KMhoShqrwLAxLTBTEe9A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=h/ELAyMIQpilPWEaRFPVI5bssVhLRNJS1i9Tqhz6n/s4y6yc73+GDjLf42MchOkcSfR+qTB851kZwB4hUeEyHOJl/7switRx0NncLfoVKhghYaoJYMqN/TJMzHgeAsse+DhXmtzaK/pbPrYDW+unwlrkAHJkf9DSkRlcrLUb3fM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=X/Vk6wZQ; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712659807; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=rNwfakQBVQWhFQ0CXLmxM/3VqRjCpvwxu8DU5cjjR9c=; b=X/Vk6wZQWPP9Vas4co9dUgSZVvswngGugIpe6ZxO8F4XZsy2vU//tLTD/8sW8/YUhGxw5W 9zZr1YJC2CLmKMdqCLPU+PLHStXq4iCLC3QeShnxmwqvt1P52PyOj0Vi2nB25KvEGmW3A1 4ScXgF4UkCnodO7Y+5YvEpSOO3DLg14= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-53-5z5svxO7O5qFT6nEOvbbyQ-1; Tue, 09 Apr 2024 06:50:06 -0400 X-MC-Unique: 5z5svxO7O5qFT6nEOvbbyQ-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-415591b1500so32163955e9.3 for ; Tue, 09 Apr 2024 03:50:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712659805; x=1713264605; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=rNwfakQBVQWhFQ0CXLmxM/3VqRjCpvwxu8DU5cjjR9c=; b=IUza6lrzuwnjbcMIMX5APHTSgZow8zMkSWADnLlN0Qe3CmKIc0fFC9KWaQtS1MGYkh srFmvDCFGJxt6rBfxefQPStsrwQST+TG7OjqoyAyrv2Fq193CMIDhdZJFZwFywtpb10U k7DejH6SxNc/onbzXmObAWb+IdpVze/nlK9a7GexfF2xez5lyqh1AIH2gk1I6bUBqjNh M7h1YuNbiVy33ZcQ31houwnQlwKmC43fhvqudavikc4h4NbjmIDZ+hpubZN1CJoNk4Qz QCBcaIJW4zNu1qQ7FylmJDV1KlASApycr2/JIHEeXNOgFX6alUtg3OAMvpfH73cjq8fJ UgPA== X-Forwarded-Encrypted: i=1; AJvYcCXU+gF7LGTdSkZn/rvD5nfX/PNbmq9fIxDDVHtE1QvYFdJKK9Vnuuzh6UTenTZCOTVVfXPyBo6hItqWqEvwJs0iPJ4kqVgT0/XUSQoU X-Gm-Message-State: AOJu0YyqxK8WrVkq6X2neIx0euH1gtg0y4IU7/0yiAPp13d4hqPBtRnA pLmta+ye+HnnVxgP9sbaTYLwYp+w4TLDBlV/xXHGNuyAp56Sr16ZNrvoLRxjq50O6RuPdotXn1I Ptq0QjMxV1AYGmvQiJfaJeqIFyR5porh8guASLC+kU6tepnN6PIYI0euBTmTgqg== X-Received: by 2002:a05:600c:1d96:b0:416:a5aa:c9af with SMTP id p22-20020a05600c1d9600b00416a5aac9afmr1006885wms.40.1712659805161; Tue, 09 Apr 2024 03:50:05 -0700 (PDT) X-Received: by 2002:a05:600c:1d96:b0:416:a5aa:c9af with SMTP id p22-20020a05600c1d9600b00416a5aac9afmr1006867wms.40.1712659804728; Tue, 09 Apr 2024 03:50:04 -0700 (PDT) Received: from ?IPV6:2003:cb:c70a:be00:a285:bc76:307d:4eaa? (p200300cbc70abe00a285bc76307d4eaa.dip0.t-ipconnect.de. [2003:cb:c70a:be00:a285:bc76:307d:4eaa]) by smtp.gmail.com with ESMTPSA id r7-20020a05600c458700b00416b035c2d8sm1239803wmo.3.2024.04.09.03.50.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Apr 2024 03:50:04 -0700 (PDT) Message-ID: <5b90db38-75fe-44fc-b4ca-55dd1b15724d@redhat.com> Date: Tue, 9 Apr 2024 12:50:03 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/9] mm/ksm: add ksm_get_folio To: alexs@kernel.org, Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Izik Eidus , Matthew Wilcox , Andrea Arcangeli , Hugh Dickins , Chris Wright References: <20240409092826.1733637-1-alexs@kernel.org> <20240409092826.1733637-2-alexs@kernel.org> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240409092826.1733637-2-alexs@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 09.04.24 11:28, alexs@kernel.org wrote: > From: "Alex Shi (tencent)" > > The ksm only contains single pages, so we could add a new func > ksm_get_folio for get_ksm_page to use folio instead of pages to save a > couple of compound_head calls. > > After all caller replaced, get_ksm_page will be removed. > > Signed-off-by: Alex Shi (tencent) > To: Andrew Morton > Cc: Izik Eidus > Cc: Matthew Wilcox > Cc: Andrea Arcangeli > Cc: Hugh Dickins > Cc: Chris Wright > Reviewed-by: David Hildenbrand Note that the more common way is to have RBs ets fist. Further, I haven't really seen "To:" that often :) -- Cheers, David / dhildenb