Received-SPF: pass (google.com: domain of linux-kernel+bounces-136711-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <9d389192-63c4-44e8-b863-6323b45aec0f@intel.com>
Date: Tue, 9 Apr 2024 12:58:33 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v9 7/9] libeth: add Rx buffer management
To: Alexander Lobakin <aleksander.lobakin@intel.com>
CC: "David S. Miller" <davem@davemloft.net>, Eric Dumazet
	<edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni
	<pabeni@redhat.com>, Alexander Duyck <alexanderduyck@fb.com>, Yunsheng Lin
	<linyunsheng@huawei.com>, Jesper Dangaard Brouer <hawk@kernel.org>, "Ilias
 Apalodimas" <ilias.apalodimas@linaro.org>, Christoph Lameter <cl@linux.com>,
	Vlastimil Babka <vbabka@suse.cz>, Andrew Morton <akpm@linux-foundation.org>,
	<nex.sw.ncis.osdt.itp.upstreaming@intel.com>, <netdev@vger.kernel.org>,
	<intel-wired-lan@lists.osuosl.org>, <linux-mm@kvack.org>,
	<linux-kernel@vger.kernel.org>
References: <20240404154402.3581254-1-aleksander.lobakin@intel.com>
 <20240404154402.3581254-8-aleksander.lobakin@intel.com>
 <45eb2bf1-e7b0-4045-82b3-93b9f81b7988@intel.com>
 <bebf1a1a-e4ec-4ec0-9d01-57a51bcf14ca@intel.com>
Content-Language: en-US
From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
In-Reply-To: <bebf1a1a-e4ec-4ec0-9d01-57a51bcf14ca@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Yll1Risxd1lDdVhNV05OZy9NT001eU9IbHdVbzJYRmNtUVl6b3JUOXhITTQ2?=
 =?utf-8?B?Tk9oa1VmbHNCV3VPMkk0NzdpTGlDQTRTaWx6R2paZUoyYjE0bDR6ZTJvYU1P?=
 =?utf-8?B?SjFCajJIdkxycUQ2WThrZEdVVTlzazJXTElzSjR5SDA0M2hiemMvdng4Mmd1?=
 =?utf-8?B?TjlLTS93R0cxWTAyUFRRZFBoQXZCU0syWTFKRjB1UUpmdnBHQk5qOUg5MVR3?=
 =?utf-8?B?RDB2aXgvdGV2M0VIQkVJNkVmZ2FxMmcwaEVybVFzOFEvelJHNUFDVTRiSHZE?=
 =?utf-8?B?NU5JQWtCVU9mMGRjWGlGU29lUDZQU0g4OUVQZWxTUWFKVVJDQU9DYzdiUFdG?=
 =?utf-8?B?QmRpS3ExY3QvYWE3QktoUHRwNCtyb3VRQ2xBV0pIdmNydjZlYmVjQll1WG9H?=
 =?utf-8?B?OUFRdUxISllWazFUV3BLM251QndoZDBNLzM1djRWZENjMi9waWJlVWI4SFhp?=
 =?utf-8?B?WHFlbUdsV2FESkhCczZ2ekN5T29JNHdQSi8wU2RGZkFvT0tPNVBZTmoxSm03?=
 =?utf-8?B?cTZ0ZmRsYlVTb3ZoTC84Zmd3RXJlVEllenI1TG84cXkvMkdsaXpPV05iVlhq?=
 =?utf-8?B?STZVUTlWWUpkSmw4VTBDWjI5a05XVGhyVVZEKzUyNG52WWY1U1BiRlpXRmpo?=
 =?utf-8?B?WjFzdmRoY2ZGTXBHTzRCczFLWENRckRFc2MvSjZUN1FpWjUvLzNuZlpPeWor?=
 =?utf-8?B?TjJ2M1c1MHFvK2dPcHRjMHAvbG9wSGdyeXdHeUltSTVobHdxNzRJbmV3eDB1?=
 =?utf-8?B?dGZHUkhaNWIxRjQ3QjAxbGtTWXlOUVY3M2VuN01ON0ZRNVkxYnJiOUxzVkZk?=
 =?utf-8?B?a3g3M2N0cGE3MXlseVJPaklodGJqclhZZ0gvQzVEbnM0c29BaFRza2IvMUVk?=
 =?utf-8?B?TWsybFdBTjk4MXFJMUlwbEt0TDA5M204ZjNpZDIwUkhJN2QwTVRrdEptekNi?=
 =?utf-8?B?bDdqSHduaXZHNFhkV24yTmd3T1hnMXYwVjdZUUJkT0tWdEYrMndNQ0pVWXRk?=
 =?utf-8?B?YkRacEN5eHBINlcyVjBYd3RybWRFcjBsNDRyRzVkdGdLSDZuQjkyMk9rRTlS?=
 =?utf-8?B?WlNBU0NmancyQzFPVG9vdVpnVFRwOUNYZlZPdEdxM3BpSUh6RDI0Tmk5TlVh?=
 =?utf-8?B?V2hhQ1BiSytFc014b0dWNUcyc2JFYW50TlRYMWNkT0JBeWlOZjgrTmdPVGpk?=
 =?utf-8?B?Y2xqMnBPd1hsM2FsTDBuenNJcWhWWnY5V2ZFVUk0Q2ZqemdPa1lmditEYzZJ?=
 =?utf-8?B?ZllOdVpabDc1d25OOUlTUEVWeTQ4Ylc4RUs0OXREVzVXcXlDTzRlVUtYVGcx?=
 =?utf-8?B?TTJtaVcxVkJFR08wTXM0bitVelBjcVU1SUNUcWpUOXNqL1hhZU1mVmNjWGY1?=
 =?utf-8?B?alBpZklpdlNiQXFFQWt5T2ZUSmRQbWIzOERhSlFaLzVFSzlmZ2JnWUZRT25z?=
 =?utf-8?B?UXZyMGt3VlpPUkpiaW8waWI5c3RKQW5vTU14dkswNjVaVTljQlhCYWZmY1kw?=
 =?utf-8?B?RG1zc09RK2pLRHVSUE1vK2czenNwbjFWRzRCblhHbTBKUmZJS3NyZFhRVWhS?=
 =?utf-8?B?M3ZNU1BZSFJJdUdrd3JsdnlKUHIwV3lJUnlvR2F4d2FLTXJiczFlVUd5bkQv?=
 =?utf-8?B?VVBNUU5CTXdLMWRmV3lvR1ZSOGRVMmIvU2IrdG9JcTdYN25xc2ZYY2tBNHNi?=
 =?utf-8?B?cGNNNGppdmlXUnJsMGNpQzFvSU5LUkxON1N1bXVXKzRVOFBjak9PenJSQ2RB?=
 =?utf-8?B?T1V3RVQwSHhDZHVIM1c3YU1hK2twYzhoMmw2cWhZNUw4cW9tdkk1UGRQa21j?=
 =?utf-8?B?UXl4SUpxMkpRYWM1Nnc3aDVUaUpiVHFQQmUvUjRJMy9JK2RsUndDcXJDdzZn?=
 =?utf-8?B?ajdUaU5QT2xWMWVNK0hpRUZPaDVackJwM092MnVWbGlFNEtSSFFGdXRFbzZX?=
 =?utf-8?B?TndvN1RYS0s3STRGUmx1YlRhenhqL290RHI3Z1FlS3RKVnpsdDg4TWlqN2xl?=
 =?utf-8?B?djlUWlM1S2l4Y2JuaStKWnJYT09pZ1E1c1REMFlpUGNnWExTTFMyZmo3R3Fs?=
 =?utf-8?B?djBFa2JGYktOMWtuV3IyY3FGNjZqUlBBVWl1Q1lxdVBSMll0dXMyMTJSMDZu?=
 =?utf-8?B?NTlyK1EwU3dQcHM5RzZhUmFkTUkzZ2xKd0RLdGt2TGc5ZDRZcnAvcXJPaU5W?=
 =?utf-8?B?T3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cc0fb801-486f-4c0e-78a8-08dc58840360
X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8102.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2024 10:58:39.6902
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ry0XP7iV9JslJmY4pUGFZcKfVuUoTrf+zratjQTQryQOEtyQWNv1zUa76LFWidXaGVHmn1HJstwy33uXk9pDot5DQ44l+xwr/+PZiMQgzQs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR11MB8770
X-OriginatorOrg: intel.com

On 4/8/24 11:09, Alexander Lobakin wrote:
> From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Date: Fri, 5 Apr 2024 12:32:55 +0200
> 
>> On 4/4/24 17:44, Alexander Lobakin wrote:
>>> Add a couple intuitive helpers to hide Rx buffer implementation details
> 
> [...]
> 
>>> +struct libeth_fqe {
>>> +    struct page        *page;
>>> +    u32            offset;
>>> +    u32            truesize;
>>> +} __aligned_largest;
>>> +
>>> +/**
>>> + * struct libeth_fq - structure representing a buffer queue
>>> + * @fp: hotpath part of the structure
>>> + * @pp: &page_pool for buffer management
>>> + * @fqes: array of Rx buffers
>>> + * @truesize: size to allocate per buffer, w/overhead
>>> + * @count: number of descriptors/buffers the queue has
>>> + * @buf_len: HW-writeable length per each buffer
>>> + * @nid: ID of the closest NUMA node with memory
>>> + */
>>> +struct libeth_fq {
>>> +    struct_group_tagged(libeth_fq_fp, fp,
>>> +        struct page_pool    *pp;
>>> +        struct libeth_fqe    *fqes;
>>> +
>>> +        u32            truesize;
>>> +        u32            count;
>>> +    );
>>> +
>>> +    /* Cold fields */
>>> +    u32            buf_len;
>>> +    int            nid;
>>> +};
>>
>> [...]
>>
>> Could you please unpack the meaning of `fq` and `fqe` acronyms here?
> 
> Rx:
> 
> RQ -- receive queue, on which you get Rx DMA complete descriptors
> FQ -- fill queue, the one you fill with free buffers
>    FQE -- fill queue element, i.e. smth like "iavf_rx_buffer" or whatever
> 
> Tx:
> 
> SQ -- send queue, the one you fill with buffers to transmit
>    SQE -- send queue element, i.e. "iavf_tx_buffer"
> CQ -- completion queue, on which you get Tx DMA complete descriptors
> 
> XDPSQ, XSkRQ etc. -- same as above, but for XDP / XSk
> 
> I know that rxq, txq, bufq, complq is more common since it's been used
> for years, but I like these "new" ones more :>
> 

Thank you, that sounds right. If you happen to sent v10, a bit of code
comment with this info would be useful ;)

>>
>> otherwise the whole series is very good for me, thank you very much!
>>
> 
> Thanks,
> Olek