Received-SPF: pass (google.com: domain of linux-kernel+bounces-136851-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 9 Apr 2024 13:13:32 +0100
From: Conor Dooley <conor@kernel.org>
To: Inochi Amaoto <inochiama@outlook.com>
Cc: michael.opdenacker@bootlin.com, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Chen Wang <unicorn_wang@outlook.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>, devicetree@vger.kernel.org,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: dts: sophgo: add initial Milk-V Duo S board
 device tree
Message-ID: <20240409-prevent-deepness-2d22bf009b16@spud>
References: <20240409064504.4010353-1-michael.opdenacker@bootlin.com>
 <IA1PR20MB49532A8D4294ADCE0C33A654BB072@IA1PR20MB4953.namprd20.prod.outlook.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="9NJ+1qh0mf0Ujp8a"
Content-Disposition: inline
In-Reply-To: <IA1PR20MB49532A8D4294ADCE0C33A654BB072@IA1PR20MB4953.namprd20.prod.outlook.com>


--9NJ+1qh0mf0Ujp8a
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 09, 2024 at 03:17:35PM +0800, Inochi Amaoto wrote:
> On Tue, Apr 09, 2024 at 08:45:04AM +0200, michael.opdenacker@bootlin.com =
wrote:
> > From: Michael Opdenacker <michael.opdenacker@bootlin.com>
> >=20
> > This adds initial support for the Milk-V Duo S board
> > (https://milkv.io/duo-s), enabling the serial port and
> > read-only SD card support, allowing to boot Linux to the
> > command line.
> >=20
>=20
> Hi Michael,
>=20
> I think your patch losts the board binding and have wrong compatiable.=20
> Also, the SD can have rw support with proper property. See link [1]=20
> (need 'disable-wp').

[1] doesn't go anywhere useful.

> I suggest you resubmitting this patch after applying clk patchs.=20
> This could reduce some unnecessary change. For now, you can just=20
> use the dts for huashan-pi (with changed memory size).

Why would using patched huashan-pi dts be more suitable than carrying
a local patch for duo-s devicetree? What am I missing?

Cheers,
Conor.

>=20
> [1]: https://lore.kernel.org/linux-riscv/IA1PR20MB4953B158F6F575840F3D426=
7BB7D2@IA1PR20MB4953.namprd20.prod.outlook.com/

--9NJ+1qh0mf0Ujp8a
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZhUw7AAKCRB4tDGHoIJi
0hxeAP9Gq5pqIE8VbwzobCLZkAoeBFVSPzoXf7wBfFedcwFlTgEA3f5KH2ThJh6z
E/9yUOzC5dwl7/X9hqNhekc6IjRtSgo=
=DmrY
-----END PGP SIGNATURE-----

--9NJ+1qh0mf0Ujp8a--