Received-SPF: pass (google.com: domain of linux-kernel+bounces-136867-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 9 Apr 2024 20:27:59 +0800
From: Inochi Amaoto <inochiama@outlook.com>
To: Conor Dooley <conor@kernel.org>, Inochi Amaoto <inochiama@outlook.com>
Cc: michael.opdenacker@bootlin.com, Rob Herring <robh@kernel.org>, 
	Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>, 
	Chen Wang <unicorn_wang@outlook.com>, Paul Walmsley <paul.walmsley@sifive.com>, 
	Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, devicetree@vger.kernel.org, 
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: dts: sophgo: add initial Milk-V Duo S board
 device tree
Message-ID:
 <IA1PR20MB49534E00CAE29D24F7D7E718BB072@IA1PR20MB4953.namprd20.prod.outlook.com>
References: <20240409064504.4010353-1-michael.opdenacker@bootlin.com>
 <IA1PR20MB49532A8D4294ADCE0C33A654BB072@IA1PR20MB4953.namprd20.prod.outlook.com>
 <20240409-prevent-deepness-2d22bf009b16@spud>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240409-prevent-deepness-2d22bf009b16@spud>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: IA1PR20MB4953:EE_|DM4PR20MB5728:EE_
X-MS-Office365-Filtering-Correlation-Id: 6cd9f83f-455e-4d7f-edfa-08dc58907424
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	YvrAjKfH7G8Bh2HBKidSop8Pv7nXaIsI3ZXs0Ftg1eOxaqWhCVHrUsV+Ia9D/3T5I/MZcc4eGymJDWL9FpJc8oXTNixugQ0AqFnT4PVxWt8WrrQv1gF2Ahl9v0OO09qWzsGpJzr9h02h+1BMeXVcZYpvgCLtc8gALHTmXd9lPvfn/kh0UsLgtvMR4Tern/RNeeUeyz8Dzur9IGt/NtkGVA07rGfBNZMdwy/H0mGGsBd+y3oPWNsbbUrIiOxQp6/UkVBMZY40UGpEW0d6yzsQLVy/o66TK1ac0oUe2/ZGhDmNfVbUNv1CKsVdvgmIH8tXpOHPRs9nsRFQOdNdwf/wZmx6L+3bzhm1nTzjsrxWWM/E8LBd7QD83iiKqnk+xGvzZe4htOJU9y5ZuhhYIjd8GHfq+a1Sdsn4Ltu6/EotzA4gSPfGn/H/Ub+U6BEZP3YPfHjG/iUYiJrFy9rh0eGXCTzIi45Jlz0hwnZM0T6iuEHFCcfsbQSzlHM0oYLMq0BEmQSmPLvG/+fKeEd8keq0BehQ6EbWX4n4JhdrN5Pzp+NKaHOW0qThvazkjq7e1R/hradILa5TTywQpICAsmBVWjME3abrcz4U0QGPYFCp/6H3W4ALdN2BvGYnOU2rEi5JReLoi+ucuGAmsf/DodKLDVhTMRjR2UntQNl8KbwPOP9FImNOaz9leYFo2GN7FFK2AH0gz2P2UO/AXyLoo97aXQ==
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?HQ8pwfvA4Lovrym3fYOr2INn0RX5O7i93Z9nY12aNVZMvQQLg3MPu9Wfl17a?=
 =?us-ascii?Q?cNshP9Mt7y5WLZCmwiFyqv43SoLGWAHX2kOeOGTbnhairDMXoD1EPyo7K2bZ?=
 =?us-ascii?Q?AR8U5PMdFt32wI/4D241x8AI9khSyczJosbkA//gH0Irj6G4uSc7xezSQalY?=
 =?us-ascii?Q?yUzfcEY5p8aLh7rzqxq/rpKXEfEkjy+wAM+WoFF4y3UqPRLD2QjULVKnjhzV?=
 =?us-ascii?Q?kwOI/LuDz0aKucPBBgCATeClH19afJrP364/nLUzS8473QvN0EfT8J8bos65?=
 =?us-ascii?Q?RwIh0nGu/ggcXKYxgz9iNXG3XCezoPTS3r4kYklNGI8qz8wFSMNWKFZLYQmJ?=
 =?us-ascii?Q?tG2RQ8PqLAK/fCzRo48QNXGr+/t2PMo0JLCDbj1Mq7frqoBb/Shhkb//5k55?=
 =?us-ascii?Q?NxZLCCBafZXIGnJx9SLlqS4gbQEubLBP/D3tfB9BsOvngDfitVlnt3IUgPfD?=
 =?us-ascii?Q?v2LkqNYEk5ma8BA5+bLVKsOBLadl9FbVfr+EzB2nu4PQS32AnJo4WbC1q913?=
 =?us-ascii?Q?rq59Or74wB367zn20oBJfcRLhuVo09qzRF+EFo9DAgqlOHrEVWH+97D+68ys?=
 =?us-ascii?Q?3/gphCKwwyeTB18YVdoDQwNn7dzu5iZ2zGH6vsS+KyccyTygsdgdmKrKGDrz?=
 =?us-ascii?Q?o7KFrlNK7fGn6aXATDQipkdp9b+UhhiDNMZmFWwIu0AvC3QemUPa9ytturyQ?=
 =?us-ascii?Q?/F8GMWsUx2oHFvLNgCi34ChyFmi6kAIVSb8NjgM2XRFPb9OXvXEi5AJN/+lS?=
 =?us-ascii?Q?yns+UJw+c2PPUQ2CGA+5RSQvYYVtOfU1c6ivDuXjOGZ21ADl8VEZoCit3jyD?=
 =?us-ascii?Q?6MC6+aFQtBkpJ4YYDw9117LDk+WIqy95zdjjmUKVGo2D1rQPpWvmPtK+bh7M?=
 =?us-ascii?Q?oLQEqytyBHX+dwLMzEQFLSVgnC8y5OUaTUI3r88ne/49J52hx5qI1mTvdnVt?=
 =?us-ascii?Q?Pe4YGQcduiVAw79tWcKZaecUmNWuuXlTDQF857rEQwhOjbPyMcsQRz0OLCBE?=
 =?us-ascii?Q?mkgnTpByA+Hs5YcY+JDtWWOMQYud6LXdmD+mLQiiW+dYr8uQa1Inlo+/c7fi?=
 =?us-ascii?Q?cACfq5lPjeG39B8QH2CA1JsdD/MzrB7G5K/6ApTBlwkFI1Dd+dbATCSPNsh5?=
 =?us-ascii?Q?2tkjHPNOHCDCC5hOqtFBQR1rZQK/bqwoec9Ziev9WfcHcP0xw25Cam5LnPD8?=
 =?us-ascii?Q?ZCzmog9WVFN6B5ECSQqp4lAqEnIapHSltUro70iRp1VBDE1+ZSPdkld+lUxt?=
 =?us-ascii?Q?VSg1lsuUZDLl75I3DKQN?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6cd9f83f-455e-4d7f-edfa-08dc58907424
X-MS-Exchange-CrossTenant-AuthSource: IA1PR20MB4953.namprd20.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2024 12:27:42.9467
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR20MB5728

On Tue, Apr 09, 2024 at 01:13:32PM +0100, Conor Dooley wrote:
> On Tue, Apr 09, 2024 at 03:17:35PM +0800, Inochi Amaoto wrote:
> > On Tue, Apr 09, 2024 at 08:45:04AM +0200, michael.opdenacker@bootlin.com wrote:
> > > From: Michael Opdenacker <michael.opdenacker@bootlin.com>
> > > 
> > > This adds initial support for the Milk-V Duo S board
> > > (https://milkv.io/duo-s), enabling the serial port and
> > > read-only SD card support, allowing to boot Linux to the
> > > command line.
> > > 
> > 
> > Hi Michael,
> > 
> > I think your patch losts the board binding and have wrong compatiable. 
> > Also, the SD can have rw support with proper property. See link [1] 
> > (need 'disable-wp').
> 
> [1] doesn't go anywhere useful.
> 

This is my fault, I copied the wrong url. The right patch is
https://lore.kernel.org/r/20240217144826.3944-1-jszhang@kernel.org.

> > I suggest you resubmitting this patch after applying clk patchs. 
> > This could reduce some unnecessary change. For now, you can just 
> > use the dts for huashan-pi (with changed memory size).
> 
> Why would using patched huashan-pi dts be more suitable than carrying
> a local patch for duo-s devicetree? What am I missing?
> 
> Cheers,
> Conor.
> 
> > 
> > [1]: https://lore.kernel.org/linux-riscv/IA1PR20MB4953B158F6F575840F3D4267BB7D2@IA1PR20MB4953.namprd20.prod.outlook.com/

I think you miss nothing. Using huashan-pi dts as a temporary 
solution is just because they are both CV181X series. Since
only a few peripherals are supported, it is also OK to use duo 
dts with local change. They're not significantly different.
This is also the reason I did not prepare any patch for the 
new board. (such as lichee RV NANO, duo 256).