Received-SPF: pass (google.com: domain of linux-kernel+bounces-136871-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Received-SPF: Pass (protection.outlook.com: domain of topic.nl designates
 40.69.19.60 as permitted sender) receiver=protection.outlook.com;
 client-ip=40.69.19.60; helo=westeu100-emailsignatures-cloud.codetwo.com; pr=C
Message-ID: <3ff7ab51-b671-4a77-9abd-f4683fcc744d@topic.nl>
Date: Tue, 9 Apr 2024 14:34:29 +0200
User-Agent: Mozilla Thunderbird
From: Mike Looijmans <mike.looijmans@topic.nl>
Subject: Re: [PATCH 1/2] dt-bindings: power: supply: ltc3350-charger: Add
 bindings
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 linux-pm@vger.kernel.org
CC: Conor Dooley <conor+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Rob Herring <robh@kernel.org>, Sebastian Reichel <sre@kernel.org>,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.3bc97c8f-843d-4e46-84f9-469b7ba2489d@emailsignatures365.codetwo.com>
 <20240408064905.20298-1-mike.looijmans@topic.nl>
 <a4a9f949-ecc7-4603-8c8b-90a1e309570a@linaro.org>
Content-Language: en-US, nl
Organization: Topic
In-Reply-To: <a4a9f949-ecc7-4603-8c8b-90a1e309570a@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0
X-Microsoft-Antispam-Message-Info-Original:
 KkHl9Xjkg/zEALNHNJE9P5Abpasc2Hyw0HRiWIi0pZTjHr6PL4G3XMETytTwSFnuKBRNJfvjo6EUIISNN1bwFJPhWcOwxWspxrX75xbMH1WthvyiZPaOgwTl4i67iTTGxTpl32/k1pB1Jr52OSOjs1q1iVArio0a74tjwG4y4Lm7Nl8Gp+OqCwQMA1uEfkkScZID2ptgd/ouypOy4hUfCXwL4D3ZqAl4h+6vSm0HVXZeRc6r1KsjbepJbxtl4/Is5m4x8pVJNtfBnKoM/OM6XboUj+ahpCmkPWlwGfedhFuRK7hTlxw+CxAKHOj3Jq2BOeUogVSU80kF8r/kNWqKuqgRbpBflu5MhBgmqg9vEdy71dP3YoEFenlhtrqsln/YUI0c9TMSkWCihoA3ghi90byFriQ4LY+3dSRFg00kS5FgPGhmw7T1kqHysUwcAFA9Uq7+Rzw4uizKUpOsoOVqzOggrlHGAN6RW/+qCJiuW2gbu+0cGq8Bcb8DyMJZCNwHJ+vfhHhZkMajMVk4AHkXhoXwD6gQRr0AZjcvnHK/KfdxyzwohbTo3JIXHvOf5PGMPfM2EzMj+i89u7B6c+cYHz+cx2DrpkLJ7JsquTXyK7iWGj2+NTXWTL4ATLXj201VK7jlKxNPHN0uwxEMFkYFBLGwv1z6il2ZyRurNttB7Nc=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8644.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(1800799015)(52116005)(366007)(38350700005);DIR:OUT;SFP:1102;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8302
X-CodeTwo-MessageID: f0f6f95e-04a7-49dd-bdbb-b7c5cf7be4af.20240409123434@westeu100-emailsignatures-cloud.codetwo.com
X-CodeTwoProcessed: true
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DB5PEPF00014B9A.eurprd02.prod.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3bbeca07-a488-41bf-3d29-08dc58916ad8
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	N33Dex8qwimty8y1PPH15Q0xRcm6jufimzRZPpxxiGrnTbJS5DLfo8bAn+XF9XmGqixQXm6P0YEf6NIgVSXYcxS8Sg/BCyrA+c8t7kmr7gO0S5iFMo8+pdY5TsPyyNxCvXEeonlM1Q+NJdEoptkmQzbFrmMCD2R8veItDSkNevz7CU5dlcZThAdNIcQIBYffGRLaWacGyBCtAu8GIDSob+EaOxXKBvI76yW+BcJNuKO1jzo4gbgjUwg770V7imfLhOA8ryIgWFjviqFMk+d8SMDojHC+QUGL48DfaescjIOJShNcxsj7Y/UqmFYft+/i+mgfpODP2e2lT2FrA2BbdRWoJYF4YawkmkyxBzlZgMx/xOAleZRDwX+XwXuVMWLoRLBTwgsqM3BTZ7XvUVxipyyjiRNV0svmAlUieNv1evIwQz9RZIvEdkQ9HX4+ye3ykBaHGglPzNi3qoJQ0PhzfdmdtetLh2h5eC6Jaao3tg5/ZDzyVYK+/lzRQnRG6YnSqoIg9pHDHMzTap+tZWj5+qz78hdHPA54lmHXKrnBypMrvcj5a9dsw42JyKoLsKlDWT0oDe3xGkpJGIklT5aI/iZiCmYxjqQeQmN4j4mM4hhX+XRTglxhj6fXR/wGfwbrxU5j/W8QEi45GzGxnDmczzLC0+mpu1SVRoZASMoGFl4IpiWQSw4fw/0MgtXTSpe9/wVjhmM7cOQUXIJZUu169g==
X-Forefront-Antispam-Report:
	CIP:40.69.19.60;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:westeu100-emailsignatures-cloud.codetwo.com;PTR:westeu100-emailsignatures-cloud.codetwo.com;CAT:NONE;SFS:(13230031)(1800799015)(376005)(82310400014)(36860700004);DIR:OUT;SFP:1102;
X-OriginatorOrg: topic.nl
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2024 12:34:36.4107
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 3bbeca07-a488-41bf-3d29-08dc58916ad8
X-MS-Exchange-CrossTenant-Id: 449607a5-3517-482d-8d16-41dd868cbda3
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=449607a5-3517-482d-8d16-41dd868cbda3;Ip=[40.69.19.60];Helo=[westeu100-emailsignatures-cloud.codetwo.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DB5PEPF00014B9A.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9152


Thanks for your feedback. Will fix them all, except see below.

I'll send a v2


On 09-04-2024 10:27, Krzysztof Kozlowski wrote:
..
>> +
>> +  lltc,rsnsc-micro-ohms:
>> +    description: Capacitor charger sense resistor in microohm.
>> +    minimum: 1000
>> +
>> +  lltc,rsnsi-micro-ohms:
>> +    description: Input current sense resistor in microohm.
>> +    minimum: 1000
> Looks like it is shunt-resistor-micro-ohms. Unless it is something
> different?

It's a shunt, but different and there's two of them (akin to the=20
ltc4162-l which has the same property with the same meaning). One to=20
measure input, one to measure charge current.

When the datasheet talks about "shunt" it means the resistor that can be=20
used to balance or discharge the caps. So I'd rather avoid the word=20
completely so users aren't tempted to put the wrong resistor value there.

The datasheet uses "rsnsi" and "rsnsc" whenever referring to these=20
resistors.


..


--=20
Mike Looijmans
System Expert

TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: mike.looijmans@topic.nl
W: www.topic.nl