Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp1954589lqe; Tue, 9 Apr 2024 05:52:47 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU0IkYh7Ea6GziQzwbXGXK16mYWxxaAUwmjRqrlm+htutFGpQu7C5JKTUuHlm9t0dYzn/U9laCAsrDMb67Y1gr1WUNBuvtzMa8MdwU83Q== X-Google-Smtp-Source: AGHT+IHkJMSLuSftixcTPl9mY/1lbF2zs2pytqRag5kzP2Jq/NHaLwrGQWoUcSFwTc8OBSgR3F37 X-Received: by 2002:a50:cdd4:0:b0:56e:2b31:b111 with SMTP id h20-20020a50cdd4000000b0056e2b31b111mr9280207edj.7.1712667167063; Tue, 09 Apr 2024 05:52:47 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712667167; cv=pass; d=google.com; s=arc-20160816; b=XtrPqAHcSdvKi0MoTOuCgP73xTYuu8o7ja9w+HHU8I/eDh10QE/fZPs82Lz8Rh0qNR aJ3SW3XMX7cloz0HgmJz0i2UTHGxwq5W2G0vXQEwhMKor+jABtQEKj9dN8UI3BzNpE8t 77Wsedh1KHhkybCyMXYtdXdSQuMK2EY1zOgQc6SF0tvCwxpiyswFW8zAOlQ3wwFKXCx0 BTcmQfg0Oyc74/p54IFyxZbcNlrHGJSEZoc1i5OreKlzRvNz8O14D8TEJ3SEbF8DvGfY 6pHi026+ifdO+w/pYoOsWbvXDncRM/BrDcKiPN+cLL6XblBMuwgbFgJGMPaCk74B72rP zPWw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date; bh=pAdz7cQhfGznm7umSll9NW7JRcSZF77NwVghKKYKusw=; fh=HSq/OUM0V6RvFNR3wHNon8yYnDkXonPX10xRbiBCAqI=; b=LDGGY6GvgoizNC2jmEW3Ystsb4AJeUVGFKJ4ugY46u1MDEvWrMGhGWzR5yOk54lDiR zBx2eEpiwB4oz/CH60nMJp3/w5CS/oIZZHtWvlSBnmVKxL84XBgf0/jnD2C7qAJrYGxu mY2KjrUbsyNWrFwyQ903EMuZPltaC1zZQ1IBoyWCs++Ws0apOUuO4QTujPzQI9t6ph6H Xg/mf/nt/IG+FhzEhSHlmmqfA2ubbxY/QSjeZzWh73k/xrG9qGF2fqsmR85OYYxBRZX5 bCKBbUnBqWdGwzvIdJiBgTrUM5GoO9XDhFW3BLsmlzP2YR+U8YUie75hWOLSZsns5Imj z6AQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-136892-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-136892-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id s10-20020a508d0a000000b0056e2b1d4456si4594255eds.220.2024.04.09.05.52.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 05:52:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-136892-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-136892-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-136892-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id C5A561F2497C for ; Tue, 9 Apr 2024 12:52:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 06B3112E1C4; Tue, 9 Apr 2024 12:52:35 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D75BB12DDA7; Tue, 9 Apr 2024 12:52:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712667154; cv=none; b=XQhlpjiMJIgBWWDWcfvNOmtZYtMTALLDr52FRHClYGPhYXE4L48HNxi2rpbB8Y1XZMyEkKFgdD8WahdRvYuGp/D7gocyCxXRHv7peKoCyLp5eYrGuHbik3G5MfWarKfCbZKBh0FtlnnZcUTRmgwmXx4adVNW3zykduroQImvFFI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712667154; c=relaxed/simple; bh=pAdz7cQhfGznm7umSll9NW7JRcSZF77NwVghKKYKusw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oALtNTyDJwQQ1QNv/NQ/vGEuv5p0TKJJtfObkC+ld4MxPN/BRbBZQNJI9xsaC7A0nH91S7OQZz08TdejVJS8/ks7s/NxrDCFux0E6Px1rNdp1Ek7nkyXD8ED3q6O0xg6ncRHSN0CcQ0Z3OK9swzc+1RAVefDRvWaRLliP0wmyQE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 578D1139F; Tue, 9 Apr 2024 05:53:02 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4E37D3F766; Tue, 9 Apr 2024 05:52:30 -0700 (PDT) Date: Tue, 9 Apr 2024 13:52:27 +0100 From: Sudeep Holla To: Peng Fan Cc: "Peng Fan (OSS)" , Cristian Marussi , Sudeep Holla , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , "devicetree@vger.kernel.org" , "imx@lists.linux.dev" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 3/6] firmware: arm_scmi: add initial support for i.MX BBM protocol Message-ID: References: <20240405-imx95-bbm-misc-v2-v2-0-9fc9186856c2@nxp.com> <20240405-imx95-bbm-misc-v2-v2-3-9fc9186856c2@nxp.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Apr 09, 2024 at 11:19:31AM +0000, Peng Fan wrote: > > ok, will add more comment in the patch for the commands. > No I meant add document/description similar to SCMI spec for each of these commands. Not just one line comment. For std protocols, we can refer spec, for these vendor protocols, just one like comment will not suffice. Describe in more details and hence the request for separate TXT file for that. Hope that is clear now, I have mentioned it several times already. -- Regards, Sudeep