Received-SPF: pass (google.com: domain of linux-kernel+bounces-136883-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Thomas Gleixner <tglx@linutronix.de>
To: Tony Luck <tony.luck@intel.com>, x86@kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 01/74] x86/cpu/vfm: Add/initialize x86_vfm field to
 struct cpuinfo_x86
In-Reply-To: <Zgr7vfS4ArMh4kWx@agluck-desk3>
References: <20240328163746.243023-1-tony.luck@intel.com>
 <20240328163746.243023-2-tony.luck@intel.com>
 <Zgr7vfS4ArMh4kWx@agluck-desk3>
Date: Tue, 09 Apr 2024 14:46:45 +0200
Message-ID: <871q7e7lfu.ffs@tglx>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

On Mon, Apr 01 2024 at 11:23, Tony Luck wrote:

> Refactor struct cpuinfo_x86 so that the vendor, family, and model
> fields are overlayed in a union with a 32-bit field that combines
> all three (together with a one byte reserved field in the upper
> byte).
>
> This will make it easy, cheap, and reliable to check all three
> values at once.
>
> Signed-off-by: Tony Luck <tony.luck@intel.com>

Reviewed-by: Thomas Gleixner <tglx@linutronix.de>

> ---
>  arch/x86/include/asm/processor.h | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h
> index 811548f131f4..4c5d166aa473 100644
> --- a/arch/x86/include/asm/processor.h
> +++ b/arch/x86/include/asm/processor.h
> @@ -108,9 +108,15 @@ struct cpuinfo_topology {
>  };
>  
>  struct cpuinfo_x86 {
> -	__u8			x86;		/* CPU family */
> -	__u8			x86_vendor;	/* CPU vendor */
> -	__u8			x86_model;
> +	union {
> +		struct {
> +			__u8	x86_model;
> +			__u8	x86;		/* CPU family */
> +			__u8	x86_vendor;	/* CPU vendor */
> +			__u8	x86_reserved;
> +		};
> +		__u32		x86_vfm;	/* combined vendor, family, model */
> +	};
>  	__u8			x86_stepping;
>  #ifdef CONFIG_X86_64
>  	/* Number of 4K pages in DTLB/ITLB combined(in pages): */