Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp1987972lqe; Tue, 9 Apr 2024 06:44:11 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVclZf44+y3pp3LisLg4F3pwa1SU/Q/nSecl5/md7iZXw8zAit9VbereDNsw1VpIudlORLVX1piRSlQuFKVQluCEBPmS2H+UF64Pg0ywA== X-Google-Smtp-Source: AGHT+IH2uD4IA7yeC7QyUzROkKiRBudyVl8rBpqjsMe2UVyOzckFWFITWPw7ACTA4GFsTX43EzBg X-Received: by 2002:a05:620a:ec2:b0:78d:6757:c16b with SMTP id x2-20020a05620a0ec200b0078d6757c16bmr4649221qkm.30.1712670250824; Tue, 09 Apr 2024 06:44:10 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712670250; cv=pass; d=google.com; s=arc-20160816; b=OC2+MU5ySGeHROQeDBAWWgJpggDwEp/INGdZLdIysUUS9H1vg6Bln5dgiFMLU+PmRv hC05lwrc/GUyJw71geJBS51lunXMU7HUNLnjP7TjPr1YRFrMtRD7VCFxMRF+oYJDq7Tz s7YoVPCuxw3tQKeGidbBxTz70RSlUqkOVd+JgULAPgHMMNmzup8nJLe+D15YmKU1Lry2 jmPOvOlaoaynP+Nrwvkdp9O6SqzqkwQ6h04+8fu+UQAectA3yFJAgtp9AHL33mo2gd4R UnLoLU84McjGR8+Qs75VGQjXWQ9kN09foxBFmy6+mTDRZsRaVZSE68dCv+ZlczrUHQBj NxHQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=3OdEIb7FQFvkNxScpdaCDp4TznDqBKRAFxUy8JZYRhU=; fh=Z/S/kqRcBE9JLk6khOelksdun1bWFubsn37nD5LYMY8=; b=MxRjdOWJSp0DcPPryrvD2+O8HyHDl2JpchNy8A7K1iUDe3wC1RrlQZYvX+0sLPzGv8 2/jymbdC2k75LB+YlKkytWgFILxAtMfk571iNVgOuwNcxcFpTdTWr887g7ht4uJT+2bN GGHEe3regzGiS8tvk/jeuUur5oNvs7EcFRXx2jTLU2lLejLZeqsA/s5zUw6wlLgXclTf IXo3R/DtOu2cUerRa8M0324MGSO86MHcEjXvWEqoDmQ0Wmwy+KaANM5v+FSxvdD0+rdA 8bAAsM4grwHSxVNSHpMeBN8tT9E/lhcbMHtljjhEDGbJC9w8zVr/fimc9/hnnHNIiumN NwOw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="gz9+bP/N"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-136990-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-136990-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id g17-20020ae9e111000000b0078d62c6fd35si5427779qkm.570.2024.04.09.06.44.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 06:44:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-136990-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="gz9+bP/N"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-136990-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-136990-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 8BA241C215DD for ; Tue, 9 Apr 2024 13:44:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C3545137752; Tue, 9 Apr 2024 13:39:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gz9+bP/N" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9171136E1A; Tue, 9 Apr 2024 13:39:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712669991; cv=none; b=JkoCTvv/wIo8ep5Gxx22yTT8uAs6LRFz1hX3p1H4hMigTPU4/G61qaKD12TOqSITbVhyMU+tPhQy5aCnOwyMLRaqqc1iIghsbbvzlpq72s+MeZW8uNC7GivEglVPnC35X3YMkfcqvOgVRuMTcScgaJU/agXRSxQvDrcjxTxcfV4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712669991; c=relaxed/simple; bh=NlCnClFQH/uZ929V7ZbiGAE/v+SqP5ye30qi4yMGgT4=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=pYTc8DJV0g4SoVmbAqHa9zgF4YMVwsy0nwJb1wvXpVORBntX5AOF3C4yA+DUm6ql333DQW3IbVO0bVB47a5m3zfOLPPa66sANVm66H8N/XxiNwGrcll+FLDrGH7oOUD76yLstSUUu/25jrlzOb0UxIHz33j4RR84zF1KIojEIOo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gz9+bP/N; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73B8DC43390; Tue, 9 Apr 2024 13:39:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712669990; bh=NlCnClFQH/uZ929V7ZbiGAE/v+SqP5ye30qi4yMGgT4=; h=From:To:Cc:Subject:Date:From; b=gz9+bP/NQQKA3q5/7+iA5EmQBknvdLRXCJqhSxDYKUnYOOXHQl7v4xCI76GZyaVPR t3S2pEJYWHinI58cNsT3RbjM7zqEdeMSSraZ7/BzG3u2l1743I34XsRFBPkVcGc3bC Y7rRjxR94vd0rmtvzFCEcdtkx8hcc3VS8t2j1eMJFVW/ENdMg4a3qudxJBQmr9KnYF d+DgY+UO7CK8zByRebkyddA+jIlCQ6zShKiVzMkZEsvb3j1WX2aR8WUkdrQAy2Cex0 HLlA/grRpTLYL5J/AYgQySKUTm6gOcejwYoqjNJJsGnlP810MZsFlzkVtVIVbZiFV+ sAwKfyMo5S0+g== From: Arnd Bergmann To: Jeffrey Hugo , Oded Gabbay , Jacek Lawrynowicz , Pranjal Ramajor Asha Kanojiya , Carl Vanderlip Cc: Arnd Bergmann , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] accel/qaic: mark debugfs stub functions as static inline Date: Tue, 9 Apr 2024 15:39:35 +0200 Message-Id: <20240409133945.2976190-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Arnd Bergmann The alternative stub functions are listed as global, which produces a build failure in some configs: In file included from drivers/accel/qaic/qaic_drv.c:31: drivers/accel/qaic/qaic_debugfs.h:16:5: error: no previous prototype for 'qaic_bootlog_register' [-Werror=missing-prototypes] 16 | int qaic_bootlog_register(void) { return 0; } | ^~~~~~~~~~~~~~~~~~~~~ drivers/accel/qaic/qaic_debugfs.h:17:6: error: no previous prototype for 'qaic_bootlog_unregister' [-Werror=missing-prototypes] 17 | void qaic_bootlog_unregister(void) {} | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/accel/qaic/qaic_debugfs.h:18:6: error: no previous prototype for 'qaic_debugfs_init' [-Werror=missing-prototypes] 18 | void qaic_debugfs_init(struct qaic_drm_device *qddev) {} | ^~~~~~~~~~~~~~~~~ Make them static inline as intended. Fixes: 5f8df5c6def6 ("accel/qaic: Add bootlog debugfs") Signed-off-by: Arnd Bergmann --- drivers/accel/qaic/qaic_debugfs.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/accel/qaic/qaic_debugfs.h b/drivers/accel/qaic/qaic_debugfs.h index ea3fd1a88405..05e74f84cf9f 100644 --- a/drivers/accel/qaic/qaic_debugfs.h +++ b/drivers/accel/qaic/qaic_debugfs.h @@ -13,8 +13,8 @@ int qaic_bootlog_register(void); void qaic_bootlog_unregister(void); void qaic_debugfs_init(struct qaic_drm_device *qddev); #else -int qaic_bootlog_register(void) { return 0; } -void qaic_bootlog_unregister(void) {} -void qaic_debugfs_init(struct qaic_drm_device *qddev) {} +static inline int qaic_bootlog_register(void) { return 0; } +static inline void qaic_bootlog_unregister(void) {} +static inline void qaic_debugfs_init(struct qaic_drm_device *qddev) {} #endif /* CONFIG_DEBUG_FS */ #endif /* __QAIC_DEBUGFS_H__ */ -- 2.39.2