Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp1991419lqe; Tue, 9 Apr 2024 06:50:08 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXmX86bPTcPVPR7ogHo9r//s3VtU5QzTAXt54Al/YuPZ7iauw2LYkTEO6w51X3yAWlZ0gtYMqhEYup/2Hkodf2ETca+9YW+dvEtTACwzg== X-Google-Smtp-Source: AGHT+IFyvHlEpjNPo4ZM2hMeP9LZeUNi0VQWXTLBRRqnb7xOPriTOYgC6+PQ58JsY3OnYJMikt4q X-Received: by 2002:a05:6a20:3241:b0:1a1:8c6a:ed7 with SMTP id hm1-20020a056a20324100b001a18c6a0ed7mr11806648pzc.44.1712670608552; Tue, 09 Apr 2024 06:50:08 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712670608; cv=pass; d=google.com; s=arc-20160816; b=NC2CDOgJjOBJD7ER6jQePt1haoSegV9/SrCIPIzBBHp1J1HzGNknZp0U21GdtceX1l yE4wyuFaJYKU0mZ33tpGTVf5es4iKx0AidZIJFtFiNMcM23KxJl2EGQPppLXKFckgOgC JbNpaApE3pBkUSJISa3d48DEt8tYO1T+X1iFrK7crwRJX4Wwk5e80xPxLjQ5UG6hboPZ HkS5+DBD0M2fNyLXKtlIlLu5Ha6c/3t7hDNs7WrjAYtURaFFXYRFsgU4W7QuFGeko734 GeglNEipuS4v9mu9xjCPxDm5Xmmz2Y5vzyqNC9yjDg9FKF3vi98uP+nzcF4tlZJ3Na2r e9ig== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=subject:message-id:references:in-reply-to:cc:to:from:mime-version :list-unsubscribe:list-subscribe:list-id:precedence :content-transfer-encoding:date:dkim-signature; bh=qAbCM27HOqjO0Z/ed7DdrT1CUbSPWXLZqKrIek0Q6S0=; fh=UCnsATx/bXz7GhcggqeN3cy+vazL6ifyOIo8feQJreo=; b=kjhuNFmamUTQHU/Xn5todfloTcffWQGHpndUu9a+2hd3hzsCWKoz+ROuEx8pcDW7bN SGABvqdifVSf+sOktXGRs3+QsWV1/+hddmDsyDk4AmFFjWxsj6EhjWQWjDoiUc5czffV zvaraHXbNtuwmCSLD3D95XJ2uZFA7jw7NkCIh/zy2Al+btBuQmuFtCOzU5xOHH3asS5B MVTxjQ9VGSgqA7ocatUMoHfFwnNGyTysZ7SHTO+l+7eFKI5IxtlAvuzdg28so5X33rIG bvgg1oplZwVNvpb9vtOoQvngbTmsL21hRzSTXpdf5E5uGIyJFV6bcQHTOjwIj9mFyxIj k7Uw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MLE4L7AA; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-136981-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-136981-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id r21-20020a63ce55000000b005dc507e8d15si8486979pgi.820.2024.04.09.06.50.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 06:50:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-136981-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MLE4L7AA; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-136981-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-136981-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id EEE0BB266AC for ; Tue, 9 Apr 2024 13:41:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E7C5A131E5C; Tue, 9 Apr 2024 13:38:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MLE4L7AA" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D3AA13173E; Tue, 9 Apr 2024 13:38:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712669936; cv=none; b=PFTKYiGHQ/+coxn1z+cD8qVUAzrH11RWVwDQ+ZIRGnYxNCt+zdYvoaERIP2e856p6Gpkrd1vB0o9S5CrMxAPCBeeVIhyIrZZnTTB7UayLUpbugksHdpncNJxPZxUFzt4UhL7BDHW5sENTBVa0nHNUd3mtefUu9ovp7nvltgv0sw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712669936; c=relaxed/simple; bh=bjFXS0RsfnGrGuGvSpuQ1Azl09QUNfG1I4fgBjCN/4Q=; h=Date:Content-Type:MIME-Version:From:To:Cc:In-Reply-To:References: Message-Id:Subject; b=ULeBBFjwnaRhhblzhe+vtKoiVTO4Xfe6OllgAeuhgVXlLt+4anibJabICzgg9ZhHZxcTcaIy2s13GJNy3sgp2yo1+yTwQtFGuKmihQM3sVoI3cqUorrCedury23CjvqSQUn3xrDmGE7imjylsMsoh+aRnfIjniJPsl+gIum2hEk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MLE4L7AA; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 86E9EC43390; Tue, 9 Apr 2024 13:38:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712669935; bh=bjFXS0RsfnGrGuGvSpuQ1Azl09QUNfG1I4fgBjCN/4Q=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=MLE4L7AA4udXHhLmWp3bq7pdOMWGWUfV7x1mUC7vw3qTQJcg+oOXh3/aInm2hTr6R ngRePtBRq8K61P+WZpPoz1bpEvbjNd6gFOZU6xRliH9auIgDNnDeNthbUPHHix3Foh RsP7QoY5ap6saJIJNfa9Ii4TcVMS5NANyiwD4DBxdnEauJ/i37zDIlK6gLClGCrUMT UvT+9kfTvuuX7CA8f6KuWNgLDaR100d2XLDhG2i3dWgoR6843gwEcf2culJrI/0wlS FA/wLshPDuecAMusTHQUJ3fa21snJ71wCLWa1pMuglAhLEzO8nK9ujmiTxCg6t85sX 2Yr790JRZjfFQ== Date: Tue, 09 Apr 2024 08:38:54 -0500 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Rob Herring To: Chukun Pan Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Conor Dooley , Heiko Stuebner , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski In-Reply-To: <20240408124005.182565-1-amadeus@jmu.edu.cn> References: <20240408124005.182565-1-amadeus@jmu.edu.cn> Message-Id: <171266958458.1032566.5437781512082910340.robh@kernel.org> Subject: Re: [PATCH 1/1] arm64: dts: rockchip: enable onboard spi flash for rock-3a On Mon, 08 Apr 2024 20:40:05 +0800, Chukun Pan wrote: > There is a mx25u12835f spi flash on this board, enable it. > > [ 2.525805] spi-nor spi4.0: mx25u12835f (16384 Kbytes) > > Signed-off-by: Chukun Pan > --- > arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y rockchip/rk3568-rock-3a.dtb' for 20240408124005.182565-1-amadeus@jmu.edu.cn: arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts:765.3-15: Warning (reg_format): /spi@fe300000/flash@0:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format' arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format' arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format' arch/arm64/boot/dts/rockchip/rk356x.dtsi:1091.20-1100.4: Warning (spi_bus_bridge): /spi@fe300000: incorrect #address-cells for SPI bus also defined at arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts:760.6-770.3 arch/arm64/boot/dts/rockchip/rk356x.dtsi:1091.20-1100.4: Warning (spi_bus_bridge): /spi@fe300000: incorrect #size-cells for SPI bus also defined at arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts:760.6-770.3 arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format' arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dtb: Warning (spi_bus_reg): Failed prerequisite 'spi_bus_bridge' arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts:763.10-769.4: Warning (avoid_default_addr_size): /spi@fe300000/flash@0: Relying on default #address-cells value arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts:763.10-769.4: Warning (avoid_default_addr_size): /spi@fe300000/flash@0: Relying on default #size-cells value