Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp2001360lqe; Tue, 9 Apr 2024 07:04:39 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU5ZBYQHSvn+b9ftzALD50HgtRXElnYrwz2QP6g3wPRCvQlhtOpQ9bjprbq6Tdbs7XeaLUESBnv7EkCpmViJNkWU1F+Hte30/qnYpyjYA== X-Google-Smtp-Source: AGHT+IE2cIztGi/9lbslb/jhz8wSa6zGc5xsHqr8V1zcSf4Jje8wc14kaAbEzSPCfiNpj9FAUFQJ X-Received: by 2002:a17:902:bb16:b0:1e0:b60f:5de3 with SMTP id im22-20020a170902bb1600b001e0b60f5de3mr3451657plb.7.1712671479153; Tue, 09 Apr 2024 07:04:39 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712671479; cv=pass; d=google.com; s=arc-20160816; b=uI7gs1JEPdOvijkzo3DWNyfPbxkybmzlJQWDQXiZVNdN3v/UeRtAVHNQR9QaTrUiGH kgUjo+OAmleycy7/HBZZBi0Pqal6Wob9544UqbKnqIrctTINlSz/QKz2zj3cIbt9OWLU eEhymFuMVAq+iyBGiCjil+iLx/WEtPxyaPuVB7CH9FsqVrtTaptGtaEtXXChMt8mtb+G YT9jS/9IVcU68TSO+QjobUk9xJT91go/OnPCLyYQ4YC5NKQmpAf7VEsozk81ebXNKBcI +IoA8YTKwJFPJdwtDe/aCmer6m/RYfAsdHZG0zOauvmGlKH1gq1t5NkE2H+BAEw/zyWL wnoA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date; bh=kM1BUwXXEiGl6OeCEpEfJfC1rd0xrarcVh2otN5ZVcU=; fh=lAzRl2MhkF4PABMHkTNiygIJtipfiw8EtKY8GOg6ecc=; b=G/0+kDID3AoXF6mP4fzc+yVLkPcAbQKWrEOxIXEHvKVQZUeGw3hGybitpxMsT6SAwP ov89CnfjmNHfHz4T8hjamqCn3UZkTCV5CKR0bhtvTr7Z7DvBiOfWszQTAZ4MwOu6jlSw /HooTovFst/oFQZEShZLD6l089c+YjXxfirAlc7yszfAnFrn4vduyfKozlRRwE8WBM8B Lls4U3U7Z4/tjB7lgmqzU4GdwFwIZ6KTPaCyG++7Axk6XpOyRTA701sQm7NwqubgdrKs k2xnBQeQIsQRRHDZU3CiUyFVp0OqLBNGA2caWslTG6sqmpOfAAw2JxbfXKqmCUBjQ8Yt LyaA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-kernel+bounces-137037-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-137037-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id q18-20020a170902dad200b001dc4b6c737dsi8861844plx.338.2024.04.09.07.04.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 07:04:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-137037-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-kernel+bounces-137037-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-137037-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 7D941283896 for ; Tue, 9 Apr 2024 13:59:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E680412FB31; Tue, 9 Apr 2024 13:59:09 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 248897BAF3 for ; Tue, 9 Apr 2024 13:59:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712671149; cv=none; b=ldZeltvm18X3/K62KdVcy/RwGYR2WSvn6LSJ8kKNb0xW5AEgVKdCfJ8jhTh/ZNLempKVmkLdeo9hoaqz+b+WjAhT0efYUP8lhI4k58bIGK/AAqLztpVzBHLV1JzJwIjeybRq6zyV6CJkxxj98PnGiLxeTmARQgBw5Jcudiiu/g0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712671149; c=relaxed/simple; bh=HhVZ25bmFK6NaOk9VYredBVKj1M6DjxkjjEd4lA97Mk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=O2ESKQIUBaKrVni4tB+vfJHmvSa08m56TmiVnWdk3xO2+HCLtsF68GsDRMFu1nwSJxZHlPtA3cWbnsahQVtD1M/S4UenOXf0d2DCmBxOOZBXBFScOZ+x1wty7HoHqwMgr5ImlsmtTIY80x9pGJkii5NBxF3t6wJ6G/aOBUIvVog= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id C6AEA68B05; Tue, 9 Apr 2024 15:59:04 +0200 (CEST) Date: Tue, 9 Apr 2024 15:59:04 +0200 From: Christoph Hellwig To: Daniel Wagner Cc: Christoph Hellwig , Keith Busch , Sagi Grimberg , James Smart , Hannes Reinecke , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/6] nvme: authentication error are always non-retryable Message-ID: <20240409135904.GA20883@lst.de> References: <20240409093510.12321-1-dwagner@suse.de> <20240409093510.12321-2-dwagner@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240409093510.12321-2-dwagner@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) On Tue, Apr 09, 2024 at 11:35:05AM +0200, Daniel Wagner wrote: > From: Hannes Reinecke > > Any authentication errors which are generated internally are always > non-retryable, so use negative error codes to ensure they are not > retried. Thanks, this looks much better now: Reviewed-by: Christoph Hellwig