Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp2002268lqe; Tue, 9 Apr 2024 07:05:37 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWT601jJFR4vDxAJ9mSNzgGCZ4jAfZyjrBPIEoXGu+Us0C/0ITtVvZnQY7OGAg4VUJxjAahTmFaFJMHqZoxMl92d92LCYztuBombBYZ0A== X-Google-Smtp-Source: AGHT+IHjvvCOu11p5Yc2R0VSKrO2NU8y8NMOwooKGl3d0cuNU+kcwKn8eymSiq0PMK+hHTAOeHxn X-Received: by 2002:a05:6a00:4fc8:b0:6ed:41f3:cd06 with SMTP id le8-20020a056a004fc800b006ed41f3cd06mr5821216pfb.7.1712671537361; Tue, 09 Apr 2024 07:05:37 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712671537; cv=pass; d=google.com; s=arc-20160816; b=zoYBRiga3UVpdipndR2+BKF4LpNVsGUlN08a+hoAg1qmuQS+8cnVfkWrZmevBnunko pjvpEw8gv4Fv/ozY0Op358vk5L5crd+IraFKKdNnR64x+urdgbA91uDVSwUkMPMAIIqQ pkotjPYamOklQ2uIAR6ckrxFvLSqPmQJGSDSLd0HOBUhmGKAEwzQ5gl9qZ5ah5jbktPh ftR9K4qtsVc7MvNJXwlKlpnBLvtKwGrwFCRsZRfBklNrliLWGUM4EtNVJ5KQnwjmpcS4 l2/cvkzBGpXuyLbW1DxNUQP5w2Rl/sjzonWFBhdTwFFJAfDs74Wte1aehwEabLH1m8/N 3hGQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date; bh=UYc73ySEqrJW5sxZAqEAigreqRM+TWlm3tDMZKgzWsU=; fh=x0iK/jePAhv1+mthyQ/s9tOT5Xi/RwxZqwOImLE7vws=; b=blBX3UQi50pLe5bGMcrAK9PShRBmWpkaWDRQIGjZfGmN7XYfR44iiNGyjXqrs6TQit ekO2qj7Vyuu7IefKdLuWl8ukJj/7JSR1Cb2GNJih5MnhQchdKgvGUNwejWLu8Eb45J9k oucJWnCe51J/VTkl4OmO8yv/whRpRZHohV6Lb470YL8uFc+jFoil/Cbes3HLSTQWk9RM X2EX6+EMKYzX1OQycqLHAblS9hv2fUYpAvDWBJa5E+jUWf1s3FNcDIMknd6LP1MpCdeu G7IQ3MIARaSh3DPXt1GJy2MVhc3MMb/+EFjvO+719kFPZjnCvo72uLZi14I+/xrFv65Z z0uw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-kernel+bounces-137042-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-137042-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id p41-20020a056a000a2900b006e6b34c3209si8740225pfh.350.2024.04.09.07.05.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 07:05:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-137042-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-kernel+bounces-137042-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-137042-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 75F3D284D9F for ; Tue, 9 Apr 2024 14:01:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B7D5012FF62; Tue, 9 Apr 2024 14:00:59 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB3B112F58C for ; Tue, 9 Apr 2024 14:00:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712671259; cv=none; b=D7D3/hgt0V6+aXk/h3zVtsndh0Lp1btkD3wadp4YgiV+TQ4N6PY1eLIj1xkRtAqZD+ZdRULL6eepLpKBYW7uhwXvRZ3mP51h0s8IgM7TuqUpDNS4mLfd3qJAqpBkIzONi6YL2fpODCeKlWW3FjmYGP3dceKI+I4aAw3xl+BofJ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712671259; c=relaxed/simple; bh=ronNM7eHHbMgozldHtmyQ8+LOdltNvBq/DzQX5wuWgg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aG/zB21JMZlabfSMl0XjtTEchBuZoFl5cJXKXTN+GAKYqDJIiy79jRHxxwR2CFmFhuvn/HnqTfBCLF76ia8/WYtUwtJkPlSw8Fp+j2jyqd/m1CGtlkIzDnBzKXQJkCLF/AUv8KFP3gRJKC/CT13KwuvwAKhJsyBkbFp1VX4hwsc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 9CE6468B05; Tue, 9 Apr 2024 16:00:54 +0200 (CEST) Date: Tue, 9 Apr 2024 16:00:54 +0200 From: Christoph Hellwig To: Daniel Wagner Cc: Christoph Hellwig , Keith Busch , Sagi Grimberg , James Smart , Hannes Reinecke , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Chaitanya Kulkarni Subject: Re: [PATCH v5 4/6] nvme-rdma: short-circuit reconnect retries Message-ID: <20240409140054.GC20883@lst.de> References: <20240409093510.12321-1-dwagner@suse.de> <20240409093510.12321-5-dwagner@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240409093510.12321-5-dwagner@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) On Tue, Apr 09, 2024 at 11:35:08AM +0200, Daniel Wagner wrote: > From: Hannes Reinecke > > Returning an nvme status from nvme_rdma_setup_ctrl() indicates that the Shouldn't this an be an a based on my highschool english. Or does Eeenvme count as a vowel? Otherwise looks good: Reviewed-by: Christoph Hellwig