Received-SPF: pass (google.com: domain of linux-kernel+bounces-137056-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 9 Apr 2024 14:03:50 +0000
From: Daniel Machon <daniel.machon@microchip.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>
CC: "David S. Miller" <davem@davemloft.net>, Andrew Lunn <andrew@lunn.ch>,
	Eric Dumazet <edumazet@google.com>, Florian Fainelli <f.fainelli@gmail.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, "Vladimir
 Oltean" <olteanv@gmail.com>, Woojung Huh <woojung.huh@microchip.com>, "Arun
 Ramadoss" <arun.ramadoss@microchip.com>, Florian Fainelli
	<florian.fainelli@broadcom.com>, <kernel@pengutronix.de>,
	<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
	<UNGLinuxDriver@microchip.com>, David Ahern <dsahern@kernel.org>, "Simon
 Horman" <horms@kernel.org>, Willem de Bruijn <willemb@google.com>,
	=?utf-8?B?U8O4cmVu?= Andersen <san@skov.dk>
Subject: Re: [PATCH net-next v5 1/9] net: dsa: add support for DCB get/set
 apptrust configuration
Message-ID: <20240409140350.vgi52z75qygbwgid@DEN-DL-M70577>
References: <20240409081851.3530641-1-o.rempel@pengutronix.de>
 <20240409081851.3530641-2-o.rempel@pengutronix.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240409081851.3530641-2-o.rempel@pengutronix.de>

Hi Oleksij

> +static int __maybe_unused
> +dsa_user_dcbnl_set_apptrust(struct net_device *dev, u8 *sel, int nsel)
> +{
> +       struct dsa_port *dp = dsa_user_to_port(dev);
> +       struct dsa_switch *ds = dp->ds;
> +       int port = dp->index;
> +

This should be !ds->ops->port_set_apptrust, right :-)

> +       if (!ds->ops->port_get_apptrust)
> +               return -EOPNOTSUPP;
> +
> +       return ds->ops->port_set_apptrust(ds, port, sel, nsel);
> +}