Received-SPF: pass (google.com: domain of linux-kernel+bounces-137084-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 9 Apr 2024 17:26:13 +0300
From: Serge Semin <fancer.lancer@gmail.com>
To: Minda Chen <minda.chen@starfivetech.com>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>, 
	Jose Abreu <joabreu@synopsys.com>, "David S . Miller" <davem@davemloft.net>, 
	Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, 
	Paolo Abeni <pabeni@redhat.com>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, 
	netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, 
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] Add missing mmc statistics in DW GMAC
Message-ID: <qfsmz4mtjknbul2e43mvqghinqvpqq3hsnp5p5prtpbmoa47at@g3zuvdq7kirx>
References: <20240408012943.66508-1-minda.chen@starfivetech.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240408012943.66508-1-minda.chen@starfivetech.com>

On Mon, Apr 08, 2024 at 09:29:41AM +0800, Minda Chen wrote:
> Add miss MMC statistic in DW GMAC
> 
> base on 6.9-rc1
> 
> changed
> v2:
>    patch2 : remove mmc_rx_control_g due to it is gotten in
> ethtool_ops::get_eth_ctrl_stats.

The series has already been merged in. Just a small note about the
patches. Both the changes seems reasonable:
LPI-statistics for DW GMAC and DW QoS Eth,
and
Rx-Recv and Tx-oversize errors stat for DW GMAC and DW QoS Eth.
The former stats has originally been added for DW XGMAC and the later
stats aren't supported by DW XGMAC. So the provided change is
complete. Thanks.

Reviewed-by: Serge Semin <fancer.lancer@gmail.com>

-Serge(y)

> 
> Minda Chen (2):
>   net: stmmac: mmc_core: Add GMAC LPI statistics
>   net: stmmac: mmc_core: Add GMAC mmc tx/rx missing statistics
> 
>  drivers/net/ethernet/stmicro/stmmac/mmc.h         |  2 ++
>  drivers/net/ethernet/stmicro/stmmac/mmc_core.c    | 15 +++++++++++++++
>  .../net/ethernet/stmicro/stmmac/stmmac_ethtool.c  |  2 ++
>  3 files changed, 19 insertions(+)
> 
> 
> base-commit: 4cece764965020c22cff7665b18a012006359095
> -- 
> 2.17.1
> 
>