Received-SPF: pass (google.com: domain of linux-kernel+bounces-137099-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Tue, 9 Apr 2024 16:34:23 +0200
From: Thomas Bogendoerfer <tbogendoerfer@suse.de>
To: Simon Horman <horms@kernel.org>
Cc: Jay Vosburgh <j.vosburgh@gmail.com>, Andy Gospodarek
 <andy@greyhouse.net>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet
 <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni
 <pabeni@redhat.com>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] bonding: 802.3ad: Avoid packet loss when switching
 aggregator
Message-ID: <20240409163423.7d0b8fe9@samweis>
In-Reply-To: <20240406160354.GW26556@kernel.org>
References: <20240404114908.134034-1-tbogendoerfer@suse.de>
	<20240406160354.GW26556@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Sat, 6 Apr 2024 17:03:54 +0100
Simon Horman <horms@kernel.org> wrote:

> On Thu, Apr 04, 2024 at 01:49:08PM +0200, Thomas Bogendoerfer wrote:
> > If selection logic decides to switch to a new aggregator it disables
> > all ports of the old aggregator, but doesn't enable ports on
> > the new aggregator. These ports will eventually be enabled when
> > the next LACPDU is received, which might take some time and without an
> > active port transmitted frames are dropped. Avoid this by enabling
> > already collected ports of the new aggregator immediately.
> >=20
> > Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de> =20
>=20
> Hi Thomas,
>=20
> I will leave the technical review to Jay and others.  But as a fix, I thi=
nk
> this patch warrants a Fixes tag. It should be sufficient to respond to th=
is
> email thread with an appropriate tag.

current behavior is older than our git tree. So should I really add

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")

?

Thomas.

--=20
SUSE Software Solutions Germany GmbH
HRB 36809 (AG N=C3=BCrnberg)
Gesch=C3=A4ftsf=C3=BChrer: Ivo Totev, Andrew McDonald, Werner Knoblich