Received-SPF: pass (google.com: domain of linux-kernel+bounces-137180-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 09 Apr 2024 11:05:46 -0400
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Richard Gobert <richardbgobert@gmail.com>, 
 davem@davemloft.net, 
 edumazet@google.com, 
 kuba@kernel.org, 
 pabeni@redhat.com, 
 willemdebruijn.kernel@gmail.com, 
 dsahern@kernel.org, 
 netdev@vger.kernel.org, 
 linux-kernel@vger.kernel.org, 
 linux-kselftest@vger.kernel.org
Cc: Richard Gobert <richardbgobert@gmail.com>
Message-ID: <6615594ab06f2_23a2b22945@willemb.c.googlers.com.notmuch>
In-Reply-To: <20240408141720.98832-5-richardbgobert@gmail.com>
References: <20240408141720.98832-1-richardbgobert@gmail.com>
 <20240408141720.98832-5-richardbgobert@gmail.com>
Subject: Re: [PATCH net-next v5 4/6] net: gro: add {inner_}network_offset to
 napi_gro_cb
Precedence: bulk
Mime-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: 7bit

Richard Gobert wrote:
> This patch adds network_offset and inner_network_offset to napi_gro_cb, and
> makes sure both are set correctly. In the common path there's only one
> write (skb_gro_reset_offset).
> 
> Signed-off-by: Richard Gobert <richardbgobert@gmail.com>
> ---
>  include/net/gro.h      | 18 ++++++++++++++++--
>  net/8021q/vlan_core.c  |  2 ++
>  net/core/gro.c         |  1 +
>  net/ethernet/eth.c     |  1 +
>  net/ipv4/af_inet.c     |  5 +----
>  net/ipv4/gre_offload.c |  1 +
>  net/ipv6/ip6_offload.c |  8 ++++----

Should this cover more protocols, like geneve, ipsec?