Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp2065483lqe; Tue, 9 Apr 2024 08:36:11 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVHpRi/C/QOLXvLJRAd5JygLBBlsZ/zb9tFlDywmeEuXgqhcyUzoMT3HxBWncC3pRbrTjrGKeevgfHOioJ2sLw8/yWj7ma+l/bK3pEVsA== X-Google-Smtp-Source: AGHT+IEK2rqO0ZFuwebaIMgn86L3sBMBNvUsjKDNS7nWmkfDog7CIDeuaHWhBft+LT1kcRF8QQR5 X-Received: by 2002:a17:90a:3904:b0:299:3035:aede with SMTP id y4-20020a17090a390400b002993035aedemr8952310pjb.44.1712676970851; Tue, 09 Apr 2024 08:36:10 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712676970; cv=pass; d=google.com; s=arc-20160816; b=YjgXlg6R0fw9WGVSwrow3JpxzAV6dD9X2MIFa4DyBRkIr4I9vCgoePxB7Bbw6DhvOG l8YZeT2WkrFcLdFjQ9lmHfDvxkdYutkixZIOJqfsL96W5d/jhOeGaqY6gNsHjMPoDNg/ 0l0GKs0yKs9eUqM0uNXwhcMzIlynegjd73jWKEm5sebNsSzEma3UjTbmAvaViu/8/y6H qxPVwi4iheSeudvwkYx7aoI7ESLDYFgb0l8M3b7IqMqC3tQJboalDILxMJHL72vsVvCM DgZmmAsaZs1HSaV6w+nqkgS3y2Vj2mBsagytXTpMh26dtjKWUTFeOWKey8oRNFjdDA4E evMw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=SiYbv/7RFRmBNI+0nPsuQNTBwEsVPPSeu91+nBNK0G8=; fh=czy2JmXqFLp+bS5JbW67G1+ZVbsZ1MfC9/KwpHtxsFA=; b=LElldpeBHaE0hCFA12qj0T/FjY9GlCec+/pTf1XizLdJ8cCrY2XfdY09xo7JcBj2JE ffGGnaJ9eQrTzx8wQNpExeePZYYgGUqlcSnV2Fk0YaNYkKwmi2Y2J7FHSWUAAsfrvy2B rB1e0CN9aUSGNc5O05D0SbZZaHRq9Zr+db2TUV5h34CqBvZIFz3olBrIYIdM3NWACK8u 8tQQA/YTmDI7Saor1GkxZp40yL+dL6g7fwZc3tK7xw3N/Yn+6eAGyT2g3g9pYng2dNYi zvHyzk5blMu2lKyNbxGCrzns2sVwZxv6hVbehZl8U4sXR8ij8vZTcERgYHkXs2pk2zRW h6ug==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ejUTFtJ0; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-137203-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-137203-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id g9-20020a17090ace8900b002a5290b0d42si3754773pju.187.2024.04.09.08.36.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 08:36:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-137203-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ejUTFtJ0; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-137203-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-137203-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id E9800298BCF for ; Tue, 9 Apr 2024 15:20:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1171C1353EC; Tue, 9 Apr 2024 15:19:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ejUTFtJ0" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36B39132471; Tue, 9 Apr 2024 15:19:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712675970; cv=none; b=bVb53Dkg/SoemV+9R6fXoCqcByG8bJrtr2XLw4dNC/pE+ch47M4bq7H3PyCySOb3jxtYy76Fp/IdVr98dOx+SEeIkNQTtnofgzoy+zo56TCZJg7B5AhlTNRzihb7UGs0MajGEceiYChMyhYKHDWKrq/JTl9wtvM5tnWWL0asMlc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712675970; c=relaxed/simple; bh=qa4rli8S2cx06P+slXxB/kOqeXSUVhNJc+VYYce+NQU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rF5TqeK/5OlDYHM7P3OO3mHQOM7arBs35iEfz1Q/xiSUbH0xqUicCQY2tUHJbiprLJPmZ1t71I7O8h0IkAXZlZJHhLkGjQdpaDgU6/ewczOQovUdm1ilfT2kWYojusHLbZW76YblxQmi4ZExffZNpWB+7Ope9fzDEEQZEUmUhY4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ejUTFtJ0; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64713C43390; Tue, 9 Apr 2024 15:19:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1712675969; bh=qa4rli8S2cx06P+slXxB/kOqeXSUVhNJc+VYYce+NQU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ejUTFtJ0fc9EfF2toX//oGWQs/GwTwR9n+S2NnT7st8k62J7XuRG/nAqCBJ6cRhLB iyvrrvspq7wNnk1naCosc0sy9OplKz3i3jfr0hXh4iTeHKkgBvDRVFy6UQoIP7mh5h oydk9jPHD0wVRaNIXRQ0dNYF3Ci/3gzuSuAHMQN4= Date: Tue, 9 Apr 2024 17:19:27 +0200 From: Greg KH To: Andrew Ballance Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Thinh.Nguyen@synopsys.com, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org Subject: Re: [PATCH] usb/dwc3: replace of_node_put with __free Message-ID: <2024040953-blade-entryway-5091@gregkh> References: <20240406024838.537630-1-andrewjballance@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240406024838.537630-1-andrewjballance@gmail.com> On Fri, Apr 05, 2024 at 09:48:38PM -0500, Andrew Ballance wrote: > this relaces instances of of_node_put with __free(device_node) > in drivers/usb/dwc3/core.c Why? You need to always describe _why_ you do something, not _what_ you do. thanks, greg k-h