Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp2068825lqe; Tue, 9 Apr 2024 08:42:15 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCX7A+x2cjMjA+86KMp2c6EytGGOxN/DlsUxAmUnlo+aq72thI73ETgQ1idg9UvypJthtXPVRIowkW93dc4Y45syorm+aJCzmwdZbKnczw== X-Google-Smtp-Source: AGHT+IH0GHA3T0ggCzxFVPMEeXdcVlASx90S1qEGROgcqD3oK152PvDX5B5cg1OxsAy/CWyaY5Y7 X-Received: by 2002:a17:903:292:b0:1e4:91c3:3556 with SMTP id j18-20020a170903029200b001e491c33556mr134941plr.52.1712677334958; Tue, 09 Apr 2024 08:42:14 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712677334; cv=pass; d=google.com; s=arc-20160816; b=G4EvrBcaPP3RqqLdyGeOwRoSXx5rv9xyQ0+WcfEUEF8tvNBrgasYQzEib50whW/O5E vcije6wn73xB9xRyJQ3dc1X1t6nGZM5S+fM7431ptRC98BDnIADTAs8bbmH3N+X94TkY lBiOPFMnt+b0C0pWzmnrDBCAifa+zcY+Qzu/Citu97yw6xi6G55tIMIDF8y09tGcEAEi AkNfhZOxDherqBhaDkybQiSO+59eARylBk0N2U6h79djqyUdf0pDn2nyB9IzrCi34/3t DRPz+gTJ0QD7Wo47BDOgnLTyzig0eSiObXTOlLFxaxD39K//09K9/KDnBfuReDk1Jd13 6Nlw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=RLT8H8fINPqK7RHyfJI58pBwUn9S0wrii0pQWK1wCOw=; fh=HSPbcqlnE/Y/263R7Ro11GYxg0btWlQtGpXcRy9D/wI=; b=wqUwFx3EoaDnj2g3jUBwnhRQpCqc0A1GSdN93+cT5xDd46Zn0gpupWnINNPtHH2VFT LkkyZ+l9TnBS7jIHTkiHAz6qhYT3dhE0KeDlMd5knLmaM7eBkXTkOdPdbbLHz1k7hzWE wCjJnE9+0yrVmGjVjnidAzgAuzfAdOULNCgessUTTN8bIYNfa77lbBjNxbhWvajZPUaw KfaWXlHZmMqzznSjywX8j7N41Fipfj2XKBMs6ooXFqCc+E/BH3cnegvgzMlsgbXOU8pb cGRmHucznAiDviVkOUMDvUj9XhH2T9dwU5C7q/KhueXCsbwmAvB0v2pgAPUV6K7rG9AP agdA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=OLNfYIny; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-137226-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-137226-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id jw20-20020a170903279400b001e0b87153e5si8729809plb.39.2024.04.09.08.42.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 08:42:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-137226-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=OLNfYIny; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-137226-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-137226-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id BAA6F28C563 for ; Tue, 9 Apr 2024 15:32:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9330413B2A9; Tue, 9 Apr 2024 15:29:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="OLNfYIny" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B73FD132810; Tue, 9 Apr 2024 15:29:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712676552; cv=none; b=XLQDJVt/KTLA7Q/QHWTXiRvMPdsu+Jz5s+ePUyrP0qWAP2kuk0pFJujV0TZT//s59IpvXdozOzggDC6hwUrjHwKg60DchOcnKhOrIlim6F/us9oDFD4ReA0JE6xWJTbEy4rpeZm+CK4BjgcQoDlQBpF3Q67bgl7mWzLESZA/LbI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712676552; c=relaxed/simple; bh=Ovk2lUwjKUquZfwSJWiaIX5okILvbbqLtD2JU+sKtBU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DWiY4efN/4drZ41XveJCtpXZi+9uNlTYMfaIKGaF0dJcVTezRasdtrIlMC4DXjKtNRcBKc1/2DjujI+1Aa3+x4gsK+0MC8Ib/dPnyKjE6MaMzsly6tFUYYt9Lu9LOz2Qzw6nB/hMCW3cUAEAz/BimzM5MsA79ibHQYglhoZ3z1M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=OLNfYIny; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id F00B7C433B2; Tue, 9 Apr 2024 15:29:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1712676552; bh=Ovk2lUwjKUquZfwSJWiaIX5okILvbbqLtD2JU+sKtBU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OLNfYInyzbhsqmRMj/3UG1QI0lozVIA4uWkNe/Hi2oZGow6UfdzOXiclixq2ehR9Y qovYUtwIkplTpxtXhZFvsqFHakOxeax2VoKXgcATs1A0fEted1/KJF3AUD6BrEqlk3 P0hANRCvsCu+YKxyZ+c2PT6prHysJrynCz9VQg3M= Date: Tue, 9 Apr 2024 17:29:09 +0200 From: Greg KH To: Fabio Estevam Cc: mka@chromium.org, frieder.schrempf@kontron.de, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Fabio Estevam Subject: Re: [PATCH] usb: misc: onboard_usb_hub: Disable the USB hub clock on failure Message-ID: <2024040940-resume-polygraph-5800@gregkh> References: <20240408151700.1761009-1-festevam@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240408151700.1761009-1-festevam@gmail.com> On Mon, Apr 08, 2024 at 12:17:00PM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > In case regulator_bulk_enable() fails, the previously enabled USB hub > clock should be disabled. > > Fix it accordingly. > > Fixes: 65e62b8a955a ("usb: misc: onboard_usb_hub: Add support for clock input") > Signed-off-by: Fabio Estevam > --- > drivers/usb/misc/onboard_usb_dev.c | 6 +++++- This file is not in the tree for 6.9-rc2, can you please fix this up and resend? thanks, greg k-h